Skip to content

Commit de1e640

Browse files
committed
SWS-918 Fix compiler warnings
The project contains various easy to fix compiler warnings like unused imports, raw types and no longer needed @SuppressWarnings("unchecked"). This change removes: * unused imports * raw types * no longer needed @SuppressWarnings("unchecked") Issue: SWS-918 https://jira.spring.io/browse/SWS-918
1 parent d212507 commit de1e640

File tree

14 files changed

+16
-26
lines changed

14 files changed

+16
-26
lines changed

spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/adapter/method/jaxb/JaxbElementPayloadMethodProcessor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ protected boolean supportsRequestPayloadParameter(MethodParameter parameter) {
4545
public JAXBElement<?> resolveArgument(MessageContext messageContext, MethodParameter parameter)
4646
throws JAXBException {
4747
ParameterizedType parameterizedType = (ParameterizedType) parameter.getGenericParameterType();
48-
Class<?> clazz = (Class) parameterizedType.getActualTypeArguments()[0];
48+
Class<?> clazz = (Class<?>) parameterizedType.getActualTypeArguments()[0];
4949
return unmarshalElementFromRequestPayload(messageContext, clazz);
5050
}
5151

spring-ws-core/src/main/java/org/springframework/ws/transport/http/HttpServletConnection.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,13 +105,11 @@ public URI getUri() throws URISyntaxException {
105105
*/
106106

107107
@Override
108-
@SuppressWarnings("unchecked")
109108
public Iterator<String> getRequestHeaderNames() throws IOException {
110109
return new EnumerationIterator<String>(getHttpServletRequest().getHeaderNames());
111110
}
112111

113112
@Override
114-
@SuppressWarnings("unchecked")
115113
public Iterator<String> getRequestHeaders(String name) throws IOException {
116114
return new EnumerationIterator<String>(getHttpServletRequest().getHeaders(name));
117115
}

spring-ws-core/src/test/java/org/springframework/ws/config/DummyMarshaller.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public void marshal(Object graph, Result result) throws XmlMappingException, IOE
3232
}
3333

3434
@Override
35-
public boolean supports(Class clazz) {
35+
public boolean supports(Class<?> clazz) {
3636
throw new UnsupportedOperationException();
3737
}
3838

spring-ws-core/src/test/java/org/springframework/ws/soap/axiom/AxiomHandlerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ public void testTransformDom() throws Exception {
233233

234234
private int getNamespaceCount(OMElement element) {
235235
int i = 0;
236-
Iterator namespaces = element.getAllDeclaredNamespaces();
236+
Iterator<?> namespaces = element.getAllDeclaredNamespaces();
237237
while (namespaces.hasNext()) {
238238
namespaces.next();
239239
i++;

spring-ws-core/src/test/java/org/springframework/ws/soap/server/endpoint/adapter/method/SoapHeaderElementMethodArgumentResolverTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ public void resolveSoapHeaderMismatch() throws Exception {
127127
public void resolveSoapHeaderMismatchList() throws Exception {
128128
Object result = resolver.resolveArgument(messageContext, soapHeaderMismatchList);
129129
assertTrue("result must be a List", List.class.isAssignableFrom(result.getClass()));
130-
assertTrue("result List must be empty", ((List) result).isEmpty());
130+
assertTrue("result List must be empty", ((List<?>) result).isEmpty());
131131
}
132132

133133
public void soapHeaderWithEmptyValue(@SoapHeader("") SoapHeaderElement element) {

spring-ws-core/src/test/java/org/springframework/ws/soap/soap12/AbstractSoap12MessageTestCase.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,6 @@
2020
import java.io.ByteArrayOutputStream;
2121
import javax.xml.parsers.DocumentBuilder;
2222
import javax.xml.parsers.DocumentBuilderFactory;
23-
import javax.xml.soap.MessageFactory;
24-
import javax.xml.soap.SOAPConstants;
25-
import javax.xml.soap.SOAPMessage;
2623
import javax.xml.transform.dom.DOMResult;
2724
import javax.xml.transform.stream.StreamSource;
2825

@@ -33,7 +30,6 @@
3330
import org.springframework.ws.soap.AbstractSoapMessageTestCase;
3431
import org.springframework.ws.soap.SoapBody;
3532
import org.springframework.ws.soap.SoapVersion;
36-
import org.springframework.ws.soap.saaj.SaajSoapMessage;
3733
import org.springframework.ws.transport.MockTransportOutputStream;
3834
import org.springframework.ws.transport.TransportConstants;
3935
import org.springframework.xml.transform.StringSource;

spring-ws-security/src/main/java/org/springframework/ws/soap/security/support/SpringSecurityUtils.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ public abstract class SpringSecurityUtils {
3838
* @throws DisabledException if the account is disabled
3939
* @throws LockedException if the account is locked
4040
*/
41-
@SuppressWarnings("deprecation")
4241
public static void checkUserValidity(UserDetails user)
4342
throws AccountExpiredException, CredentialsExpiredException, DisabledException, LockedException {
4443
if (!user.isAccountNonLocked()) {

spring-ws-security/src/main/java/org/springframework/ws/soap/security/wss4j/Wss4jSecurityInterceptor.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -597,7 +597,6 @@ protected RequestData initializeRequestData(MessageContext messageContext) {
597597
}
598598

599599
@Override
600-
@SuppressWarnings("unchecked")
601600
protected void validateMessage(SoapMessage soapMessage, MessageContext messageContext)
602601
throws WsSecurityValidationException {
603602
if (logger.isDebugEnabled()) {

spring-ws-security/src/test/java/org/springframework/ws/soap/security/support/KeyManagersFactoryBeanTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,8 @@
1717
package org.springframework.ws.soap.security.support;
1818

1919
import javax.net.ssl.KeyManager;
20-
import javax.net.ssl.TrustManager;
2120

2221
import static org.junit.Assert.assertEquals;
23-
import static org.junit.Assert.assertFalse;
2422
import static org.junit.Assert.assertNotNull;
2523
import org.junit.Test;
2624

spring-ws-security/src/test/java/org/springframework/ws/soap/security/support/TrustManagersFactoryBeanTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import javax.net.ssl.TrustManager;
2020

2121
import static org.junit.Assert.assertEquals;
22-
import static org.junit.Assert.assertFalse;
2322
import static org.junit.Assert.assertNotNull;
2423
import org.junit.Test;
2524

0 commit comments

Comments
 (0)