Skip to content

mime message helper throwing illigal address in string #35117

Open
@Hardcore-fs

Description

@Hardcore-fs

current version.
does not trap empty to,cc & bcc.

** Bug Reports **

public void sendMimeMail(String encoding,  String[] toAddress,String[] 
toCcAddress,String toBccAddress, String fromAddress, String subject, 
String body) {
    JavaMailSender javaMailSender = (JavaMailSender) mailSender;
    MimeMessage mime = javaMailSender.createMimeMessage();
    MimeMessageHelper helper;
    try {
        helper = new MimeMessageHelper(mime, true, encoding);
        helper.setFrom(fromAddress);
        helper.setSubject(subject);
        helper.setTo(toAddress);
        helper.setBcc(toBccAddress);
        helper.setText(body);
        javaMailSender.send(mime);
    } catch (MessagingException me) {
        me.printStackTrace();
    }
}

if you are building a list of email addresses , for each type to,cc,bcc
and one of them happens to have an empty string in the array, or spaces
then you get the following error.

it also occurs if say there is no BCC in this particular email.

before passing things strings over to the internal parser, it should perhaps trim & check for empty strings.

yep we could it in the app code , however the helper should be trapping this as well

jakarta.mail.internet.AddressException: Illegal address in string ``''
	at 
org.springframework.mail.javamail.MimeMessageHelper.parseAddress(MimeMessageHelper.java:737)
	at 
org.springframework.mail.javamail.MimeMessageHelper.setBcc(MimeMessageHelper.java:704)
	at 
com.gp.erp.service.implementations.MailService.sendMimeMail(MailService.java:145)/

Metadata

Metadata

Assignees

No one assigned

    Labels

    in: coreIssues in core modules (aop, beans, core, context, expression)status: waiting-for-triageAn issue we've not yet triaged or decided on

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions