Skip to content

Make built-in RetryPolicy implementations final #35040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sbrannen opened this issue Jun 12, 2025 · 0 comments
Closed

Make built-in RetryPolicy implementations final #35040

sbrannen opened this issue Jun 12, 2025 · 0 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
7.0.0-M7

Comments

@sbrannen
Copy link
Member

The built-in RetryPolicy implementations are currently not declared as final, which makes it technically possible to extend them.

However, they are not actually designed to be extensible.

  1. Their fields are private and do not have accessor methods.
  2. Their RetryExecution implementations are also private, which prevents reuse.

In light of the above, we should make all built-in RetryPolicy implementations final.
@sbrannen sbrannen added this to the 7.0.0-M7 milestone Jun 12, 2025
@sbrannen sbrannen self-assigned this Jun 12, 2025
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
7.0.0-M7
Development

No branches or pull requests
1 participant
@sbrannen