Skip to content

Re-instate support for Commons File Upload #35036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdeinum opened this issue Jun 12, 2025 · 2 comments
Open

Re-instate support for Commons File Upload #35036

mdeinum opened this issue Jun 12, 2025 · 2 comments
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: feedback-provided Feedback has been provided status: waiting-for-triage An issue we've not yet triaged or decided on

Comments

@mdeinum
Copy link
Contributor

mdeinum commented Jun 12, 2025

Overview

The Apache Commons FileUpload project has been working on putting out Commons FIleUpload2 which is compatible with JakartaEE APIs.

Maybe it is worth to re-instate the support for Commons FIle Upload (if they can release a final version in time).

Related Issues:

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 12, 2025
@sbrannen sbrannen added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Jun 12, 2025
@bclozel
Copy link
Member

bclozel commented Jun 12, 2025

Hey Marten,

We've deprecated then removed this variant in favor of the StandardServletMultipartResolver, backed by the Servlet container. Is there any particular reason to bring this back? Any feature that the standard Servlet support is missing?

@bclozel bclozel added the status: waiting-for-feedback We need additional information before we can continue label Jun 12, 2025
@mdeinum
Copy link
Contributor Author

mdeinum commented Jun 16, 2025

Well the only one I can think of is using streaming file uploads but that bypasses the MultipartResolver already so for that it isn't really needed. It is not so much that I need it personally but I do see questions on StackOverflow if support is still there or will be re-added.

As I knew it was dropped as there wasn't a JakartaEE version of Apache File Upload when Spring 6 started developing so support had to be dropped. As there now is a JakartaEE version I thought (in light of the community questions) to re-instate it.

Another option I suspect would be to have the Apache File Upload team provide the Spring implementation.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: feedback-provided Feedback has been provided status: waiting-for-triage An issue we've not yet triaged or decided on
Projects
None yet
Development

No branches or pull requests

4 participants