Skip to content

Migrate away from AssertJ's catchThrowable() #35003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sbrannen opened this issue Jun 6, 2025 · 0 comments
Closed

Migrate away from AssertJ's catchThrowable() #35003

sbrannen opened this issue Jun 6, 2025 · 0 comments
Assignees
@sbrannen
Labels
type: task A general task
Milestone
7.0.0-M6

Comments

@sbrannen
Copy link
Member

sbrannen commented Jun 6, 2025

While reviewing #34821, I noticed that we use org.assertj.core.api.Assertions.catchThrowable(ThrowingCallable) when we really should be using assertThatExceptionOfType() or similar.
@sbrannen sbrannen added this to the 7.0.0-M6 milestone Jun 6, 2025
@sbrannen sbrannen self-assigned this Jun 6, 2025
@sbrannen sbrannen added the type: task A general task label Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
type: task A general task
Projects
None yet
Milestone
7.0.0-M6
Development

No branches or pull requests
1 participant
@sbrannen