Skip to content

Align KeyValues of Scheduled-annotated observability with OpenTelemetry conventions #30721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arik-dig opened this issue Jun 22, 2023 · 2 comments
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: observability An issue related to observability and tracing type: enhancement A general enhancement
Milestone

Comments

@arik-dig
Copy link

following comment #29883 (comment) it seems that provided tag entries are method.name and target.type
so first I think that target.type is missing the package name so the type would would be fully qualified name.
second, in order to be compatible with OpenTelemetry maybe you should consider use the standard Semantic conventions
so method.name would become code.function
and target.type would become code.namespace (including the package name of course)

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 22, 2023
@jonatan-ivanov
Copy link
Member

Let me try to add a few details.

As far as I know @arik-dig's use case is trying to connect spans to code. Basically spans that were emitted because @Scheduled is now instrumented, I guess in order to do this the fully qualified class name is needed.

As far as I know the linked semantic conventions are not stable so I think it worth considering if it makes more sense than the current one but I would definitely not make the change only the sake of being compatible with it since OTel semantic conventions are subject to change, we can be compatible today but that might change tomorrow.

@bclozel bclozel self-assigned this Jun 22, 2023
@bclozel bclozel added the theme: observability An issue related to observability and tracing label Jun 22, 2023
@bclozel bclozel added this to the 6.1.0-M2 milestone Jun 22, 2023
@bclozel bclozel added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 22, 2023
@bclozel
Copy link
Member

bclozel commented Jun 22, 2023

Using the full class name makes sense. Using code.function and code.namespace as KeyValues sounds reasonable although quite generic. I'll consider this with this issue.

@bclozel bclozel changed the title Enhancement/tags of Scheduled-annotated observability to meet OpenTelemetry semantic convention Align KeyValues of Scheduled-annotated observability with OpenTelemetry conventions Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: observability An issue related to observability and tracing type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants