Skip to content

Commit ac3c1b8

Browse files
committed
Introduce Jackson 3 support for spring-websocket
This commit introduces a JacksonJsonSockJsMessageCodec Jackson 3 variant of Jackson2SockJsMessageCodec. See gh-33798
1 parent a0ed3f0 commit ac3c1b8

File tree

12 files changed

+110
-31
lines changed

12 files changed

+110
-31
lines changed

spring-websocket/spring-websocket.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ dependencies {
1717
}
1818
optional("org.eclipse.jetty.websocket:jetty-websocket-jetty-api")
1919
optional("org.eclipse.jetty:jetty-client")
20+
optional("tools.jackson.core:jackson-databind")
2021
testImplementation(testFixtures(project(":spring-core")))
2122
testImplementation(testFixtures(project(":spring-web")))
2223
testImplementation("io.projectreactor.netty:reactor-netty-http")

spring-websocket/src/main/java/org/springframework/web/socket/config/annotation/WebSocketMessageBrokerConfigurationSupport.java

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
import org.springframework.context.ApplicationContext;
2424
import org.springframework.context.annotation.Bean;
2525
import org.springframework.core.task.TaskExecutor;
26-
import org.springframework.http.converter.json.Jackson2ObjectMapperBuilder;
27-
import org.springframework.messaging.converter.MappingJackson2MessageConverter;
2826
import org.springframework.messaging.simp.SimpMessagingTemplate;
2927
import org.springframework.messaging.simp.SimpSessionScope;
3028
import org.springframework.messaging.simp.annotation.support.SimpAnnotationMethodMessageHandler;
@@ -162,17 +160,4 @@ public WebSocketMessageBrokerStats webSocketMessageBrokerStats(
162160
return stats;
163161
}
164162

165-
@Override
166-
protected MappingJackson2MessageConverter createJacksonConverter() {
167-
MappingJackson2MessageConverter messageConverter = super.createJacksonConverter();
168-
// Use Jackson builder in order to have well-known modules registered automatically.
169-
Jackson2ObjectMapperBuilder builder = Jackson2ObjectMapperBuilder.json();
170-
ApplicationContext applicationContext = getApplicationContext();
171-
if (applicationContext != null) {
172-
builder.applicationContext(applicationContext);
173-
}
174-
messageConverter.setObjectMapper(builder.build());
175-
return messageConverter;
176-
}
177-
178163
}

spring-websocket/src/main/java/org/springframework/web/socket/sockjs/client/AbstractClientSockJsSession.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2024 the original author or authors.
2+
* Copyright 2002-2025 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -47,6 +47,7 @@
4747
*
4848
* @author Rossen Stoyanchev
4949
* @author Juergen Hoeller
50+
* @author Sebastien Deleuze
5051
* @since 4.1
5152
*/
5253
public abstract class AbstractClientSockJsSession implements WebSocketSession {
@@ -268,7 +269,7 @@ private void handleMessageFrame(SockJsFrame frame) {
268269
try {
269270
messages = getMessageCodec().decode(frameData);
270271
}
271-
catch (IOException ex) {
272+
catch (RuntimeException | IOException ex) {
272273
if (logger.isErrorEnabled()) {
273274
logger.error("Failed to decode data for SockJS \"message\" frame: " + frame + " in " + this, ex);
274275
}

spring-websocket/src/main/java/org/springframework/web/socket/sockjs/client/SockJsClient.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
import org.springframework.web.socket.WebSocketSession;
4141
import org.springframework.web.socket.client.WebSocketClient;
4242
import org.springframework.web.socket.sockjs.frame.Jackson2SockJsMessageCodec;
43+
import org.springframework.web.socket.sockjs.frame.JacksonJsonSockJsMessageCodec;
4344
import org.springframework.web.socket.sockjs.frame.SockJsMessageCodec;
4445
import org.springframework.web.socket.sockjs.transport.TransportType;
4546
import org.springframework.web.util.UriComponentsBuilder;
@@ -62,6 +63,9 @@
6263
*/
6364
public class SockJsClient implements WebSocketClient, Lifecycle {
6465

66+
private static final boolean jacksonPresent = ClassUtils.isPresent(
67+
"tools.jackson.databind.ObjectMapper", SockJsClient.class.getClassLoader());
68+
6569
private static final boolean jackson2Present = ClassUtils.isPresent(
6670
"com.fasterxml.jackson.databind.ObjectMapper", SockJsClient.class.getClassLoader());
6771

@@ -97,7 +101,10 @@ public SockJsClient(List<Transport> transports) {
97101
Assert.notEmpty(transports, "No transports provided");
98102
this.transports = new ArrayList<>(transports);
99103
this.infoReceiver = initInfoReceiver(transports);
100-
if (jackson2Present) {
104+
if (jacksonPresent) {
105+
this.messageCodec = new JacksonJsonSockJsMessageCodec();
106+
}
107+
else if (jackson2Present) {
101108
this.messageCodec = new Jackson2SockJsMessageCodec();
102109
}
103110
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,78 @@
1+
/*
2+
* Copyright 2002-2025 the original author or authors.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* https://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
17+
package org.springframework.web.socket.sockjs.frame;
18+
19+
import java.io.InputStream;
20+
21+
import com.fasterxml.jackson.core.io.JsonStringEncoder;
22+
import org.jspecify.annotations.Nullable;
23+
import tools.jackson.databind.ObjectMapper;
24+
import tools.jackson.databind.cfg.MapperBuilder;
25+
import tools.jackson.databind.json.JsonMapper;
26+
27+
import org.springframework.util.Assert;
28+
29+
/**
30+
* A Jackson 3.x codec for encoding and decoding SockJS messages.
31+
*
32+
* <p>The default constructor loads {@link tools.jackson.databind.JacksonModule}s
33+
* found by {@link MapperBuilder#findModules(ClassLoader)}.
34+
*
35+
* @author Sebastien Deleuze
36+
* @since 7.0
37+
*/
38+
public class JacksonJsonSockJsMessageCodec extends AbstractSockJsMessageCodec {
39+
40+
private final ObjectMapper objectMapper;
41+
42+
43+
/**
44+
* Construct a new instance with a {@link JsonMapper} customized with the
45+
* {@link tools.jackson.databind.JacksonModule}s found by
46+
* {@link MapperBuilder#findModules(ClassLoader)}.
47+
*/
48+
public JacksonJsonSockJsMessageCodec() {
49+
this.objectMapper = JsonMapper.builder().findAndAddModules(JacksonJsonSockJsMessageCodec.class.getClassLoader()).build();
50+
}
51+
52+
/**
53+
* Construct a new instance with the provided {@link ObjectMapper}.
54+
* @see JsonMapper#builder()
55+
* @see MapperBuilder#findAndAddModules(ClassLoader)
56+
*/
57+
public JacksonJsonSockJsMessageCodec(ObjectMapper objectMapper) {
58+
Assert.notNull(objectMapper, "ObjectMapper must not be null");
59+
this.objectMapper = objectMapper;
60+
}
61+
62+
63+
@Override
64+
public String @Nullable [] decode(String content) {
65+
return this.objectMapper.readValue(content, String[].class);
66+
}
67+
68+
@Override
69+
public String @Nullable [] decodeInputStream(InputStream content) {
70+
return this.objectMapper.readValue(content, String[].class);
71+
}
72+
73+
@Override
74+
protected char[] applyJsonQuoting(String content) {
75+
return JsonStringEncoder.getInstance().quoteAsString(content);
76+
}
77+
78+
}

spring-websocket/src/main/java/org/springframework/web/socket/sockjs/transport/TransportHandlingSockJsService.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@
5151
import org.springframework.web.socket.server.support.HandshakeInterceptorChain;
5252
import org.springframework.web.socket.sockjs.SockJsException;
5353
import org.springframework.web.socket.sockjs.frame.Jackson2SockJsMessageCodec;
54+
import org.springframework.web.socket.sockjs.frame.JacksonJsonSockJsMessageCodec;
5455
import org.springframework.web.socket.sockjs.frame.SockJsMessageCodec;
5556
import org.springframework.web.socket.sockjs.support.AbstractSockJsService;
5657

@@ -70,6 +71,9 @@
7071
*/
7172
public class TransportHandlingSockJsService extends AbstractSockJsService implements SockJsServiceConfig, Lifecycle {
7273

74+
private static final boolean jacksonPresent = ClassUtils.isPresent(
75+
"tools.jackson.databind.ObjectMapper", TransportHandlingSockJsService.class.getClassLoader());
76+
7377
private static final boolean jackson2Present = ClassUtils.isPresent(
7478
"com.fasterxml.jackson.databind.ObjectMapper", TransportHandlingSockJsService.class.getClassLoader());
7579

@@ -118,7 +122,10 @@ public TransportHandlingSockJsService(TaskScheduler scheduler, Collection<Transp
118122
}
119123
}
120124

121-
if (jackson2Present) {
125+
if (jacksonPresent) {
126+
this.messageCodec = new JacksonJsonSockJsMessageCodec();
127+
}
128+
else if (jackson2Present) {
122129
this.messageCodec = new Jackson2SockJsMessageCodec();
123130
}
124131
}

spring-websocket/src/test/java/org/springframework/web/socket/sockjs/client/ClientSockJsSessionTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
import org.springframework.web.socket.WebSocketExtension;
3030
import org.springframework.web.socket.WebSocketHandler;
3131
import org.springframework.web.socket.WebSocketSession;
32-
import org.springframework.web.socket.sockjs.frame.Jackson2SockJsMessageCodec;
32+
import org.springframework.web.socket.sockjs.frame.JacksonJsonSockJsMessageCodec;
3333
import org.springframework.web.socket.sockjs.frame.SockJsFrame;
3434
import org.springframework.web.socket.sockjs.transport.TransportType;
3535

@@ -48,7 +48,7 @@
4848
*/
4949
class ClientSockJsSessionTests {
5050

51-
private static final Jackson2SockJsMessageCodec CODEC = new Jackson2SockJsMessageCodec();
51+
private static final JacksonJsonSockJsMessageCodec CODEC = new JacksonJsonSockJsMessageCodec();
5252

5353
private WebSocketHandler handler = mock();
5454

spring-websocket/src/test/java/org/springframework/web/socket/sockjs/client/DefaultTransportRequestTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
import org.springframework.http.HttpHeaders;
3131
import org.springframework.scheduling.TaskScheduler;
3232
import org.springframework.web.socket.WebSocketSession;
33-
import org.springframework.web.socket.sockjs.frame.Jackson2SockJsMessageCodec;
33+
import org.springframework.web.socket.sockjs.frame.JacksonJsonSockJsMessageCodec;
3434
import org.springframework.web.socket.sockjs.transport.TransportType;
3535

3636
import static org.assertj.core.api.Assertions.assertThat;
@@ -47,7 +47,7 @@
4747
*/
4848
class DefaultTransportRequestTests {
4949

50-
private final Jackson2SockJsMessageCodec CODEC = new Jackson2SockJsMessageCodec();
50+
private final JacksonJsonSockJsMessageCodec CODEC = new JacksonJsonSockJsMessageCodec();
5151

5252
private CompletableFuture<WebSocketSession> connectFuture = new CompletableFuture<>();
5353

spring-websocket/src/test/java/org/springframework/web/socket/sockjs/client/RestTemplateXhrTransportTests.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
import org.springframework.web.socket.TextMessage;
5151
import org.springframework.web.socket.WebSocketHandler;
5252
import org.springframework.web.socket.WebSocketSession;
53-
import org.springframework.web.socket.sockjs.frame.Jackson2SockJsMessageCodec;
53+
import org.springframework.web.socket.sockjs.frame.JacksonJsonSockJsMessageCodec;
5454
import org.springframework.web.socket.sockjs.frame.SockJsFrame;
5555
import org.springframework.web.socket.sockjs.transport.TransportType;
5656

@@ -69,7 +69,7 @@
6969
*/
7070
class RestTemplateXhrTransportTests {
7171

72-
private static final Jackson2SockJsMessageCodec CODEC = new Jackson2SockJsMessageCodec();
72+
private static final JacksonJsonSockJsMessageCodec CODEC = new JacksonJsonSockJsMessageCodec();
7373

7474
private final WebSocketHandler webSocketHandler = mock();
7575

@@ -114,7 +114,7 @@ void connectReceiveAndCloseWithStompFrame() throws Exception {
114114
Message<byte[]> message = MessageBuilder.createMessage("body".getBytes(UTF_8), headers);
115115
byte[] bytes = new StompEncoder().encode(message);
116116
TextMessage textMessage = new TextMessage(bytes);
117-
SockJsFrame frame = SockJsFrame.messageFrame(new Jackson2SockJsMessageCodec(), textMessage.getPayload());
117+
SockJsFrame frame = SockJsFrame.messageFrame(new JacksonJsonSockJsMessageCodec(), textMessage.getPayload());
118118

119119
String body = """
120120
o

spring-websocket/src/test/java/org/springframework/web/socket/sockjs/frame/SockJsFrameTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ void heartbeatFrame() {
4949

5050
@Test
5151
void messageArrayFrame() {
52-
SockJsFrame frame = SockJsFrame.messageFrame(new Jackson2SockJsMessageCodec(), "m1", "m2");
52+
SockJsFrame frame = SockJsFrame.messageFrame(new JacksonJsonSockJsMessageCodec(), "m1", "m2");
5353

5454
assertThat(frame.getContent()).isEqualTo("a[\"m1\",\"m2\"]");
5555
assertThat(frame.getType()).isEqualTo(SockJsFrameType.MESSAGE);

spring-websocket/src/test/java/org/springframework/web/socket/sockjs/transport/session/StubSockJsServiceConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
import org.springframework.scheduling.TaskScheduler;
2020
import org.springframework.scheduling.concurrent.ThreadPoolTaskScheduler;
21-
import org.springframework.web.socket.sockjs.frame.Jackson2SockJsMessageCodec;
21+
import org.springframework.web.socket.sockjs.frame.JacksonJsonSockJsMessageCodec;
2222
import org.springframework.web.socket.sockjs.frame.SockJsMessageCodec;
2323
import org.springframework.web.socket.sockjs.transport.SockJsServiceConfig;
2424

@@ -33,7 +33,7 @@ public class StubSockJsServiceConfig implements SockJsServiceConfig {
3333

3434
private TaskScheduler taskScheduler = new ThreadPoolTaskScheduler();
3535

36-
private SockJsMessageCodec messageCodec = new Jackson2SockJsMessageCodec();
36+
private SockJsMessageCodec messageCodec = new JacksonJsonSockJsMessageCodec();
3737

3838
private int httpMessageCacheSize = 100;
3939

spring-websocket/src/test/java/org/springframework/web/socket/sockjs/transport/session/WebSocketServerSockJsSessionTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@
1616

1717
package org.springframework.web.socket.sockjs.transport.session;
1818

19-
import java.io.IOException;
2019
import java.util.ArrayList;
2120
import java.util.List;
2221
import java.util.Map;
2322

2423
import org.junit.jupiter.api.BeforeEach;
2524
import org.junit.jupiter.api.Test;
25+
import tools.jackson.core.JacksonException;
2626

2727
import org.springframework.web.socket.CloseStatus;
2828
import org.springframework.web.socket.TextMessage;
@@ -118,7 +118,7 @@ void handleMessageBadData() throws Exception {
118118
this.session.handleMessage(message, this.webSocketSession);
119119

120120
this.session.isClosed();
121-
verify(this.webSocketHandler).handleTransportError(same(this.session), any(IOException.class));
121+
verify(this.webSocketHandler).handleTransportError(same(this.session), any(JacksonException.class));
122122
verifyNoMoreInteractions(this.webSocketHandler);
123123
}
124124

0 commit comments

Comments
 (0)