GH-2064 BeforeConvertCallback should be applied after the RootAggrega… #2065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the RootAggregateChange creation Signed-off-by: mipo256 <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
added
type: bug
|
Thanks a lot for having a look and picking up on maintenance, this is really helpful. |
schauder
pushed a commit
that referenced
this pull request
Jun 11, 2025
Signed-off-by: mipo256 <[email protected]> Commit message edited by Jens Schauder. Original pull request #2065 Closes #2064
|
Thanks for this. I had to apply some changes:
This is merged. |
schauder
pushed a commit
that referenced
this pull request
Jun 11, 2025
Signed-off-by: mipo256 <[email protected]> Commit message edited by Jens Schauder. Original pull request #2065 Closes #2064
schauder
pushed a commit
that referenced
this pull request
Jun 11, 2025
Signed-off-by: mipo256 <[email protected]> Commit message edited by Jens Schauder. Original pull request #2065 Closes #2064
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2064
Hey @mp911de, @schauder.
After giving it a couple of tries, I've come up with this solution. The idea is to separate the
doInBatchandsaveInBatch. The reason is that indoInBatchthere is an implicit assumption, that theFunctionthat accepts the entity to create anAggregateChangewill just create anAggregateChange. But in case ofsaveAll, there were a conditional logic also applied in theFunction(like what change to create,UPDATEorINSERT).So, in case of any suggestions or question, feel free to reach out, thanks!