Skip to content

Commit 3cba5d9

Browse files
committed
Use "= true" for TRUE() and "= false" for FALSE(). (#1633)
Closes #1627.
1 parent 4134eb6 commit 3cba5d9

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/main/java/org/springframework/data/couchbase/core/query/QueryCriteria.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -499,14 +499,14 @@ public QueryCriteria notIn(boolean ignoreCase, @Nullable Object... o) {
499499
public QueryCriteria TRUE() { // true/false are reserved, use TRUE/FALSE
500500
value = null;
501501
operator = null;
502-
format = "%1$s"; // field = 1$, operator = 2$, value=$3, $4, ...
502+
format = "%1$s = true"; // field = 1$, operator = 2$, value=$3, $4, ...
503503
return this;
504504
}
505505

506506
public QueryCriteria FALSE() {
507507
value = null;
508-
operator = "NOT";
509-
format = "not(%1$s)"; // field = 1$, operator = 2$, value=$3, $4, ...
508+
operator = null;
509+
format = "%1$s = false"; // field = 1$, operator = 2$, value=$3, $4, ...
510510
return this;
511511
}
512512

src/test/java/org/springframework/data/couchbase/core/query/QueryCriteriaTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -261,13 +261,13 @@ void testNotIn() {
261261
@Test
262262
void testTrue() {
263263
QueryCriteria c = where(i("name")).TRUE();
264-
assertEquals("`name`", c.export());
264+
assertEquals("`name` = true", c.export());
265265
}
266266

267267
@Test
268268
void testFalse() {
269269
QueryCriteria c = where(i("name")).FALSE();
270-
assertEquals("not(`name`)", c.export());
270+
assertEquals("`name` = false", c.export());
271271
}
272272

273273
@Test

0 commit comments

Comments
 (0)