Skip to content

management.metrics.tags has been deprecated without a replacement working for all metrics #38583

Closed
@mhalbritter

Description

@mhalbritter

In 3.2.0, we deprecated management.metrics.tags (MetricsProperties#getTags). The replacement for this is management.observations.key-values, but this property is only applied to metrics created through Observations. If creating metrics in a different way, management.observations.key-values is not applied to these metrics.

I currently see these ways forward:

  • Un-deprecate management.metrics.tags - then we whould have two places to set common tags for metrics, depending how they get created, which is not great.
  • Apply management.observations.key-values to metrics created without a Observation, too - then we would only have one way to set common tags for metrics, which is great. But the observations part implies that it should only apply to Observations. Or is a metric an Observation, too?
  • Create a new property, e.g. management.observability.common-tags which applies to all observability things (Observation, metrics, traces). Then we have to deprecate the new management.observations.key-values and redirect users to management.observability.common-tags.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions