Skip to content

Commit e930a96

Browse files
committed
Polish "Add option for configuring max messages per task"
See gh-42341
1 parent 09b57ef commit e930a96

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jms/JmsProperties.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,9 @@ public static class Listener {
187187
private Duration receiveTimeout = Duration.ofSeconds(1);
188188

189189
/**
190-
* Specify the maximum number of messages to process in one task.
190+
* Specify the maximum number of messages to process in one task. By default,
191+
* unlimited unless a SchedulingTaskExecutor is configured on the listener (10
192+
* messages), as it indicates a preference for short-lived tasks.
191193
*/
192194
private Integer maxMessagesPerTask;
193195

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jms/JmsAutoConfigurationTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ void testJmsListenerContainerFactoryWithCustomSettings() {
177177
"spring.jms.listener.session.transacted=false", "spring.jms.listener.minConcurrency=2",
178178
"spring.jms.listener.receiveTimeout=2s", "spring.jms.listener.maxConcurrency=10",
179179
"spring.jms.subscription-durable=true", "spring.jms.client-id=exampleId",
180-
"spring.jms.listener.max-messages-per-task=10")
180+
"spring.jms.listener.max-messages-per-task=5")
181181
.run(this::testJmsListenerContainerFactoryWithCustomSettings);
182182
}
183183

@@ -189,7 +189,7 @@ private void testJmsListenerContainerFactoryWithCustomSettings(AssertableApplica
189189
assertThat(container.getConcurrentConsumers()).isEqualTo(2);
190190
assertThat(container.getMaxConcurrentConsumers()).isEqualTo(10);
191191
assertThat(container).hasFieldOrPropertyWithValue("receiveTimeout", 2000L);
192-
assertThat(container).hasFieldOrPropertyWithValue("maxMessagesPerTask", 10);
192+
assertThat(container).hasFieldOrPropertyWithValue("maxMessagesPerTask", 5);
193193
assertThat(container.isSubscriptionDurable()).isTrue();
194194
assertThat(container.getClientId()).isEqualTo("exampleId");
195195
}

0 commit comments

Comments
 (0)