Skip to content

Commit e2b15c3

Browse files
committed
Fix tests
See gh-15039
1 parent de128fe commit e2b15c3

File tree

2 files changed

+29
-1
lines changed

2 files changed

+29
-1
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/integrationtest/JmxEndpointIntegrationTests.java

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,12 @@
3030
import org.springframework.boot.actuate.autoconfigure.endpoint.jmx.JmxEndpointAutoConfiguration;
3131
import org.springframework.boot.actuate.autoconfigure.health.HealthIndicatorAutoConfiguration;
3232
import org.springframework.boot.actuate.autoconfigure.trace.http.HttpTraceAutoConfiguration;
33+
import org.springframework.boot.actuate.trace.http.InMemoryHttpTraceRepository;
3334
import org.springframework.boot.autoconfigure.AutoConfigurations;
3435
import org.springframework.boot.autoconfigure.jmx.JmxAutoConfiguration;
3536
import org.springframework.boot.test.context.runner.WebApplicationContextRunner;
37+
import org.springframework.context.annotation.Bean;
38+
import org.springframework.context.annotation.Configuration;
3639
import org.springframework.util.StringUtils;
3740

3841
import static org.assertj.core.api.Assertions.assertThat;
@@ -50,6 +53,7 @@ public class JmxEndpointIntegrationTests {
5053
EndpointAutoConfiguration.class, JmxEndpointAutoConfiguration.class,
5154
HealthIndicatorAutoConfiguration.class,
5255
HttpTraceAutoConfiguration.class))
56+
.withUserConfiguration(HttpTraceRepositoryConfiguration.class)
5357
.withPropertyValues("spring.jmx.enabled=true").withConfiguration(
5458
AutoConfigurations.of(EndpointAutoConfigurationClasses.ALL));
5559

@@ -138,4 +142,14 @@ private ObjectName getObjectName(String domain, String endpointId) {
138142

139143
}
140144

145+
@Configuration(proxyBeanMethods = false)
146+
public static class HttpTraceRepositoryConfiguration {
147+
148+
@Bean
149+
public InMemoryHttpTraceRepository httpTraceRepository() {
150+
return new InMemoryHttpTraceRepository();
151+
}
152+
153+
}
154+
141155
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/integrationtest/WebMvcEndpointExposureIntegrationTests.java

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
import org.springframework.boot.actuate.endpoint.web.EndpointServlet;
3636
import org.springframework.boot.actuate.endpoint.web.annotation.RestControllerEndpoint;
3737
import org.springframework.boot.actuate.endpoint.web.annotation.ServletEndpoint;
38+
import org.springframework.boot.actuate.trace.http.InMemoryHttpTraceRepository;
3839
import org.springframework.boot.autoconfigure.AutoConfigurations;
3940
import org.springframework.boot.autoconfigure.http.HttpMessageConvertersAutoConfiguration;
4041
import org.springframework.boot.autoconfigure.jackson.JacksonAutoConfiguration;
@@ -45,6 +46,8 @@
4546
import org.springframework.boot.test.context.runner.WebApplicationContextRunner;
4647
import org.springframework.boot.web.servlet.context.AnnotationConfigServletWebServerApplicationContext;
4748
import org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext;
49+
import org.springframework.context.annotation.Bean;
50+
import org.springframework.context.annotation.Configuration;
4851
import org.springframework.http.HttpMethod;
4952
import org.springframework.http.HttpStatus;
5053
import org.springframework.test.web.reactive.server.EntityExchangeResult;
@@ -79,7 +82,8 @@ public class WebMvcEndpointExposureIntegrationTests {
7982
.withConfiguration(
8083
AutoConfigurations.of(EndpointAutoConfigurationClasses.ALL))
8184
.withUserConfiguration(CustomMvcEndpoint.class,
82-
CustomServletEndpoint.class)
85+
CustomServletEndpoint.class,
86+
HttpTraceRepositoryConfiguration.class)
8387
.withPropertyValues("server.port:0");
8488

8589
@Test
@@ -215,4 +219,14 @@ protected void doGet(HttpServletRequest req, HttpServletResponse resp)
215219

216220
}
217221

222+
@Configuration(proxyBeanMethods = false)
223+
public static class HttpTraceRepositoryConfiguration {
224+
225+
@Bean
226+
public InMemoryHttpTraceRepository httpTraceRepository() {
227+
return new InMemoryHttpTraceRepository();
228+
}
229+
230+
}
231+
218232
}

0 commit comments

Comments
 (0)