Skip to content

Commit bd223e8

Browse files
choi-hyeseongphilwebb
authored andcommitted
Remove duplicated file.getName() call
Update `WebServerPortFileWriter` so that `file.getName()` is only called once. See gh-42411
1 parent 21b0bde commit bd223e8

File tree

1 file changed

+11
-12
lines changed

1 file changed

+11
-12
lines changed

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/context/WebServerPortFileWriter.java

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -109,18 +109,17 @@ protected File getPortFile(ApplicationContext applicationContext) {
109109
return this.file;
110110
}
111111
String name = this.file.getName();
112-
String extension = StringUtils.getFilenameExtension(this.file.getName());
113-
name = name.substring(0, name.length() - extension.length() - 1);
114-
if (isUpperCase(name)) {
115-
name = name + "-" + namespace.toUpperCase(Locale.ENGLISH);
116-
}
117-
else {
118-
name = name + "-" + namespace.toLowerCase(Locale.ENGLISH);
119-
}
120-
if (StringUtils.hasLength(extension)) {
121-
name = name + "." + extension;
122-
}
123-
return new File(this.file.getParentFile(), name);
112+
String extension = StringUtils.getFilenameExtension(name);
113+
114+
StringBuilder builder = new StringBuilder(name);
115+
116+
String suffix = "-" + (isUpperCase(name) ? namespace.toUpperCase(Locale.ENGLISH) : namespace.toLowerCase(Locale.ENGLISH));
117+
if (StringUtils.hasLength(extension))
118+
builder.insert(name.lastIndexOf(extension) - 1, suffix);
119+
else
120+
builder.append(suffix);
121+
122+
return new File(this.file.getParentFile(), builder.toString());
124123
}
125124

126125
private String getServerNamespace(ApplicationContext applicationContext) {

0 commit comments

Comments
 (0)