Merge pull request #41053 from PiyalAhmed

* pr/41053:
  Polish "Use constructor rather than Collection.addAll"
  Use constructor rather than Collection.addAll

Closes gh-41053

Author: philwebb

buildSrc/src/main/java/org/springframework/boot/build/toolchain/ToolchainPlugin.java

@@ -71,8 +71,7 @@ private void disableToolchainTasks(Project project) {
 	}
 
 	private void configureTestToolchain(Project project, ToolchainExtension toolchain) {
-		List<String> jvmArgs = new ArrayList<>();
-		jvmArgs.addAll(toolchain.getTestJvmArgs().getOrElse(Collections.emptyList()));
+		List<String> jvmArgs = new ArrayList<>(toolchain.getTestJvmArgs().getOrElse(Collections.emptyList()));
 		project.getTasks().withType(Test.class, (test) -> test.jvmArgs(jvmArgs));
 	}
 

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/flyway/NativeImageResourceProvider.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2023 the original author or authors.
+ * Copyright 2012-2024 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -96,8 +96,7 @@ public Collection<LoadableResource> getResources(String prefix, String[] suffixe
 		ensureInitialized();
 		Predicate<LocatedResource> matchesPrefixAndSuffixes = (locatedResource) -> StringUtils
 			.startsAndEndsWith(locatedResource.resource.getFilename(), prefix, suffixes);
-		List<LoadableResource> result = new ArrayList<>();
-		result.addAll(this.scanner.getResources(prefix, suffixes));
+		List<LoadableResource> result = new ArrayList<>(this.scanner.getResources(prefix, suffixes));
 		this.locatedResources.stream()
 			.filter(matchesPrefixAndSuffixes)
 			.map(this::asClassPathResource)

spring-boot-project/spring-boot-test/src/main/java/org/springframework/boot/test/context/ImportsContextCustomizer.java

@@ -240,8 +240,7 @@ static class ContextCustomizerKey {
 				this.key = Collections.unmodifiableSet(synthesize(annotations));
 			}
 			else {
-				Set<Object> key = new HashSet<>();
-				key.addAll(determinedImports);
+				Set<Object> key = new HashSet<>(determinedImports);
 				Set<Annotation> componentScanning = annotations.stream()
 					.filter((annotation) -> annotation.getType().equals(ComponentScan.class))
 					.map(MergedAnnotation::synthesize)

spring-boot-project/spring-boot-testcontainers/src/main/java/org/springframework/boot/testcontainers/service/connection/ServiceConnectionAutoConfigurationRegistrar.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2023 the original author or authors.
+ * Copyright 2012-2024 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -68,8 +68,8 @@ private void registerBeanDefinitions(ConfigurableListableBeanFactory beanFactory
 
 	private Set<ServiceConnection> getAnnotations(ConfigurableListableBeanFactory beanFactory, String beanName,
 			BeanDefinition beanDefinition) {
-		Set<ServiceConnection> annotations = new LinkedHashSet<>();
-		annotations.addAll(beanFactory.findAllAnnotationsOnBean(beanName, ServiceConnection.class, false));
+		Set<ServiceConnection> annotations = new LinkedHashSet<>(
+				beanFactory.findAllAnnotationsOnBean(beanName, ServiceConnection.class, false));
 		if (beanDefinition instanceof TestcontainerBeanDefinition testcontainerBeanDefinition) {
 			testcontainerBeanDefinition.getAnnotations()
 				.stream(ServiceConnection.class)

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/context/config/ConfigData.java

@@ -239,8 +239,7 @@ public Options with(Option option) {
 		}
 
 		private Options copy(Consumer<EnumSet<Option>> processor) {
-			EnumSet<Option> options = EnumSet.noneOf(Option.class);
-			options.addAll(this.options);
+			EnumSet<Option> options = EnumSet.copyOf(this.options);
 			processor.accept(options);
 			return new Options(options);
 		}

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/tomcat/TldPatterns.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2023 the original author or authors.
+ * Copyright 2012-2024 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -195,8 +195,7 @@ final class TldPatterns {
 	static final Set<String> DEFAULT_SCAN;
 
 	static {
-		Set<String> scanPatterns = new LinkedHashSet<>();
-		scanPatterns.addAll(TOMCAT_SCAN);
+		Set<String> scanPatterns = new LinkedHashSet<>(TOMCAT_SCAN);
 		DEFAULT_SCAN = Collections.unmodifiableSet(scanPatterns);
 	}
 

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/tomcat/TomcatEmbeddedContext.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2022 the original author or authors.
+ * Copyright 2012-2024 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -128,8 +128,7 @@ void setMimeMappings(MimeMappings mimeMappings) {
 
 	@Override
 	public String[] findMimeMappings() {
-		List<String> mappings = new ArrayList<>();
-		mappings.addAll(Arrays.asList(super.findMimeMappings()));
+		List<String> mappings = new ArrayList<>(Arrays.asList(super.findMimeMappings()));
 		if (this.mimeMappings != null) {
 			this.mimeMappings.forEach((mapping) -> mappings.add(mapping.getExtension()));
 		}