Skip to content

Commit 96ce07c

Browse files
committed
Harmonize naming of Elasticsearch auto-configuration classes
1 parent c4b0bd1 commit 96ce07c

File tree

13 files changed

+36
-35
lines changed

13 files changed

+36
-35
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/elasticsearch/ElasticSearchRestHealthContributorAutoConfiguration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
3030
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
3131
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
32-
import org.springframework.boot.autoconfigure.elasticsearch.rest.RestClientAutoConfiguration;
32+
import org.springframework.boot.autoconfigure.elasticsearch.rest.ElasticsearchRestClientAutoConfiguration;
3333
import org.springframework.context.annotation.Bean;
3434
import org.springframework.context.annotation.Configuration;
3535

@@ -44,7 +44,7 @@
4444
@ConditionalOnClass(RestClient.class)
4545
@ConditionalOnBean(RestClient.class)
4646
@ConditionalOnEnabledHealthIndicator("elasticsearch")
47-
@AutoConfigureAfter(RestClientAutoConfiguration.class)
47+
@AutoConfigureAfter(ElasticsearchRestClientAutoConfiguration.class)
4848
@SuppressWarnings("deprecation")
4949
public class ElasticSearchRestHealthContributorAutoConfiguration
5050
extends CompositeHealthContributorConfiguration<ElasticsearchRestHealthIndicator, RestClient> {

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/data/elasticsearch/ElasticsearchDataAutoConfiguration.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import org.springframework.boot.autoconfigure.AutoConfigureAfter;
2020
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
2121
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
22-
import org.springframework.boot.autoconfigure.elasticsearch.rest.RestClientAutoConfiguration;
22+
import org.springframework.boot.autoconfigure.elasticsearch.rest.ElasticsearchRestClientAutoConfiguration;
2323
import org.springframework.context.annotation.Configuration;
2424
import org.springframework.context.annotation.Import;
2525
import org.springframework.data.elasticsearch.core.ElasticsearchTemplate;
@@ -39,7 +39,8 @@
3939
*/
4040
@Configuration(proxyBeanMethods = false)
4141
@ConditionalOnClass({ ElasticsearchTemplate.class })
42-
@AutoConfigureAfter({ RestClientAutoConfiguration.class, ReactiveRestClientAutoConfiguration.class })
42+
@AutoConfigureAfter({ ElasticsearchRestClientAutoConfiguration.class,
43+
ReactiveElasticsearchRestClientAutoConfiguration.class })
4344
@Import({ ElasticsearchDataConfiguration.BaseConfiguration.class,
4445
ElasticsearchDataConfiguration.RestClientConfiguration.class,
4546
ElasticsearchDataConfiguration.ReactiveRestClientConfiguration.class })
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,12 @@
4242
*/
4343
@Configuration(proxyBeanMethods = false)
4444
@ConditionalOnClass({ ReactiveRestClients.class, WebClient.class, HttpClient.class })
45-
@EnableConfigurationProperties(ReactiveRestClientProperties.class)
46-
public class ReactiveRestClientAutoConfiguration {
45+
@EnableConfigurationProperties(ReactiveElasticsearchRestClientProperties.class)
46+
public class ReactiveElasticsearchRestClientAutoConfiguration {
4747

4848
@Bean
4949
@ConditionalOnMissingBean
50-
public ClientConfiguration clientConfiguration(ReactiveRestClientProperties properties) {
50+
public ClientConfiguration clientConfiguration(ReactiveElasticsearchRestClientProperties properties) {
5151
ClientConfiguration.MaybeSecureClientConfigurationBuilder builder = ClientConfiguration.builder()
5252
.connectedTo(properties.getEndpoints().toArray(new String[0]));
5353
if (properties.isUseSsl()) {
@@ -59,7 +59,7 @@ public ClientConfiguration clientConfiguration(ReactiveRestClientProperties prop
5959
}
6060

6161
private void configureTimeouts(ClientConfiguration.TerminalClientConfigurationBuilder builder,
62-
ReactiveRestClientProperties properties) {
62+
ReactiveElasticsearchRestClientProperties properties) {
6363
PropertyMapper map = PropertyMapper.get();
6464
map.from(properties.getConnectionTimeout()).whenNonNull().to(builder::withConnectTimeout);
6565
map.from(properties.getSocketTimeout()).whenNonNull().to(builder::withSocketTimeout);
@@ -71,7 +71,7 @@ private void configureTimeouts(ClientConfiguration.TerminalClientConfigurationBu
7171
}
7272

7373
private void configureExchangeStrategies(ClientConfiguration.TerminalClientConfigurationBuilder builder,
74-
ReactiveRestClientProperties properties) {
74+
ReactiveElasticsearchRestClientProperties properties) {
7575
PropertyMapper map = PropertyMapper.get();
7676
builder.withWebClientConfigurer((webClient) -> {
7777
ExchangeStrategies exchangeStrategies = ExchangeStrategies.builder()
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
* @since 2.2.0
3232
*/
3333
@ConfigurationProperties(prefix = "spring.data.elasticsearch.client.reactive")
34-
public class ReactiveRestClientProperties {
34+
public class ReactiveElasticsearchRestClientProperties {
3535

3636
/**
3737
* Comma-separated list of the Elasticsearch endpoints to connect to.
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2019 the original author or authors.
2+
* Copyright 2012-2020 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -33,10 +33,10 @@
3333
*/
3434
@Configuration(proxyBeanMethods = false)
3535
@ConditionalOnClass(RestClient.class)
36-
@EnableConfigurationProperties(RestClientProperties.class)
37-
@Import({ RestClientConfigurations.RestClientBuilderConfiguration.class,
38-
RestClientConfigurations.RestHighLevelClientConfiguration.class,
39-
RestClientConfigurations.RestClientFallbackConfiguration.class })
40-
public class RestClientAutoConfiguration {
36+
@EnableConfigurationProperties(ElasticsearchRestClientProperties.class)
37+
@Import({ ElasticsearchRestClientConfigurations.RestClientBuilderConfiguration.class,
38+
ElasticsearchRestClientConfigurations.RestHighLevelClientConfiguration.class,
39+
ElasticsearchRestClientConfigurations.RestClientFallbackConfiguration.class })
40+
public class ElasticsearchRestClientAutoConfiguration {
4141

4242
}
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2019 the original author or authors.
2+
* Copyright 2012-2020 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -41,14 +41,14 @@
4141
* @author Brian Clozel
4242
* @author Stephane Nicoll
4343
*/
44-
class RestClientConfigurations {
44+
class ElasticsearchRestClientConfigurations {
4545

4646
@Configuration(proxyBeanMethods = false)
4747
static class RestClientBuilderConfiguration {
4848

4949
@Bean
5050
@ConditionalOnMissingBean
51-
RestClientBuilder elasticsearchRestClientBuilder(RestClientProperties properties,
51+
RestClientBuilder elasticsearchRestClientBuilder(ElasticsearchRestClientProperties properties,
5252
ObjectProvider<RestClientBuilderCustomizer> builderCustomizers) {
5353
HttpHost[] hosts = properties.getUris().stream().map(HttpHost::create).toArray(HttpHost[]::new);
5454
RestClientBuilder builder = RestClient.builder(hosts);
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2019 the original author or authors.
2+
* Copyright 2012-2020 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -30,7 +30,7 @@
3030
* @since 2.1.0
3131
*/
3232
@ConfigurationProperties(prefix = "spring.elasticsearch.rest")
33-
public class RestClientProperties {
33+
public class ElasticsearchRestClientProperties {
3434

3535
/**
3636
* Comma-separated list of the Elasticsearch instances to use.

spring-boot-project/spring-boot-autoconfigure/src/main/resources/META-INF/spring.factories

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ org.springframework.boot.autoconfigure.data.couchbase.CouchbaseRepositoriesAutoC
4141
org.springframework.boot.autoconfigure.data.elasticsearch.ElasticsearchDataAutoConfiguration,\
4242
org.springframework.boot.autoconfigure.data.elasticsearch.ElasticsearchRepositoriesAutoConfiguration,\
4343
org.springframework.boot.autoconfigure.data.elasticsearch.ReactiveElasticsearchRepositoriesAutoConfiguration,\
44-
org.springframework.boot.autoconfigure.data.elasticsearch.ReactiveRestClientAutoConfiguration,\
44+
org.springframework.boot.autoconfigure.data.elasticsearch.ReactiveElasticsearchRestClientAutoConfiguration,\
4545
org.springframework.boot.autoconfigure.data.jdbc.JdbcRepositoriesAutoConfiguration,\
4646
org.springframework.boot.autoconfigure.data.jpa.JpaRepositoriesAutoConfiguration,\
4747
org.springframework.boot.autoconfigure.data.ldap.LdapRepositoriesAutoConfiguration,\
@@ -60,7 +60,7 @@ org.springframework.boot.autoconfigure.data.redis.RedisReactiveAutoConfiguration
6060
org.springframework.boot.autoconfigure.data.redis.RedisRepositoriesAutoConfiguration,\
6161
org.springframework.boot.autoconfigure.data.rest.RepositoryRestMvcAutoConfiguration,\
6262
org.springframework.boot.autoconfigure.data.web.SpringDataWebAutoConfiguration,\
63-
org.springframework.boot.autoconfigure.elasticsearch.rest.RestClientAutoConfiguration,\
63+
org.springframework.boot.autoconfigure.elasticsearch.rest.ElasticsearchRestClientAutoConfiguration,\
6464
org.springframework.boot.autoconfigure.flyway.FlywayAutoConfiguration,\
6565
org.springframework.boot.autoconfigure.freemarker.FreeMarkerAutoConfiguration,\
6666
org.springframework.boot.autoconfigure.groovy.template.GroovyTemplateAutoConfiguration,\

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/data/elasticsearch/ElasticsearchDataAutoConfigurationTests.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import org.junit.jupiter.api.Test;
2222

2323
import org.springframework.boot.autoconfigure.AutoConfigurations;
24-
import org.springframework.boot.autoconfigure.elasticsearch.rest.RestClientAutoConfiguration;
24+
import org.springframework.boot.autoconfigure.elasticsearch.rest.ElasticsearchRestClientAutoConfiguration;
2525
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
2626
import org.springframework.context.annotation.Bean;
2727
import org.springframework.context.annotation.Configuration;
@@ -44,8 +44,8 @@
4444
class ElasticsearchDataAutoConfigurationTests {
4545

4646
private ApplicationContextRunner contextRunner = new ApplicationContextRunner()
47-
.withConfiguration(AutoConfigurations.of(RestClientAutoConfiguration.class,
48-
ReactiveRestClientAutoConfiguration.class, ElasticsearchDataAutoConfiguration.class));
47+
.withConfiguration(AutoConfigurations.of(ElasticsearchRestClientAutoConfiguration.class,
48+
ReactiveElasticsearchRestClientAutoConfiguration.class, ElasticsearchDataAutoConfiguration.class));
4949

5050
@BeforeEach
5151
void setUp() {

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/data/elasticsearch/ElasticsearchRepositoriesAutoConfigurationTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
import org.springframework.boot.autoconfigure.data.elasticsearch.city.City;
3030
import org.springframework.boot.autoconfigure.data.elasticsearch.city.CityRepository;
3131
import org.springframework.boot.autoconfigure.data.empty.EmptyDataPackage;
32-
import org.springframework.boot.autoconfigure.elasticsearch.rest.RestClientAutoConfiguration;
32+
import org.springframework.boot.autoconfigure.elasticsearch.rest.ElasticsearchRestClientAutoConfiguration;
3333
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
3434
import org.springframework.context.annotation.Configuration;
3535
import org.springframework.data.elasticsearch.core.ElasticsearchRestTemplate;
@@ -52,7 +52,7 @@ class ElasticsearchRepositoriesAutoConfigurationTests {
5252
.withStartupAttempts(5).withStartupTimeout(Duration.ofMinutes(10));
5353

5454
private ApplicationContextRunner contextRunner = new ApplicationContextRunner()
55-
.withConfiguration(AutoConfigurations.of(RestClientAutoConfiguration.class,
55+
.withConfiguration(AutoConfigurations.of(ElasticsearchRestClientAutoConfiguration.class,
5656
ElasticsearchRepositoriesAutoConfiguration.class, ElasticsearchDataAutoConfiguration.class))
5757
.withPropertyValues("spring.elasticsearch.rest.uris=" + elasticsearch.getHttpHostAddress());
5858

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/data/elasticsearch/ReactiveElasticsearchRepositoriesAutoConfigurationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public class ReactiveElasticsearchRepositoriesAutoConfigurationTests {
5151
.withStartupTimeout(Duration.ofMinutes(10));
5252

5353
private ApplicationContextRunner contextRunner = new ApplicationContextRunner()
54-
.withConfiguration(AutoConfigurations.of(ReactiveRestClientAutoConfiguration.class,
54+
.withConfiguration(AutoConfigurations.of(ReactiveElasticsearchRestClientAutoConfiguration.class,
5555
ReactiveElasticsearchRepositoriesAutoConfiguration.class, ElasticsearchDataAutoConfiguration.class))
5656
.withPropertyValues("spring.data.elasticsearch.client.reactive.endpoints="
5757
+ elasticsearch.getContainerIpAddress() + ":" + elasticsearch.getFirstMappedPort());
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,19 +39,19 @@
3939
import static org.mockito.Mockito.mock;
4040

4141
/**
42-
* Tests for {@link ReactiveRestClientAutoConfiguration}
42+
* Tests for {@link ReactiveElasticsearchRestClientAutoConfiguration}.
4343
*
4444
* @author Brian Clozel
4545
*/
4646
@Testcontainers(disabledWithoutDocker = true)
47-
public class ReactiveRestClientAutoConfigurationTests {
47+
public class ReactiveElasticsearchRestClientAutoConfigurationTests {
4848

4949
@Container
5050
static ElasticsearchContainer elasticsearch = new VersionOverridingElasticsearchContainer().withStartupAttempts(5)
5151
.withStartupTimeout(Duration.ofMinutes(10));
5252

5353
private ApplicationContextRunner contextRunner = new ApplicationContextRunner()
54-
.withConfiguration(AutoConfigurations.of(ReactiveRestClientAutoConfiguration.class));
54+
.withConfiguration(AutoConfigurations.of(ReactiveElasticsearchRestClientAutoConfiguration.class));
5555

5656
@Test
5757
void configureShouldCreateDefaultBeans() {
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,19 +42,19 @@
4242
import static org.mockito.Mockito.mock;
4343

4444
/**
45-
* Tests for {@link RestClientAutoConfiguration}
45+
* Tests for {@link ElasticsearchRestClientAutoConfiguration}.
4646
*
4747
* @author Brian Clozel
4848
*/
4949
@Testcontainers(disabledWithoutDocker = true)
50-
class RestClientAutoConfigurationTests {
50+
class ElasticsearchRestClientAutoConfigurationTests {
5151

5252
@Container
5353
static final ElasticsearchContainer elasticsearch = new ElasticsearchContainer().withStartupAttempts(5)
5454
.withStartupTimeout(Duration.ofMinutes(10));
5555

5656
private ApplicationContextRunner contextRunner = new ApplicationContextRunner()
57-
.withConfiguration(AutoConfigurations.of(RestClientAutoConfiguration.class));
57+
.withConfiguration(AutoConfigurations.of(ElasticsearchRestClientAutoConfiguration.class));
5858

5959
@Test
6060
void configureShouldCreateBothRestClientVariants() {

0 commit comments

Comments
 (0)