Skip to content

Commit 568d716

Browse files
author
Dave Syer
committed
Move OAuth2ClientContextFilter back before the main security filter
It sometimes has to catch an exception from the security filter so it needs to be before, and somehow this hasn't been a problem up to now, but probably only by some fluke. Fixes gh-5792
1 parent b9db474 commit 568d716

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/security/oauth2/client/OAuth2RestOperationsConfiguration.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import org.springframework.boot.autoconfigure.condition.ConditionalOnNotWebApplication;
2727
import org.springframework.boot.autoconfigure.condition.ConditionalOnWebApplication;
2828
import org.springframework.boot.autoconfigure.condition.SpringBootCondition;
29+
import org.springframework.boot.autoconfigure.security.SecurityProperties;
2930
import org.springframework.boot.autoconfigure.security.oauth2.client.OAuth2RestOperationsConfiguration.OAuth2ClientIdCondition;
3031
import org.springframework.boot.bind.RelaxedPropertyResolver;
3132
import org.springframework.boot.context.embedded.FilterRegistrationBean;
@@ -116,10 +117,10 @@ protected static class SessionScopedConfiguration extends BaseConfiguration {
116117

117118
@Bean
118119
public FilterRegistrationBean oauth2ClientFilterRegistration(
119-
OAuth2ClientContextFilter filter) {
120+
OAuth2ClientContextFilter filter, SecurityProperties security) {
120121
FilterRegistrationBean registration = new FilterRegistrationBean();
121122
registration.setFilter(filter);
122-
registration.setOrder(-100);
123+
registration.setOrder(security.getFilterOrder() - 10);
123124
return registration;
124125
}
125126

0 commit comments

Comments
 (0)