Polish "Align Kafka's missingTopicsFatal default value"

See gh-20917

Author: snicoll

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/kafka/KafkaProperties.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2019 the original author or authors.
+ * Copyright 2012-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -53,7 +53,6 @@
  * @author Stephane Nicoll
  * @author Artem Bilan
  * @author Nakul Mishra
- * @author Dhiren Mathur
  * @since 1.5.0
  */
 @ConfigurationProperties(prefix = "spring.kafka")

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/kafka/KafkaAutoConfigurationTests.java

@@ -38,7 +38,6 @@
 import org.junit.jupiter.api.Test;
 
 import org.springframework.boot.autoconfigure.AutoConfigurations;
-import org.springframework.boot.autoconfigure.kafka.KafkaProperties.Listener;
 import org.springframework.boot.test.context.runner.ApplicationContextRunner;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
@@ -86,7 +85,6 @@
  * @author Stephane Nicoll
  * @author Eddú Meléndez
  * @author Nakul Mishra
- * @author Dhiren Mathur
  */
 class KafkaAutoConfigurationTests {
 
@@ -404,17 +402,6 @@ void listenerProperties() {
 				});
 	}
 
-	@Test
-	void listenerPropertiesMatchDefaults() {
-		this.contextRunner.run((context) -> {
-			Listener listenerProperties = new KafkaProperties().getListener();
-			AbstractKafkaListenerContainerFactory<?, ?, ?> kafkaListenerContainerFactory = (AbstractKafkaListenerContainerFactory<?, ?, ?>) context
-					.getBean(KafkaListenerContainerFactory.class);
-			ContainerProperties containerProperties = kafkaListenerContainerFactory.getContainerProperties();
-			assertThat(containerProperties.isMissingTopicsFatal()).isEqualTo(listenerProperties.isMissingTopicsFatal());
-		});
-	}
-
 	@Test
 	void testKafkaTemplateRecordMessageConverters() {
 		this.contextRunner.withUserConfiguration(MessageConverterConfiguration.class)
@@ -581,17 +568,6 @@ void testConcurrentKafkaListenerContainerFactoryWithCustomConsumerFactory() {
 		});
 	}
 
-	@Test
-	void testConcurrentKafkaListenerContainerFactoryMatchesDefaults() {
-		Listener listenerProperties = new KafkaProperties().getListener();
-		this.contextRunner.withUserConfiguration(ConsumerFactoryConfiguration.class).run((context) -> {
-			ConcurrentKafkaListenerContainerFactory<?, ?> kafkaListenerContainerFactory = context
-					.getBean(ConcurrentKafkaListenerContainerFactory.class);
-			assertThat(kafkaListenerContainerFactory.getContainerProperties().isMissingTopicsFatal())
-					.isEqualTo(listenerProperties.isMissingTopicsFatal());
-		});
-	}
-
 	@Configuration(proxyBeanMethods = false)
 	static class MessageConverterConfiguration {
 

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/kafka/KafkaPropertiesTests.java

@@ -0,0 +1,41 @@
+/*
+ * Copyright 2012-2020 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.springframework.boot.autoconfigure.kafka;
+
+import org.apache.kafka.clients.producer.KafkaProducer;
+import org.junit.jupiter.api.Test;
+
+import org.springframework.boot.autoconfigure.kafka.KafkaProperties.Listener;
+import org.springframework.kafka.listener.ContainerProperties;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+/**
+ * Tests for {@link KafkaProducer}.
+ *
+ * @author Stephane Nicoll
+ */
+class KafkaPropertiesTests {
+
+	@Test
+	void listenerDefaultValuesAreConsistent() {
+		ContainerProperties container = new ContainerProperties("test");
+		Listener listenerProperties = new KafkaProperties().getListener();
+		assertThat(listenerProperties.isMissingTopicsFatal()).isEqualTo(container.isMissingTopicsFatal());
+	}
+
+}