Skip to content

feign.httpclient.disable-ssl-validation = true doesn't disable ssl validation for HttpClient #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexisgayte opened this issue May 21, 2025 · 0 comments

Comments

@alexisgayte
Copy link

alexisgayte commented May 21, 2025

You can further customise http clients by setting values in the spring.cloud.openfeign.httpclient.xxx properties.

feign.httpclient.disable-ssl-validation should apply to all clients.

Interestingly, this parameter doesn't seem to apply to http2Client configuration. Or I did miss something.
Same for the default client if no client is specified.

Here the configuration:
https://github.com/spring-cloud/spring-cloud-openfeign/blob/main/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/clientconfig/Http2ClientFeignConfiguration.java#L39-L53

https://github.com/search?q=repo%3Aspring-cloud%2Fspring-cloud-openfeign%20isDisableSslValidation&type=code

isDisableSslValidation applies to hc5 and okhttp3 but not http2Client nor default client (jdk httpClient from feign).

@alexisgayte alexisgayte changed the title feign.httpclient.disable-ssl-validation = false doesn't disable ssl validation for HttpClient feign.httpclient.disable-ssl-validation = true doesn't disable ssl validation for HttpClient May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants