Skip to content

Commit c03f78a

Browse files
committed
Improve url validation. Fixes gh-873.
1 parent d8bb856 commit c03f78a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignClientFactoryBean.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ <T> T getTarget() {
417417
if (LOG.isInfoEnabled()) {
418418
LOG.info("For '" + name + "' URL not provided. Will try picking an instance via load-balancing.");
419419
}
420-
if (!name.startsWith("http")) {
420+
if (!name.startsWith("http://") && !name.startsWith("https://")) {
421421
url = "http://" + name;
422422
}
423423
else {
@@ -426,7 +426,7 @@ <T> T getTarget() {
426426
url += cleanPath();
427427
return (T) loadBalance(builder, context, new HardCodedTarget<>(type, name, url));
428428
}
429-
if (StringUtils.hasText(url) && !url.startsWith("http")) {
429+
if (StringUtils.hasText(url) && !url.startsWith("http://") && !url.startsWith("https://")) {
430430
url = "http://" + url;
431431
}
432432
String url = this.url + cleanPath();

0 commit comments

Comments
 (0)