You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Signing the contributor's agreement does not grant anyone commit rights to the main
44
-
repository, but it does mean that we can accept your contributions, and you will get an
45
-
author credit if we do. Active contributors might be asked to join the core team, and
46
-
given the ability to merge pull requests.
47
-
48
-
[[code-of-conduct]]
49
-
== Code of Conduct
50
-
This project adheres to the Contributor Covenant https://github.com/spring-cloud/spring-cloud-build/blob/main/docs/src/main/asciidoc/code-of-conduct.adoc[code of
51
-
conduct]. By participating, you are expected to uphold this code. Please report
* Make sure all new `.java` files to have a simple Javadoc class comment with at least an
67
-
`@author` tag identifying you, and preferably at least a paragraph on what the class is
68
-
for.
69
-
* Add the ASF license header comment to all new `.java` files (copy from existing files
70
-
in the project)
71
-
* Add yourself as an `@author` to the .java files that you modify substantially (more
72
-
than cosmetic changes).
73
-
* Add some Javadocs and, if you change the namespace, some XSD doc elements.
74
-
* A few unit tests would help a lot as well -- someone has to do it.
75
-
* If no-one else is using your branch, please rebase it against the current main (or
76
-
other target branch in the main project).
77
-
* When writing a commit message please follow https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html[these conventions],
78
-
if you are fixing an existing issue please add `Fixes gh-XXXX` at the end of the commit
79
-
message (where XXXX is the issue number).
80
-
81
-
[[checkstyle]]
82
-
== Checkstyle
83
-
84
-
Spring Cloud Build comes with a set of checkstyle rules. You can find them in the `spring-cloud-build-tools` module. The most notable files under the module are:
85
-
86
-
.spring-cloud-build-tools/
87
-
----
88
-
└── src
89
-
├── checkstyle
90
-
│ └── checkstyle-suppressions.xml <3>
91
-
└── main
92
-
└── resources
93
-
├── checkstyle-header.txt <2>
94
-
└── checkstyle.xml <1>
95
-
----
96
-
<1> Default Checkstyle rules
97
-
<2> File header setup
98
-
<3> Default suppression rules
99
-
100
-
[[checkstyle-configuration]]
101
-
=== Checkstyle configuration
102
-
103
-
Checkstyle rules are *disabled by default*. To add checkstyle to your project just define the following properties and plugins.
<4> Add the Spring Java Format plugin that will reformat your code to pass most of the Checkstyle formatting rules
141
-
<5> Add checkstyle plugin to your build and reporting phases
142
-
143
-
If you need to suppress some rules (e.g. line length needs to be longer), then it's enough for you to define a file under `${project.root}/src/checkstyle/checkstyle-suppressions.xml` with your suppressions. Example:
It's advisable to copy the `${spring-cloud-build.rootFolder}/.editorconfig` and `${spring-cloud-build.rootFolder}/.springformat` to your project. That way, some default formatting rules will be applied. You can do so by running this script:
In order to setup Intellij you should import our coding conventions, inspection profiles and set up the checkstyle plugin.
171
-
The following files can be found in the https://github.com/spring-cloud/spring-cloud-build/tree/main/spring-cloud-build-tools[Spring Cloud Build] project.
172
-
173
-
.spring-cloud-build-tools/
174
-
----
175
-
└── src
176
-
├── checkstyle
177
-
│ └── checkstyle-suppressions.xml <3>
178
-
└── main
179
-
└── resources
180
-
├── checkstyle-header.txt <2>
181
-
├── checkstyle.xml <1>
182
-
└── intellij
183
-
├── Intellij_Project_Defaults.xml <4>
184
-
└── Intellij_Spring_Boot_Java_Conventions.xml <5>
185
-
----
186
-
<1> Default Checkstyle rules
187
-
<2> File header setup
188
-
<3> Default suppression rules
189
-
<4> Project defaults for Intellij that apply most of Checkstyle rules
190
-
<5> Project style conventions for Intellij that apply most of Checkstyle rules
Go to `File` -> `Settings` -> `Editor` -> `Code style`. There click on the icon next to the `Scheme` section. There, click on the `Import Scheme` value and pick the `Intellij IDEA code style XML` option. Import the `spring-cloud-build-tools/src/main/resources/intellij/Intellij_Spring_Boot_Java_Conventions.xml` file.
Go to `File` -> `Settings` -> `Editor` -> `Inspections`. There click on the icon next to the `Profile` section. There, click on the `Import Profile` and import the `spring-cloud-build-tools/src/main/resources/intellij/Intellij_Project_Defaults.xml` file.
203
-
204
-
.Checkstyle
205
-
206
-
To have Intellij work with Checkstyle, you have to install the `Checkstyle` plugin. It's advisable to also install the `Assertions2Assertj` to automatically convert the JUnit assertions
Go to `File` -> `Settings` -> `Other settings` -> `Checkstyle`. There click on the `+` icon in the `Configuration file` section. There, you'll have to define where the checkstyle rules should be picked from. In the image above, we've picked the rules from the cloned Spring Cloud Build repository. However, you can point to the Spring Cloud Build's GitHub repository (e.g. for the `checkstyle.xml` : `https://raw.githubusercontent.com/spring-cloud/spring-cloud-build/main/spring-cloud-build-tools/src/main/resources/checkstyle.xml`). We need to provide the following variables:
211
-
212
-
- `checkstyle.header.file` - please point it to the Spring Cloud Build's, `spring-cloud-build-tools/src/main/resources/checkstyle-header.txt` file either in your cloned repo or via the `https://raw.githubusercontent.com/spring-cloud/spring-cloud-build/main/spring-cloud-build-tools/src/main/resources/checkstyle-header.txt` URL.
213
-
- `checkstyle.suppressions.file` - default suppressions. Please point it to the Spring Cloud Build's, `spring-cloud-build-tools/src/checkstyle/checkstyle-suppressions.xml` file either in your cloned repo or via the `https://raw.githubusercontent.com/spring-cloud/spring-cloud-build/main/spring-cloud-build-tools/src/checkstyle/checkstyle-suppressions.xml` URL.
214
-
- `checkstyle.additional.suppressions.file` - this variable corresponds to suppressions in your local project. E.g. you're working on `spring-cloud-contract`. Then point to the `project-root/src/checkstyle/checkstyle-suppressions.xml` folder. Example for `spring-cloud-contract` would be: `/home/username/spring-cloud-contract/src/checkstyle/checkstyle-suppressions.xml`.
215
-
216
-
IMPORTANT: Remember to set the `Scan Scope` to `All sources` since we apply checkstyle rules for production and test sources.
217
-
218
-
[[duplicate-finder]]
219
-
== Duplicate Finder
220
-
221
-
Spring Cloud Build brings along the `basepom:duplicate-finder-maven-plugin`, that enables flagging duplicate and conflicting classes and resources on the java classpath.
222
-
223
-
[[duplicate-finder-configuration]]
224
-
=== Duplicate Finder configuration
225
-
226
-
Duplicate finder is *enabled by default* and will run in the `verify` phase of your Maven build, but it will only take effect in your project if you add the `duplicate-finder-maven-plugin` to the `build` section of the projecst's `pom.xml`.
For other properties, we have set defaults as listed in the https://github.com/basepom/duplicate-finder-maven-plugin/wiki[plugin documentation].
242
-
243
-
You can easily override them but setting the value of the selected property prefixed with `duplicate-finder-maven-plugin`. For example, set `duplicate-finder-maven-plugin.skip` to `true` in order to skip duplicates check in your build.
244
-
245
-
If you need to add `ignoredClassPatterns` or `ignoredResourcePatterns` to your setup, make sure to add them in the plugin configuration section of your project:
0 commit comments