Skip to content

Update Git Submodules On Refresh #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryanjbaxter opened this issue Jul 6, 2021 · 4 comments · May be fixed by #2864
Open

Update Git Submodules On Refresh #1924

ryanjbaxter opened this issue Jul 6, 2021 · 4 comments · May be fixed by #2864

Comments

@ryanjbaxter
Copy link
Contributor

When using a Git repo as a backend and that Git repo contains a submodule you can clone the submodules but they are never refreshed.

See #1917 (comment)

I think we can use SubmoduleWalk to walk the submodules and update them
https://download.eclipse.org/jgit/site/5.12.0.202106070339-r/apidocs/index.html

@ryanjbaxter
Copy link
Contributor Author

@spencergibb let me know if you think there is a way to make this work today

@spencergibb
Copy link
Member

Not that I'm aware of

@michael-schnell
Copy link

Any news here?

@ryanjbaxter
Copy link
Contributor Author

No, but contributions are welcome

deathbeam added a commit to deathbeam/spring-cloud-config that referenced this issue May 21, 2025
- if cloneSubmodules is enabled, when repo is being refreshed, also
  properly fetch submodule updates
- move cloneSubmodules boolean outside of JGitFactory because this
  property can be changed during runtime and there is no reason for this
  boolean to be copied inside

Closes spring-cloud#1924

Signed-off-by: Tomas Slusny <[email protected]>
deathbeam added a commit to deathbeam/spring-cloud-config that referenced this issue May 23, 2025
- if cloneSubmodules is enabled, when repo is being refreshed, also
  properly fetch submodule updates
- move cloneSubmodules boolean outside of JGitFactory because this
  property can be changed during runtime and there is no reason for this
  boolean to be copied inside

Closes spring-cloud#1924

Signed-off-by: Tomas Slusny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants