MongoDB / JPA - Cleanups.

Author: odrotbohm

jpa/src/test/java/com/oreilly/springdata/jpa/AbstractIntegrationTest.java

@@ -36,7 +36,7 @@
  * @author Oliver Gierke
  */
 @RunWith(SpringJUnit4ClassRunner.class)
-@ContextConfiguration(classes = { ApplicationConfig.class })
+@ContextConfiguration(classes = ApplicationConfig.class)
 @Transactional
 public abstract class AbstractIntegrationTest {
 

jpa/src/test/java/com/oreilly/springdata/jpa/ApplicationConfigTest.java

@@ -24,7 +24,7 @@
 import org.springframework.context.support.ClassPathXmlApplicationContext;
 
 /**
- * Test case bootstrapping both JavaConfig an XML configuration to validate configuration.
+ * Test case bootstrapping both JavaConfig and XML configuration to validate configuration.
  * 
  * @author Oliver Gierke
  */

jpa/src/test/java/com/oreilly/springdata/jpa/CollectionPathMatcher.java

@@ -20,15 +20,28 @@
 import org.hamcrest.Matcher;
 
 /**
+ * Custom matchers to ease assertions on our domain classes.
  * 
  * @author Oliver Gierke
  */
 public class CoreMatchers {
 
+	/**
+	 * Syntactic sugar to make Matchers more readable.
+	 * 
+	 * @param matcher must not be {@literal null}.
+	 * @return
+	 */
 	public static <T> Matcher<T> with(Matcher<T> matcher) {
 		return matcher;
 	}
 
+	/**
+	 * Matches if the {@link Product} has the given name.
+	 * 
+	 * @param name must not be {@literal null}.
+	 * @return
+	 */
 	public static Matcher<Product> named(String name) {
 		return hasProperty("name", is(name));
 	}

jpa/src/test/java/com/oreilly/springdata/jpa/LineItemMatcher.java

@@ -24,6 +24,7 @@
 import com.oreilly.springdata.jpa.AbstractIntegrationTest;
 
 /**
+ * Integration tests for {@link CustomerRepository}.
  * 
  * @author Oliver Gierke
  */

jpa/src/test/java/com/oreilly/springdata/jpa/core/CoreMatchers.java

@@ -26,6 +26,9 @@
 import com.oreilly.springdata.jpa.AbstractIntegrationTest;
 
 /**
+ * Integration test for the manual implementation ({@link JpaCustomerRepository}) of the {@link CustomerRepository}
+ * interface.
+ * 
  * @author Oliver Gierke
  */
 @ActiveProfiles("jpa")

jpa/src/test/java/com/oreilly/springdata/jpa/core/CustomerRepositoryIntegrationTest.java

@@ -22,19 +22,38 @@
 import com.oreilly.springdata.jpa.core.Product;
 
 /**
+ * Matchers to ease assertions on found {@link Order}s.
  * 
  * @author Oliver Gierke
  */
 public class OrderMatchers {
 
+	/**
+	 * Matches if the source {@link Iterable} has an {@link Order} that matches the given {@link Matcher}.
+	 * 
+	 * @param matcher must not be {@literal null}.
+	 * @return
+	 */
 	public static <T> Matcher<Iterable<? super T>> containsOrder(Matcher<? super T> matcher) {
 		return hasItem(matcher);
 	}
 
+	/**
+	 * Matches if the {@link Order} has a {@link LineItem} matching the given {@link Matcher}.
+	 * 
+	 * @param matcher must not be {@literal null}.
+	 * @return
+	 */
 	public static Matcher<Order> LineItem(Matcher<LineItem> matcher) {
 		return hasProperty("lineItems", hasItem(matcher));
 	}
 
+	/**
+	 * Matches if the {@link LineItem} refers to a {@link Product} that matches the given {@link Matcher}.
+	 * 
+	 * @param matcher must not be {@literal null}.
+	 * @return
+	 */
 	public static Matcher<LineItem> Product(Matcher<Product> matcher) {
 		return hasProperty("product", matcher);
 	}

jpa/src/test/java/com/oreilly/springdata/jpa/core/JpaCustomerRepositoryIntegrationTest.java

@@ -34,6 +34,8 @@
 import com.oreilly.springdata.jpa.core.ProductRepository;
 
 /**
+ * Integration tests for {@link OrderRepository}.
+ * 
  * @author Oliver Gierke
  */
 public class OrderRepositoryIntegrationTest extends AbstractIntegrationTest {