Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Commit 0b9a8eb

Browse files
author
Corneil du Plessis
committed
Fix failing tests.
1 parent 117d616 commit 0b9a8eb

File tree

2 files changed

+28
-24
lines changed

2 files changed

+28
-24
lines changed

batch-remote-partition/README.adoc

Lines changed: 28 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,43 @@
1-
# Prerequisites:
1+
= Prerequisites:
22

3-
## Run Locally:
3+
== Run Locally:
44

55
Mysql 5.7 server running and database `test` initialized.
66

7-
## Run in Kubernetes
7+
== Run in Kubernetes
88

99
Use Dataflow deployed in K8s:
1010

11-
```bash
12-
dataflow>app register --name batch-remote-partition --type task --uri "docker://springcloud/batch-remote-partition:0.0.1-SNAPSHOT
11+
[source,bash]
12+
----
13+
dataflow>app register --name batch-remote-partition --type task --uri "docker://springcloud/batch-remote-partition:0.0.1-SNAPSHOT"
1314
dataflow>task create batch-remote-partition --definition batch-remote-partition
1415
dataflow>task launch batch-remote-partition --properties "deployer.*.kubernetes.deploymentServiceAccountName=scdf-data-flow" --arguments "--platform=kubernetes --artifact=docker://springcloud/batch-remote-partition"
15-
```
16+
----
1617

17-
### Build image to minikube registry
18-
```
18+
=== Build image to minikube registry
19+
20+
[source,bash]
21+
----
1922
eval $(minikube docker-env)
2023
./mvnw clean package jib:dockerBuild
21-
```
24+
----
2225

23-
### Publish updated docker image to `springcloud`:
26+
=== Publish updated docker image to `springcloud`:
2427

25-
```bash
28+
[source,bash]
29+
----
2630
$./mvnw clean package jib:build -Djib.to.auth.username= -Djib.to.auth.password=
27-
```
31+
----
2832

29-
## Run in Cloudfoundry
33+
== Run in Cloudfoundry
3034

31-
### Publish updated jar to `repo.spring.io`
35+
=== Publish updated jar to `repo.spring.io`
3236

3337
Set the credentials in ~/.m2/settings.xml
3438

35-
```xml
39+
[source,xml]
40+
----
3641
<settings>
3742
<servers>
3843
<server>
@@ -42,22 +47,22 @@ Set the credentials in ~/.m2/settings.xml
4247
</server>
4348
</servers>
4449
</settings>
45-
```
50+
----
4651

47-
```bash
52+
[source,bash]
53+
----
4854
$./mvnw clean deploy
49-
```
55+
----
5056

5157
Use Dataflow deployed in Cloudfoundry:
5258

5359
In this case we need to provide the internal CloudFoundry Deployer instance with the same CF environment configuration that SCDF uses.
5460
Setting these properties on the task definition will end up as environment variables in the app container.
5561

56-
```bash
57-
dataflow:>app register --name batch-remote-partition --type task --uri maven://org.springframework.cloud.dataflow.acceptence.tests:batch-remote-partition:0.0.1-SNAPSHOT
62+
[source,bash]
63+
----
64+
dataflow:>app register --name batch-remote-partition --type task --uri "maven://org.springframework.cloud.dataflow.acceptence.tests:batch-remote-partition:0.0.1-SNAPSHOT"
5865
dataflow:>task create batch-remote-partition --definition "batch-remote-partition --spring.cloud.deployer.cloudfoundry.password=***** --spring.cloud.deployer.cloudfoundry.username=<username> --spring.cloud.deployer.cloudfoundry.org=<org> --spring.cloud.deployer.cloudfoundry.space=<space> --spring.cloud.deployer.cloudfoundry.url=<url> --spring.cloud.deployer.cloudfoundry.skipSslValidation=true"
5966
# Default artifact will work here.
6067
dataflow:>task launch batch-remote-partition --arguments "--platform=cloudfoundry"
61-
```
62-
63-
68+
----

src/test/java/org/springframework/cloud/dataflow/acceptance/test/BatchRemotePartitioningAT.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import org.junit.jupiter.api.BeforeEach;
2929
import org.junit.jupiter.api.Tag;
3030
import org.junit.jupiter.api.Test;
31-
import org.junit.jupiter.api.condition.DisabledIfSystemProperty;
3231
import org.junit.jupiter.api.condition.EnabledIfSystemProperty;
3332
import org.junit.jupiter.api.extension.ExtendWith;
3433
import org.slf4j.Logger;

0 commit comments

Comments
 (0)