feature: use different icon for sort mode (#1393)

Signed-off-by: leo <[email protected]>

Author: love-linger

src/Resources/Icons.axaml

@@ -89,7 +89,8 @@
   <StreamGeometry x:Key="Icons.Move">M299 811 299 725 384 725 384 811 299 811M469 811 469 725 555 725 555 811 469 811M640 811 640 725 725 725 725 811 640 811M299 640 299 555 384 555 384 640 299 640M469 640 469 555 555 555 555 640 469 640M640 640 640 555 725 555 725 640 640 640M299 469 299 384 384 384 384 469 299 469M469 469 469 384 555 384 555 469 469 469M640 469 640 384 725 384 725 469 640 469M299 299 299 213 384 213 384 299 299 299M469 299 469 213 555 213 555 299 469 299M640 299 640 213 725 213 725 299 640 299Z</StreamGeometry>
   <StreamGeometry x:Key="Icons.MoveToAnotherGroup">M64 363l0 204 265 0L329 460c0-11 6-18 14-20C349 437 355 437 362 441c93 60 226 149 226 149 33 22 34 60 0 82 0 0-133 89-226 149-14 9-32-3-32-18l-1-110L64 693l0 117c0 41 34 75 75 75l746 0c41 0 75-34 75-74L960 364c0-0 0-1 0-1L64 363zM64 214l0 75 650 0-33-80c-16-38-62-69-103-69l-440 0C97 139 64 173 64 214z</StreamGeometry>
   <StreamGeometry x:Key="Icons.OpenWith">M683 409v204L1024 308 683 0v191c-413 0-427 526-427 526c117-229 203-307 427-307zm85 492H102V327h153s38-63 114-122H51c-28 0-51 27-51 61v697c0 34 23 61 51 61h768c28 0 51-27 51-61V614l-102 100v187z</StreamGeometry>
-  <StreamGeometry x:Key="Icons.Order">M841 627A43 43 0 00811 555h-299v85h196l-183 183A43 43 0 00555 896h299v-85h-196l183-183zM299 170H213v512H85l171 171 171-171H299zM725 128h-85c-18 0-34 11-40 28l-117 313h91L606 384h154l32 85h91l-117-313A43 43 0 00725 128zm-88 171 32-85h26l32 85h-90z</StreamGeometry>
+  <StreamGeometry x:Key="Icons.OrderByName">M841 627A43 43 0 00811 555h-299v85h196l-183 183A43 43 0 00555 896h299v-85h-196l183-183zM299 170H213v512H85l171 171 171-171H299zM725 128h-85c-18 0-34 11-40 28l-117 313h91L606 384h154l32 85h91l-117-313A43 43 0 00725 128zm-88 171 32-85h26l32 85h-90z</StreamGeometry>
+  <StreamGeometry x:Key="Icons.OrderByTime">M0 512M1024 512M512 0M512 1024M279 128l3 0c9 1 18 5 25 12l171 171a43 43 0 01-60 60L320 274V853a43 43 0 01-39 43L277 896a43 43 0 01-43-43V274l-98 98a43 43 0 01-58 2l-3-2a43 43 0 010-60l171-171c8-8 18-12 28-12h3zM640 132c210 0 380 170 380 380 0 210-170 380-380 380a380 380 0 01-206-61 43 43 0 0146-72A294 294 0 00640 807c163 0 295-132 295-295 0-163-132-295-295-295-25 0-49 3-73 9a43 43 0 11-21-83A381 381 0 01640 132zm0 178a43 43 0 0143 43v117l125 0a43 43 0 0143 39l0 3a43 43 0 01-43 43h-167a43 43 0 01-43-43V352a43 43 0 0143-43z</StreamGeometry>
   <StreamGeometry x:Key="Icons.Password">M640 96c-158 0-288 130-288 288 0 17 3 31 5 46L105 681 96 691V928h224v-96h96v-96h96v-95c38 18 82 31 128 31 158 0 288-130 288-288s-130-288-288-288zm0 64c123 0 224 101 224 224s-101 224-224 224a235 235 0 01-109-28l-8-4H448v96h-96v96H256v96H160v-146l253-254 12-11-3-17C419 417 416 400 416 384c0-123 101-224 224-224zm64 96a64 64 0 100 128 64 64 0 100-128z</StreamGeometry>
   <StreamGeometry x:Key="Icons.Paste">M544 85c49 0 90 37 95 85h75a96 96 0 0196 89L811 267a32 32 0 01-28 32L779 299a32 32 0 01-32-28L747 267a32 32 0 00-28-32L715 235h-91a96 96 0 01-80 42H395c-33 0-62-17-80-42L224 235a32 32 0 00-32 28L192 267v576c0 16 12 30 28 32l4 0h128a32 32 0 0132 28l0 4a32 32 0 01-32 32h-128a96 96 0 01-96-89L128 843V267a96 96 0 0189-96L224 171h75a96 96 0 0195-85h150zm256 256a96 96 0 0196 89l0 7v405a96 96 0 01-89 96L800 939h-277a96 96 0 01-96-89L427 843v-405a96 96 0 0189-96L523 341h277zm-256-192H395a32 32 0 000 64h150a32 32 0 100-64z</StreamGeometry>
   <StreamGeometry x:Key="Icons.Plus">m186 532 287 0 0 287c0 11 9 20 20 20s20-9 20-20l0-287 287 0c11 0 20-9 20-20s-9-20-20-20l-287 0 0-287c0-11-9-20-20-20s-20 9-20 20l0 287-287 0c-11 0-20 9-20 20s9 20 20 20z</StreamGeometry>

src/ViewModels/Repository.cs

@@ -434,6 +434,21 @@ public bool IsWorktreeGroupExpanded
             }
         }
 
+        public bool IsSortingLocalBranchByName
+        {
+            get => _settings.LocalBranchSortMode == Models.BranchSortMode.Name;
+        }
+
+        public bool IsSortingRemoteBranchByName
+        {
+            get => _settings.RemoteBranchSortMode == Models.BranchSortMode.Name;
+        }
+
+        public bool IsSortingTagsByName
+        {
+            get => _settings.TagSortMode == Models.TagSortMode.Name;
+        }
+
         public InProgressContext InProgressContext
         {
             get => _workingCopy?.InProgressContext;
@@ -2381,9 +2396,15 @@ public ContextMenu CreateContextMenuForBranchSortMode(bool local)
             var changeMode = new Action<Models.BranchSortMode>(m =>
             {
                 if (local)
+                {
                     _settings.LocalBranchSortMode = m;
+                    OnPropertyChanged(nameof(IsSortingLocalBranchByName));
+                }
                 else
+                {
                     _settings.RemoteBranchSortMode = m;
+                    OnPropertyChanged(nameof(IsSortingRemoteBranchByName));
+                }
 
                 var builder = BuildBranchTree(_branches, _remotes);
                 LocalBranchTrees = builder.Locals;
@@ -2415,6 +2436,7 @@ public ContextMenu CreateContextMenuForBranchSortMode(bool local)
             };
 
             var menu = new ContextMenu();
+            menu.Placement = PlacementMode.BottomEdgeAlignedLeft;
             menu.Items.Add(byNameAsc);
             menu.Items.Add(byCommitterDate);
             return menu;
@@ -2428,6 +2450,7 @@ public ContextMenu CreateContextMenuForTagSortMode()
                 if (_settings.TagSortMode != m)
                 {
                     _settings.TagSortMode = m;
+                    OnPropertyChanged(nameof(IsSortingTagsByName));
                     VisibleTags = BuildVisibleTags();
                 }
             });
@@ -2453,6 +2476,7 @@ public ContextMenu CreateContextMenuForTagSortMode()
             };
 
             var menu = new ContextMenu();
+            menu.Placement = PlacementMode.BottomEdgeAlignedLeft;
             menu.Items.Add(byCreatorDate);
             menu.Items.Add(byName);
             return menu;

src/Views/Repository.axaml

@@ -229,7 +229,10 @@
                       Margin="8,0,0,0"
                       Click="OnOpenSortLocalBranchMenu"
                       ToolTip.Tip="{DynamicResource Text.Repository.BranchSort}">
-                <Path Width="12" Height="12" Data="{StaticResource Icons.Order}"/>
+                <Grid>
+                  <Path Width="12" Height="12" Data="{StaticResource Icons.OrderByName}" IsVisible="{Binding IsSortingLocalBranchByName, Mode=OneWay}"/>
+                  <Path Width="12" Height="12" Data="{StaticResource Icons.OrderByTime}" IsVisible="{Binding !IsSortingLocalBranchByName, Mode=OneWay}"/>
+                </Grid>
               </Button>
               <Button Grid.Column="3" Classes="icon_button" Width="14" Margin="8,0" Command="{Binding CreateNewBranch}" ToolTip.Tip="{DynamicResource Text.Repository.NewBranch}">
                 <Path Width="12" Height="12" Data="{StaticResource Icons.Branch.Add}"/>
@@ -259,7 +262,10 @@
                       Margin="8,0,0,0"
                       Click="OnOpenSortRemoteBranchMenu"
                       ToolTip.Tip="{DynamicResource Text.Repository.BranchSort}">
-                <Path Width="12" Height="12" Data="{StaticResource Icons.Order}"/>
+                <Grid>
+                  <Path Width="12" Height="12" Data="{StaticResource Icons.OrderByName}" IsVisible="{Binding IsSortingRemoteBranchByName, Mode=OneWay}"/>
+                  <Path Width="12" Height="12" Data="{StaticResource Icons.OrderByTime}" IsVisible="{Binding !IsSortingRemoteBranchByName, Mode=OneWay}"/>
+                </Grid>
               </Button>
               <Button Grid.Column="3" Classes="icon_button" Width="14" Margin="8,0" Command="{Binding AddRemote}" ToolTip.Tip="{DynamicResource Text.Repository.Remotes.Add}">
                 <Path Width="12" Height="12" Data="{StaticResource Icons.Remote.Add}"/>
@@ -294,7 +300,10 @@
                       Margin="8,0,0,0"
                       Click="OnOpenSortTagMenu"
                       ToolTip.Tip="{DynamicResource Text.Repository.Tags.Sort}">
-                <Path Width="12" Height="12" Margin="0,2,0,0" Data="{StaticResource Icons.Order}"/>
+                <Grid>
+                  <Path Width="12" Height="12" Data="{StaticResource Icons.OrderByName}" IsVisible="{Binding IsSortingTagsByName, Mode=OneWay}"/>
+                  <Path Width="12" Height="12" Data="{StaticResource Icons.OrderByTime}" IsVisible="{Binding !IsSortingTagsByName, Mode=OneWay}"/>
+                </Grid>
               </Button>
               <Button Grid.Column="4"
                       Classes="icon_button"