Fix Well Separation default and max allowed values to apparent original intentions of 1km and 10km. Retain likely-unintended default unit of inches instead of switching to meters for backwards compatibility and update tooltip text to note the discrepancy.

Author: softwareengineerprogrammer

src/geophires_x/WellBores.py

@@ -824,17 +824,28 @@ def __init__(self, model: Model):
                         'production well, this parameter specifies the overall pressure drop in the reservoir between '
                         'injection well and production well (see docs)'
         )
+
+        well_separation_default_value_m = 1000
+        well_separation_default_unit = LengthUnit.INCHES
+        well_separation_preferred_unit = LengthUnit.METERS
+        well_separation_unit_mismatch_note = (f'. (Note that the default unit is '
+                                              f'{well_separation_default_unit.name.lower()}.)'
+                                              if well_separation_default_unit != well_separation_preferred_unit else '')
+        # noinspection SpellCheckingInspection
         self.wellsep = self.ParameterDict[self.wellsep.Name] = floatParameter(
             "Well Separation",
-            DefaultValue=1000.0,
+            DefaultValue=int(quantity(well_separation_default_value_m, 'm')
+                             .to(well_separation_default_unit.value).magnitude),
             Min=10.,
-            Max=10000.,
+            Max=int(quantity(10000, 'm').to(well_separation_default_unit.value).magnitude),
             UnitType=Units.LENGTH,
-            PreferredUnits=LengthUnit.METERS,
-            CurrentUnits=LengthUnit.INCHES,
-            ErrMessage="assume default well separation (1000 m)",
-            ToolTipText="Well separation for built-in TOUGH2 doublet reservoir model"
+            PreferredUnits=well_separation_preferred_unit,
+            CurrentUnits=well_separation_default_unit,
+            ErrMessage=f'assume default well separation ({well_separation_default_value_m} m)',
+            ToolTipText=f'Well separation for built-in TOUGH2 doublet reservoir model'
+                        f'{well_separation_unit_mismatch_note}'
         )
+
         self.Tinj = self.ParameterDict[self.Tinj.Name] = floatParameter(
             "Injection Temperature",
             DefaultValue=70.0,

src/geophires_x_schema_generator/geophires-request.json

@@ -710,13 +710,13 @@
       "maximum": 10000.0
     },
     "Well Separation": {
-      "description": "Well separation for built-in TOUGH2 doublet reservoir model",
+      "description": "Well separation for built-in TOUGH2 doublet reservoir model. (Note that the default unit is inches.)",
       "type": "number",
       "units": "in",
       "category": "Well Bores",
-      "default": 1000.0,
+      "default": 39370,
       "minimum": 10.0,
-      "maximum": 10000.0
+      "maximum": 393700
     },
     "Injection Temperature": {
       "description": "Constant geofluid injection temperature at injection wellhead.",