Skip to content

Commit ea6b3e6

Browse files
Merge branch 'development'
2 parents c03fe0e + 2e82c17 commit ea6b3e6

File tree

4 files changed

+9
-10
lines changed

4 files changed

+9
-10
lines changed

analytics/src/main/java/com/sofakingforever/analytics/kits/logger/LoggerDispatcherImpl.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,7 @@ class LoggerDispatcherImpl(override val init: Boolean) : AnalyticsDispatcher {
4040
Log.d(tag, "Tracking inviteEvent ${inviteEvent.packageName}")
4141
}
4242

43-
override fun setUserProperty(property: SetUserProperty) {
44-
Log.d(tag, "Tracking user property ${property.key} = ${property.value}")
45-
}
43+
4644
override fun setUserProperties(properties: SetUserProperties) {
4745
Log.d(tag, "Tracking user properties ${properties.getUserProperties(kit)}")
4846
}

analytics/src/main/java/com/sofakingforever/analytics/version/VersionChecker.kt

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,20 @@ package com.sofakingforever.analytics.version
33
import com.sofakingforever.library.BuildConfig
44
import com.sofakingforever.repoverse.Version
55
import com.sofakingforever.repoverse.resolvers.BintrayVersionResolver
6+
import com.sofakingforever.repoverse.resolvers.GitHubVersionResolver
67

78
object VersionChecker {
89

910
private val currentVersion = Version(BuildConfig.VERSION_NAME)
1011

11-
private const val packagePath: String = "sofakingforever/analytics/kotlin-analytics"
12+
private const val packagePath: String = "sofakingforever/kotlin-analytics"
1213

1314
fun invoke() {
14-
BintrayVersionResolver(packagePath)
15+
16+
// we use github instead of bintray,
17+
// because usually that's the one that's updated after live-tests were done
18+
19+
GitHubVersionResolver(packagePath)
1520
.resolve(VersionResolverCallback(currentVersion))
1621

1722
}

analytics/src/test/java/com/sofakingforever/library/dispatcher/TestableDispatcher.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,6 @@ class TestableDispatcher : AnalyticsDispatcher {
3434
eventList.add(inviteEvent)
3535
}
3636

37-
override fun setUserProperty(property: SetUserProperty) {
38-
eventList.add(property)
39-
}
40-
4137
override fun setUserProperties(properties: SetUserProperties) {
4238
eventList.add(properties)
4339
}

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ org.gradle.jvmargs=-Xmx1536m
1111
# This option should only be used with decoupled projects. More details, visit
1212
# http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
1313
# org.gradle.parallel=true
14-
version=1.0.17
14+
version=1.0.18

0 commit comments

Comments
 (0)