Skip to content

Commit af228ee

Browse files
Extracted VersionChecker
1 parent 1e482d5 commit af228ee

File tree

8 files changed

+28
-116
lines changed

8 files changed

+28
-116
lines changed

analytics/build.gradle

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,10 @@ android {
4141
// unitTests.returnDefaultValues = true
4242
// }
4343
}
44+
repositories {
45+
mavenCentral()
46+
47+
}
4448

4549
dependencies {
4650

@@ -60,6 +64,7 @@ dependencies {
6064
androidTestImplementation 'org.mockito:mockito-android:2.7.22'
6165

6266
implementation 'com.squareup.okhttp3:okhttp:3.11.0'
67+
implementation 'com.sofakingforever.repoverse:repoverse:1.0.1'
6368

6469

6570

@@ -69,9 +74,6 @@ dependencies {
6974
// testCompile 'org.powermock:powermock-api-mockito:1.6.5'
7075

7176

72-
}
73-
repositories {
74-
mavenCentral()
7577
}
7678
ext {
7779
bintrayRepo = 'analytics'

analytics/src/main/java/com/sofakingforever/analytics/version/BintrayVersionResolver.kt

Lines changed: 0 additions & 50 deletions
This file was deleted.

analytics/src/main/java/com/sofakingforever/analytics/version/RemoteVersionResolver.kt

Lines changed: 0 additions & 14 deletions
This file was deleted.

analytics/src/main/java/com/sofakingforever/analytics/version/Version.kt

Lines changed: 0 additions & 37 deletions
This file was deleted.

analytics/src/main/java/com/sofakingforever/analytics/version/VersionChecker.kt

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,18 @@
11
package com.sofakingforever.analytics.version
22

3-
import android.util.Log
43
import com.sofakingforever.library.BuildConfig
4+
import com.sofakingforever.repoverse.Version
5+
import com.sofakingforever.repoverse.resolvers.BintrayVersionResolver
56

67
object VersionChecker {
78

8-
val currentVersion = Version(BuildConfig.VERSION_NAME)
9+
private val currentVersion = Version(BuildConfig.VERSION_NAME)
910

10-
private val callback: RemoteVersionResolver.Callback = object : RemoteVersionResolver.Callback {
11-
override fun onVersionResolved(latestVersion: Version) {
12-
if (currentVersion < latestVersion) {
13-
// user should update
14-
Log.w("kotlin-analytics", "Latest library version $latestVersion > $currentVersion (current)")
15-
}
16-
}
17-
18-
}
11+
private const val packagePath: String = "sofakingforever/analytics/kotlin-analytics"
1912

2013
fun invoke() {
21-
BintrayVersionResolver("sofakingforever/analytics/kotlin-analytics").resolve(callback)
14+
BintrayVersionResolver(packagePath)
15+
.resolve(VersionResolverCallback(currentVersion))
2216

2317
}
2418

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
package com.sofakingforever.analytics.version
2+
3+
import android.util.Log
4+
import com.sofakingforever.repoverse.Version
5+
import com.sofakingforever.repoverse.resolvers.RemoteVersionResolver
6+
7+
class VersionResolverCallback(private val currentVersion: Version) : RemoteVersionResolver.Callback {
8+
9+
override fun onVersionResolved(latestVersion: Version) {
10+
if (currentVersion < latestVersion) {
11+
// user should update
12+
Log.w("kotlin-analytics", "Latest library version $latestVersion > $currentVersion (current)")
13+
}
14+
}
15+
}

app/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ dependencies {
3131
androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.2'
3232

3333
implementation project(path: ':analytics')
34+
3435
implementation project(path: ':kit-answers')
3536
implementation project(path: ':kit-firebase')
3637
implementation project(path: ':kit-flurry')

build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ allprojects {
1919
repositories {
2020
google()
2121
jcenter()
22+
maven { url "https://dl.bintray.com/sofakingforever/repoverse" }
2223
}
2324
}
2425

0 commit comments

Comments
 (0)