Skip to content

Commit 04ccdc0

Browse files
Moved some things around
1 parent 7c7f9e5 commit 04ccdc0

File tree

11 files changed

+19
-59
lines changed

11 files changed

+19
-59
lines changed

.gitignore

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,6 @@ android-analytics/local\.properties
1313

1414
kotlin-analytics/local\.properties
1515

16-
kotlin-analytics/build/kotlin-build/
16+
kotlin-analytics/build/
17+
18+
android-analytics/build/

kotlin-analytics/src/main/kotlin/com/sofakingforever/analytics/kits/logger/LoggerDispatcherImpl.kt renamed to android-analytics/android/src/main/java/com/sofakingforever/analytics/android/kits/logger/LoggerDispatcherImpl.kt

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import android.content.Context
44
import android.util.Log
55
import com.sofakingforever.analytics.AnalyticsDispatcher
66
import com.sofakingforever.analytics.AnalyticsKit
7+
import com.sofakingforever.analytics.android.AndroidAnalyticsDispatcher
78
import com.sofakingforever.analytics.events.*
89

910
/**
@@ -12,19 +13,18 @@ import com.sofakingforever.analytics.events.*
1213
* Look at AnswersDispatcher or FirebaseDispatcher to learn more about
1314
* how to implement your own service dispatcher.
1415
*/
15-
class LoggerDispatcherImpl(override val init: Boolean) : AnalyticsDispatcher {
16+
class LoggerDispatcherImpl(override val init: Boolean, override val context: Context) : AndroidAnalyticsDispatcher {
1617

1718

1819
override val dispatcherName: String = "LoggerDispatcher"
1920

20-
constructor() : this(true)
21-
21+
constructor(context: Context) : this(true, context)
2222

2323
private val tag = dispatcherName
2424

2525
override val kit: AnalyticsKit = LoggerKit.instance
2626

27-
override fun initDispatcher(context: Context) {
27+
override fun initDispatcher() {
2828
Log.d(tag, "Init Logger Analytics Dispatcher")
2929
}
3030

@@ -36,10 +36,6 @@ class LoggerDispatcherImpl(override val init: Boolean) : AnalyticsDispatcher {
3636
Log.d(tag, "Tracking event ${event.getEventName(kit)}")
3737
}
3838

39-
override fun trackInviteEvent(inviteEvent: InviteEvent) {
40-
Log.d(tag, "Tracking inviteEvent ${inviteEvent.packageName}")
41-
}
42-
4339

4440
override fun setUserProperties(properties: SetUserProperties) {
4541
Log.d(tag, "Tracking user properties ${properties.getUserProperties(kit)}")

kotlin-analytics/src/main/kotlin/com/sofakingforever/analytics/AnalyticsDispatcher.kt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package com.sofakingforever.analytics
22

33
import com.sofakingforever.analytics.events.ContentViewEvent
44
import com.sofakingforever.analytics.events.CustomEvent
5-
import com.sofakingforever.analytics.events.InviteEvent
65
import com.sofakingforever.analytics.events.SetUserProperties
76
import com.sofakingforever.analytics.events.base.Event
87
import com.sofakingforever.analytics.exceptions.UnsupportedEventException
@@ -31,8 +30,6 @@ interface AnalyticsDispatcher {
3130

3231
fun trackCustomEvent(event: CustomEvent)
3332

34-
fun trackInviteEvent(inviteEvent: InviteEvent)
35-
3633
fun setUserProperties(properties: SetUserProperties)
3734

3835
/**
@@ -56,11 +53,6 @@ interface AnalyticsDispatcher {
5653
handled = true
5754
}
5855

59-
if (event is InviteEvent) {
60-
trackInviteEvent(event)
61-
handled = true
62-
}
63-
6456
if (event is SetUserProperties) {
6557
setUserProperties(event)
6658
handled = true

kotlin-analytics/src/main/kotlin/com/sofakingforever/analytics/events/InviteEvent.kt

Lines changed: 0 additions & 21 deletions
This file was deleted.

kotlin-analytics/src/main/kotlin/com/sofakingforever/analytics/events/SetUserProperty.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package com.sofakingforever.analytics.events
22

33
import com.sofakingforever.analytics.AnalyticsKit
44

5-
@Deprecated("Use SetUserProperties instead")
65
interface SetUserProperty : SetUserProperties {
76

87
val key: String

kotlin-analytics/src/main/kotlin/com/sofakingforever/analytics/version/VersionChecker.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
package com.sofakingforever.analytics.version
22

3-
import com.sofakingforever.library.BuildConfig
43
import com.sofakingforever.repoverse.Version
54
import com.sofakingforever.repoverse.resolvers.BintrayVersionResolver
65
import com.sofakingforever.repoverse.resolvers.GitHubVersionResolver
76

87
object VersionChecker {
98

10-
private val currentVersion = Version(BuildConfig.VERSION_NAME)
9+
private val currentVersion = Version("1.0.19")
1110

1211
private const val packagePath: String = "sofakingforever/kotlin-analytics"
1312

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.sofakingforever.analytics.version
22

3-
import android.util.Log
3+
44
import com.sofakingforever.repoverse.Version
55
import com.sofakingforever.repoverse.resolvers.RemoteVersionResolver
66

@@ -9,7 +9,7 @@ class VersionResolverCallback(private val currentVersion: Version) : RemoteVersi
99
override fun onVersionResolved(latestVersion: Version) {
1010
if (currentVersion < latestVersion) {
1111
// user should update
12-
Log.w("kotlin-analytics", "Latest library version $latestVersion > $currentVersion (current)")
12+
System.out.println("Latest library version $latestVersion > $currentVersion (current)")
1313
}
1414
}
1515
}

kotlin-analytics/src/test/kotlin/com/sofakingforever/library/AnalyticsUnitTest.kt

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.sofakingforever.library
22

3-
import android.content.Context
43
import com.sofakingforever.analytics.Analytics
54
import com.sofakingforever.analytics.AnalyticsSettings
65
import com.sofakingforever.analytics.exceptions.EventNotTrackedException
@@ -9,26 +8,24 @@ import com.sofakingforever.library.dispatcher.TestKit
98
import com.sofakingforever.library.dispatcher.TestableDispatcher
109
import com.sofakingforever.library.events.*
1110
import org.junit.Test
12-
import org.mockito.Mockito
13-
import org.mockito.Mockito.mock
1411

1512
class AnalyticsUnitTest {
1613

17-
private val contextMock = mock(Context::class.java)
14+
// private val contextMock = mock(Context::class.java)
1815

1916
private lateinit var analytics: Analytics
2017

2118
private val dispatcher = TestableDispatcher()
2219
private var raisedException: Exception? = null
2320

2421
init {
25-
Mockito.`when`(contextMock.applicationContext).thenReturn(contextMock)
22+
// Mockito.`when`(contextMock.applicationContext).thenReturn(contextMock)
2623
}
2724

2825
@Test
2926
fun testAnalytics() {
3027

31-
analytics = Analytics(AnalyticsSettings(contextMock), dispatcher).apply {
28+
analytics = Analytics(AnalyticsSettings(), dispatcher).apply {
3229

3330
this.exceptionHandler = object : Analytics.ExceptionHandler {
3431
override fun onException(e: Exception) {
@@ -55,6 +52,7 @@ class AnalyticsUnitTest {
5552
assert(raisedException is EventNotTrackedException)
5653
assert((raisedException as EventNotTrackedException).cause is UnsupportedEventException)
5754

55+
Thread.sleep(5000)
5856
}
5957

6058

kotlin-analytics/src/test/kotlin/com/sofakingforever/library/DispatcherTest.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.sofakingforever.library
22

3-
import android.app.Application
43
import com.sofakingforever.library.dispatcher.TestableDispatcher
54
import com.sofakingforever.library.events.InitDispatcherEvent
65
import com.sofakingforever.library.events.TestCustomEvent
@@ -16,7 +15,7 @@ class DispatcherTest {
1615

1716
val dispatcher = TestableDispatcher()
1817

19-
dispatcher.initDispatcher(Application())
18+
dispatcher.initDispatcher()
2019

2120
dispatcher.track(TestCustomEvent(1))
2221

kotlin-analytics/src/test/kotlin/com/sofakingforever/library/dispatcher/TestableDispatcher.kt

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
package com.sofakingforever.library.dispatcher
22

3-
import android.content.Context
43
import com.sofakingforever.analytics.AnalyticsDispatcher
54
import com.sofakingforever.analytics.AnalyticsKit
6-
import com.sofakingforever.analytics.events.*
5+
import com.sofakingforever.analytics.events.ContentViewEvent
6+
import com.sofakingforever.analytics.events.CustomEvent
7+
import com.sofakingforever.analytics.events.SetUserProperties
78
import com.sofakingforever.analytics.events.base.Event
89
import com.sofakingforever.library.events.InitDispatcherEvent
910

@@ -17,8 +18,7 @@ class TestableDispatcher : AnalyticsDispatcher {
1718
override val dispatcherName: String = DispatcherName
1819

1920
val eventList: MutableList<Event> = mutableListOf()
20-
21-
override fun initDispatcher(context: Context) {
21+
override fun initDispatcher() {
2222
track(InitDispatcherEvent())
2323
}
2424

@@ -30,10 +30,6 @@ class TestableDispatcher : AnalyticsDispatcher {
3030
eventList.add(event)
3131
}
3232

33-
override fun trackInviteEvent(inviteEvent: InviteEvent) {
34-
eventList.add(inviteEvent)
35-
}
36-
3733
override fun setUserProperties(properties: SetUserProperties) {
3834
eventList.add(properties)
3935
}

0 commit comments

Comments
 (0)