Support PHP_CodeSniffer 4.0

[takaram]

PHP_CodeSniffer 4.0.0beta1 has been released.
Currently, the composer.json of slevomat/coding-standard does not allow 4.0.0:

coding-standard/composer.json

Line 19 in 1501a61

"squizlabs/php_codesniffer": "^3.12.2"

Is it possible to update the version constraint to allow "^4.0"?

Thank you for your work on this great coding standard! 🙏

[pieterocp]

There will end up needing to be a bit more than just a version constraint change, e.g. see the branch phpcs4 + will likely require a few more changes.

[kukulich]

8fb1dfd

[bytehead]

This leads to a fatal error because the sniffs are not compatible with the interface anymore:

PHP Fatal error:  Declaration of SlevomatCodingStandard\Sniffs\TypeHints\DisallowArrayTypeHintSyntaxSniff::process(PHP_CodeSniffer\Files\File $phpcsFile, int $docCommentOpenPointer): void must be compatible with PHP_CodeSniffer\Sniffs\Sniff::process(PHP_CodeSniffer\Files\File $phpcsFile, $stackPtr) in /vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/TypeHints/DisallowArrayTypeHintSyntaxSniff.php on line 57

php: 8.4.12
slevomat/coding-standard: 8.23.0
squizlabs/php_codesniffer: 4.0.0

[kukulich]

This is strange: https://github.com/slevomat/coding-standard/actions/runs/17758772678

[bytehead]

It is! I just spotted that the return type void was in already before 4.0... 🤔

[bytehead]

It works with

squizlabs/php_codesniffer: 3.13.2
slevomat/coding-standard: 8.21.1

and also this combination

squizlabs/php_codesniffer: 3.13.4
slevomat/coding-standard: 8.22.1

[bytehead]

Got it, it's related to symplify/easy-coding-standard, will report there (or create a PR) 🙃