Patches for Ubuntu 12.04 with a Clang 3.2 trunk 157126 and newer Gtk

[ivucica]

Hi,

At the moment, I'm too lazy to play with creating proper patches, creating a git clone, making a pull request, etc. Also, I'm extremely low on disk space, so I'd rather not play too much having built Chromium and Berkelium successfully.

That said, two patches need to be applied to Chromium source code so it can be built with Clang 3.2 trunk, revision 157126.

1. Some assembly is not specific enough.

See http://code.google.com/p/seccompsandbox/issues/detail?id=14

This patch, from aforementioned link but adjusted for comments in that same issue, needs to be applied to seccompsandbox:

Index: fault_handler_i386.S
===================================================================
--- fault_handler_i386.S    (revision 153)
+++ fault_handler_i386.S    (working copy)
@@ -178,9 +178,9 @@
         // callers might be confused by this and will need fixing for running
         // inside of the seccomp sandbox.
      20:lea  playground$sa_segv, %eax
-        cmp  $0, 0(%eax)         // SIG_DFL
+        cmpl $0, 0(%eax)         // SIG_DFL
         jz   21f
-        cmp  $1, 0(%eax)         // SIG_IGN
+        cmpl  $1, 0(%eax)         // SIG_IGN
         jnz  22f                 // can't really ignore synchronous signals

Or even better! See this patch that also fixed x86_64. http://code.google.com/p/seccompsandbox/source/detail?r=154

2. Header include missing

Glib's internationalization header needs to be included.

Index: build/chromium/src/ui/base/l10n/l10n_util.cc
===================================================================
--- build/chromium/src/ui/base/l10n/l10n_util.cc    (revision 87952)
+++ build/chromium/src/ui/base/l10n/l10n_util.cc    (working copy)
@@ -6,6 +6,8 @@

 #if defined(TOOLKIT_USES_GTK)
 #include <glib/gutils.h>
+#include <glib/gi18n.h>
+
 #endif

 #include <algorithm>

That seems to be about it. Now, hopefully someone can spare some time to properly integrate these patches into the build process. :-)

[ewencp]

The second patch is included in the chromium11 branch now because it was required to fix the build on Ubuntu 12.04.

I'd be happy to include the first patch as well (it's as easy as including it in the patches/ directory), but I need to be able to test it. What's your process for testing with clang? And are you using a stock version of clang provided in a package or testing with something newer. If testing with something newer, is it required or just what you happened to use?