Administration is broken due to a critical error with removed theme config values

[timo-haas-gh]

Shopware Version

6.7Rc5

Affected area / extension

Platform(Default)

Actual behaviour

If a theme config value is changed (and then stored in 'config_values') a critical error occured when the value is removed from the base_config (via. update for e.g.)
This is very critical because it denies the removal of outdated config values.

Thats because of a missing null check in the THemeService.php an the 'type'-key

Expected behaviour

A null check should be implemented.

How to reproduce

1. create a theme with a configuration (theme.json)
2. change the value in the administration (it changes the config_values)
3. remove the value from your theme.json
4. update your theme
5. try to compile the configuration

Definition of Done

• An automated test covers the fix.
• Integration/E2E testing in staging is done.
• Changelog markdown file created or updated in /changelog/_unreleased directory.
• Developer documentation written/updated.
• End user and/or developer documentation written or updated with clarification.
• Regression test created to ensure bug does not reappear, and automated regression tests pass.
• Code changes resolve the reported bug without introducing new issues.

[timo-haas-gh]

@marcelbrode i have seen that you have refactored the ThemeService.php and other stuff. So in the trunk the null check is implemented. Can you verify that the explained issue is solved and if the fix is implemented into the actual 6.7 release?
The issue can lead to serious problems when someone has old values from older theme versions stored in the database.

Thanks in advance :)