Skip to content

Commit db308ef

Browse files
committed
refactor: apply review comments
1 parent cfdc66f commit db308ef

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

postgres-native-tls/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,6 @@ where
185185
/// Set ALPN for `TlsConnectorBuilder`
186186
///
187187
/// This is required when using `sslnegotiation=direct`
188-
pub fn set_postgresql_alpn(builder: &mut TlsConnectorBuilder) -> &mut TlsConnectorBuilder {
189-
builder.request_alpns(&["postgresql"])
188+
pub fn set_postgresql_alpn(builder: &mut TlsConnectorBuilder) {
189+
builder.request_alpns(&["postgresql"]);
190190
}

postgres/src/config.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ use tokio_postgres::{Error, Socket};
4141
/// can be specified, separated by commas. Each host will be tried in turn when connecting. Required if connecting
4242
/// with the `connect` method.
4343
/// * `sslnegotiation` - TLS negotiation method. If set to `direct`, the client will perform direct TLS handshake, this only works for PostgreSQL 17 and newer.
44+
/// Note that you will need to setup ALPN of TLS client configuration to `postgresql` when using direct TLS.
4445
/// If set to `postgres`, the default value, it follows original postgres wire protocol to perform the negotiation.
4546
/// * `hostaddr` - Numeric IP address of host to connect to. This should be in the standard IPv4 address format,
4647
/// e.g., 172.28.40.9. If your machine supports IPv6, you can also use those addresses.

tokio-postgres/src/config.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@ pub enum Host {
117117
/// can be specified, separated by commas. Each host will be tried in turn when connecting. Required if connecting
118118
/// with the `connect` method.
119119
/// * `sslnegotiation` - TLS negotiation method. If set to `direct`, the client will perform direct TLS handshake, this only works for PostgreSQL 17 and newer.
120+
/// Note that you will need to setup ALPN of TLS client configuration to `postgresql` when using direct TLS.
120121
/// If set to `postgres`, the default value, it follows original postgres wire protocol to perform the negotiation.
121122
/// * `hostaddr` - Numeric IP address of host to connect to. This should be in the standard IPv4 address format,
122123
/// e.g., 172.28.40.9. If your machine supports IPv6, you can also use those addresses.

0 commit comments

Comments
 (0)