Skip to content

Commit e212c97

Browse files
committed
fixed conflicting short options for -n in check-cloudwatch-metric.rb
Signed-off-by: Ben Abrams <[email protected]>
1 parent ecbe55e commit e212c97

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ This CHANGELOG follows the format listed at [Keep A Changelog](http://keepachang
77

88
### Fixed
99
- check-cloudwatch-metric.rb, check-cloudwatch-composite-metric.rb: fixed defaults to work (@majormoses)
10+
- check-cloudwatch-metric.rb: short option `-n` was conflicting with `no_data_ok` and `namespace` as `check-cloudwatch-composite-metric.rb` uses `-O` I opted for that for consistency (@majormoses)
1011

1112
### Changed
1213
- check-cloudwatch-metric.rb, check-cloudwatch-composite-metric.rb: `self.parse_dimensions` and `dimension_string` were the same in both checks This fix was common mamong both checks so I moved it into the module

bin/check-cloudwatch-metric.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ class CloudWatchMetricCheck < Sensu::Plugin::Check::CLI
9595
default: 'greater'
9696

9797
option :no_data_ok,
98-
short: '-n',
98+
short: '-O',
9999
long: '--allow-no-data',
100100
description: 'Returns ok if no data is returned from the metric',
101101
boolean: true,

0 commit comments

Comments
 (0)