build: add golangci-lint to circleci config (#907)

Author: dominicbarnes

.circleci/config.yml

@@ -1,5 +1,12 @@
 version: 2
 jobs:
+  lint:
+    docker:
+      - image: golangci/golangci-lint:v1.45-alpine
+    steps:
+      - checkout
+      - run: golangci-lint run
+
   # The kafka 0.10 tests are maintained as a separate configuration because
   # kafka only supported plain text SASL in this version.
   kafka-010:
@@ -287,6 +294,7 @@ workflows:
   version: 2
   run:
     jobs:
+    - lint
     - kafka-010
     - kafka-011
     - kafka-101

.golangci.yml

@@ -0,0 +1,14 @@
+linters:
+  enable:
+    - bodyclose
+    - goconst
+    - godot
+    - gofmt
+    - goimports
+    - prealloc
+
+  disable:
+    # Temporarily disabling so it can be addressed in a dedicated PR.
+    - errcheck
+    - errorlint
+    - goerr113

alterconfigs.go

@@ -9,7 +9,7 @@ import (
 	"github.com/segmentio/kafka-go/protocol/alterconfigs"
 )
 
-// AlterConfigsRequest represents a request sent to a kafka broker to alter configs
+// AlterConfigsRequest represents a request sent to a kafka broker to alter configs.
 type AlterConfigsRequest struct {
 	// Address of the kafka broker to send the request to.
 	Addr net.Addr
@@ -54,7 +54,8 @@ type AlterConfigsResponse struct {
 	Errors map[AlterConfigsResponseResource]error
 }
 
-// AlterConfigsResponseResource
+// AlterConfigsResponseResource helps map errors to specific resources in an
+// alter config response.
 type AlterConfigsResponseResource struct {
 	Type int8
 	Name string

alterconfigs_test.go

@@ -49,6 +49,10 @@ func TestClientAlterConfigs(t *testing.T) {
 		}},
 	})
 
+	if err != nil {
+		t.Fatal(err)
+	}
+
 	maxMessageBytesValue := "0"
 	for _, resource := range describeResp.Resources {
 		if resource.ResourceType == int8(ResourceTypeTopic) && resource.ResourceName == topic {

balancer.go

@@ -126,7 +126,7 @@ var (
 //
 // By default, Hash uses the FNV-1a algorithm.  This is the same algorithm used
 // by the Sarama Producer and ensures that messages produced by kafka-go will
-// be delivered to the same topics that the Sarama producer would be delivered to
+// be delivered to the same topics that the Sarama producer would be delivered to.
 type Hash struct {
 	rr     RoundRobin
 	Hasher hash.Hash32

builder_test.go

@@ -147,7 +147,7 @@ func (f v1MessageSetBuilder) bytes() []byte {
 	})
 	if f.codec != nil {
 		bs = newWB().call(func(wb *kafkaWriteBuffer) {
-			wb.writeInt64(f.msgs[len(f.msgs)-1].Offset)   // offset of the wrapper message is the last offset of the inner messages
+			wb.writeInt64(f.msgs[len(f.msgs)-1].Offset) // offset of the wrapper message is the last offset of the inner messages
 			wb.writeBytes(newWB().call(func(wb *kafkaWriteBuffer) {
 				bs := mustCompress(bs, f.codec)
 				wb.writeInt32(-1)                           // crc, unused
@@ -194,14 +194,14 @@ func (f v2MessageSetBuilder) bytes() []byte {
 				for i, msg := range f.msgs {
 					wb.Write(newWB().call(func(wb *kafkaWriteBuffer) {
 						bs := newWB().call(func(wb *kafkaWriteBuffer) {
-							wb.writeInt8(0)                                               // record attributes, not used here
-							wb.writeVarInt(1000 * (time.Now().Unix() - msg.Time.Unix()))  // timestamp
-							wb.writeVarInt(int64(i))                                      // offset delta
-							wb.writeVarInt(int64(len(msg.Key)))                           // key len
-							wb.Write(msg.Key)                                             // key bytes
-							wb.writeVarInt(int64(len(msg.Value)))                         // value len
-							wb.Write(msg.Value)                                           // value bytes
-							wb.writeVarInt(int64(len(msg.Headers)))                       // number of headers
+							wb.writeInt8(0)                                              // record attributes, not used here
+							wb.writeVarInt(1000 * (time.Now().Unix() - msg.Time.Unix())) // timestamp
+							wb.writeVarInt(int64(i))                                     // offset delta
+							wb.writeVarInt(int64(len(msg.Key)))                          // key len
+							wb.Write(msg.Key)                                            // key bytes
+							wb.writeVarInt(int64(len(msg.Value)))                        // value len
+							wb.Write(msg.Value)                                          // value bytes
+							wb.writeVarInt(int64(len(msg.Headers)))                      // number of headers
 							for _, header := range msg.Headers {
 								wb.writeVarInt(int64(len(header.Key)))
 								wb.Write([]byte(header.Key))
@@ -222,7 +222,7 @@ func (f v2MessageSetBuilder) bytes() []byte {
 	})
 }
 
-// kafkaWriteBuffer is a write buffer that helps writing fetch responses
+// kafkaWriteBuffer is a write buffer that helps writing fetch responses.
 type kafkaWriteBuffer struct {
 	writeBuffer
 	buf bytes.Buffer

compress/compress_test.go

@@ -372,7 +372,7 @@ func BenchmarkCompression(b *testing.B) {
 		benchmark := &benchmarks[i]
 		ratio := 0.0
 
-		b.Run(fmt.Sprintf("%s", benchmark.codec.Name()), func(b *testing.B) {
+		b.Run(benchmark.codec.Name(), func(b *testing.B) {
 			ratio = benchmark.function(b, benchmark.codec, &buffer, payload)
 		})
 

compress/snappy/go-xerial-snappy/snappy.go

@@ -16,19 +16,19 @@ const (
 var (
 	xerialHeader = []byte{130, 83, 78, 65, 80, 80, 89, 0}
 
-	// This is xerial version 1 and minimally compatible with version 1
+	// This is xerial version 1 and minimally compatible with version 1.
 	xerialVersionInfo = []byte{0, 0, 0, 1, 0, 0, 0, 1}
 
 	// ErrMalformed is returned by the decoder when the xerial framing
-	// is malformed
+	// is malformed.
 	ErrMalformed = errors.New("malformed xerial framing")
 )
 
 func min(x, y int) int {
-    if x < y {
-        return x
-    }
-    return y
+	if x < y {
+		return x
+	}
+	return y
 }
 
 // Encode encodes data as snappy with no framing header.
@@ -48,14 +48,14 @@ func EncodeStream(dst, src []byte) []byte {
 
 	// Snappy encode in blocks of maximum 32KB
 	var (
-		max = len(src)
+		max       = len(src)
 		blockSize = 32 * 1024
-		pos   = 0
-		chunk []byte
+		pos       = 0
+		chunk     []byte
 	)
 
 	for pos < max {
-		newPos := min(pos + blockSize, max)
+		newPos := min(pos+blockSize, max)
 		chunk = master.Encode(chunk[:cap(chunk)], src[pos:newPos])
 
 		// First encode the compressed size (big-endian)
@@ -104,7 +104,7 @@ func DecodeInto(dst, src []byte) ([]byte, error) {
 	var (
 		pos   = sizeOffset
 		chunk []byte
-		err       error
+		err   error
 	)
 
 	for pos+sizeBytes <= max {

compress/snappy/go-xerial-snappy/snappy_test.go

@@ -16,17 +16,17 @@ var snappyTestCases = map[string][]byte{
 var snappyStreamTestCases = map[string][]byte{
 	"PLAINDATA":                         {130, 83, 78, 65, 80, 80, 89, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 0, 11, 9, 32, 80, 76, 65, 73, 78, 68, 65, 84, 65},
 	`{"a":"UtaitILHMDAAAAfU","b":"日本"}`: {130, 83, 78, 65, 80, 80, 89, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 0, 39, 37, 144, 123, 34, 97, 34, 58, 34, 85, 116, 97, 105, 116, 73, 76, 72, 77, 68, 65, 65, 65, 65, 102, 85, 34, 44, 34, 98, 34, 58, 34, 230, 151, 165, 230, 156, 172, 34, 125},
-	largeString: {130, 83, 78, 65, 80, 80, 89, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 3, 89, 128, 8, 240, 90, 83, 101, 100, 32, 117, 116, 32, 112, 101, 114, 115, 112, 105, 99, 105, 97, 116, 105, 115, 32, 117, 110, 100, 101, 32, 111, 109, 110, 105, 115, 32, 105, 115, 116, 101, 32, 110, 97, 116, 117, 115, 32, 101, 114, 114, 111, 114, 32, 115, 105, 116, 32, 118, 111, 108, 117, 112, 116, 97, 116, 101, 109, 32, 97, 99, 99, 117, 115, 97, 110, 116, 105, 117, 109, 32, 100, 111, 108, 111, 114, 101, 109, 113, 117, 101, 32, 108, 97, 117, 100, 97, 5, 22, 240, 60, 44, 32, 116, 111, 116, 97, 109, 32, 114, 101, 109, 32, 97, 112, 101, 114, 105, 97, 109, 44, 32, 101, 97, 113, 117, 101, 32, 105, 112, 115, 97, 32, 113, 117, 97, 101, 32, 97, 98, 32, 105, 108, 108, 111, 32, 105, 110, 118, 101, 110, 116, 111, 114, 101, 32, 118, 101, 114, 105, 116, 97, 1, 141, 4, 101, 116, 1, 36, 88, 115, 105, 32, 97, 114, 99, 104, 105, 116, 101, 99, 116, 111, 32, 98, 101, 97, 116, 97, 101, 32, 118, 105, 1, 6, 120, 100, 105, 99, 116, 97, 32, 115, 117, 110, 116, 32, 101, 120, 112, 108, 105, 99, 97, 98, 111, 46, 32, 78, 101, 109, 111, 32, 101, 110, 105, 109, 5, 103, 0, 109, 46, 180, 0, 12, 113, 117, 105, 97, 17, 16, 0, 115, 5, 209, 72, 97, 115, 112, 101, 114, 110, 97, 116, 117, 114, 32, 97, 117, 116, 32, 111, 100, 105, 116, 5, 9, 36, 102, 117, 103, 105, 116, 44, 32, 115, 101, 100, 9, 53, 32, 99, 111, 110, 115, 101, 113, 117, 117, 110, 1, 42, 20, 109, 97, 103, 110, 105, 32, 9, 245, 16, 115, 32, 101, 111, 115, 1, 36, 28, 32, 114, 97, 116, 105, 111, 110, 101, 17, 96, 33, 36, 1, 51, 36, 105, 32, 110, 101, 115, 99, 105, 117, 110, 116, 1, 155, 1, 254, 16, 112, 111, 114, 114, 111, 1, 51, 36, 115, 113, 117, 97, 109, 32, 101, 115, 116, 44, 1, 14, 13, 81, 5, 183, 4, 117, 109, 1, 18, 0, 97, 9, 19, 4, 32, 115, 1, 149, 12, 109, 101, 116, 44, 9, 135, 76, 99, 116, 101, 116, 117, 114, 44, 32, 97, 100, 105, 112, 105, 115, 99, 105, 32, 118, 101, 108, 50, 173, 0, 24, 110, 111, 110, 32, 110, 117, 109, 9, 94, 84, 105, 117, 115, 32, 109, 111, 100, 105, 32, 116, 101, 109, 112, 111, 114, 97, 32, 105, 110, 99, 105, 100, 33, 52, 20, 117, 116, 32, 108, 97, 98, 33, 116, 4, 101, 116, 9, 106, 0, 101, 5, 219, 20, 97, 109, 32, 97, 108, 105, 5, 62, 33, 164, 8, 114, 97, 116, 29, 212, 12, 46, 32, 85, 116, 41, 94, 52, 97, 100, 32, 109, 105, 110, 105, 109, 97, 32, 118, 101, 110, 105, 33, 221, 72, 113, 117, 105, 115, 32, 110, 111, 115, 116, 114, 117, 109, 32, 101, 120, 101, 114, 99, 105, 33, 202, 104, 111, 110, 101, 109, 32, 117, 108, 108, 97, 109, 32, 99, 111, 114, 112, 111, 114, 105, 115, 32, 115, 117, 115, 99, 105, 112, 105, 13, 130, 8, 105, 111, 115, 1, 64, 12, 110, 105, 115, 105, 1, 150, 5, 126, 44, 105, 100, 32, 101, 120, 32, 101, 97, 32, 99, 111, 109, 5, 192, 0, 99, 41, 131, 33, 172, 8, 63, 32, 81, 1, 107, 4, 97, 117, 33, 101, 96, 118, 101, 108, 32, 101, 117, 109, 32, 105, 117, 114, 101, 32, 114, 101, 112, 114, 101, 104, 101, 110, 100, 101, 114, 105, 65, 63, 12, 105, 32, 105, 110, 1, 69, 16, 118, 111, 108, 117, 112, 65, 185, 1, 47, 24, 105, 116, 32, 101, 115, 115, 101, 1, 222, 64, 109, 32, 110, 105, 104, 105, 108, 32, 109, 111, 108, 101, 115, 116, 105, 97, 101, 46, 103, 0, 0, 44, 1, 45, 16, 32, 105, 108, 108, 117, 37, 143, 45, 36, 0, 109, 5, 110, 65, 33, 20, 97, 116, 32, 113, 117, 111, 17, 92, 44, 115, 32, 110, 117, 108, 108, 97, 32, 112, 97, 114, 105, 9, 165, 24, 65, 116, 32, 118, 101, 114, 111, 69, 34, 44, 101, 116, 32, 97, 99, 99, 117, 115, 97, 109, 117, 115, 1, 13, 104, 105, 117, 115, 116, 111, 32, 111, 100, 105, 111, 32, 100, 105, 103, 110, 105, 115, 115, 105, 109, 111, 115, 32, 100, 117, 99, 105, 1, 34, 80, 113, 117, 105, 32, 98, 108, 97, 110, 100, 105, 116, 105, 105, 115, 32, 112, 114, 97, 101, 115, 101, 101, 87, 17, 111, 56, 116, 117, 109, 32, 100, 101, 108, 101, 110, 105, 116, 105, 32, 97, 116, 65, 89, 28, 99, 111, 114, 114, 117, 112, 116, 105, 1, 150, 0, 115, 13, 174, 5, 109, 8, 113, 117, 97, 65, 5, 52, 108, 101, 115, 116, 105, 97, 115, 32, 101, 120, 99, 101, 112, 116, 0, 0, 0, 1, 0},
+	largeString:                         {130, 83, 78, 65, 80, 80, 89, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 3, 89, 128, 8, 240, 90, 83, 101, 100, 32, 117, 116, 32, 112, 101, 114, 115, 112, 105, 99, 105, 97, 116, 105, 115, 32, 117, 110, 100, 101, 32, 111, 109, 110, 105, 115, 32, 105, 115, 116, 101, 32, 110, 97, 116, 117, 115, 32, 101, 114, 114, 111, 114, 32, 115, 105, 116, 32, 118, 111, 108, 117, 112, 116, 97, 116, 101, 109, 32, 97, 99, 99, 117, 115, 97, 110, 116, 105, 117, 109, 32, 100, 111, 108, 111, 114, 101, 109, 113, 117, 101, 32, 108, 97, 117, 100, 97, 5, 22, 240, 60, 44, 32, 116, 111, 116, 97, 109, 32, 114, 101, 109, 32, 97, 112, 101, 114, 105, 97, 109, 44, 32, 101, 97, 113, 117, 101, 32, 105, 112, 115, 97, 32, 113, 117, 97, 101, 32, 97, 98, 32, 105, 108, 108, 111, 32, 105, 110, 118, 101, 110, 116, 111, 114, 101, 32, 118, 101, 114, 105, 116, 97, 1, 141, 4, 101, 116, 1, 36, 88, 115, 105, 32, 97, 114, 99, 104, 105, 116, 101, 99, 116, 111, 32, 98, 101, 97, 116, 97, 101, 32, 118, 105, 1, 6, 120, 100, 105, 99, 116, 97, 32, 115, 117, 110, 116, 32, 101, 120, 112, 108, 105, 99, 97, 98, 111, 46, 32, 78, 101, 109, 111, 32, 101, 110, 105, 109, 5, 103, 0, 109, 46, 180, 0, 12, 113, 117, 105, 97, 17, 16, 0, 115, 5, 209, 72, 97, 115, 112, 101, 114, 110, 97, 116, 117, 114, 32, 97, 117, 116, 32, 111, 100, 105, 116, 5, 9, 36, 102, 117, 103, 105, 116, 44, 32, 115, 101, 100, 9, 53, 32, 99, 111, 110, 115, 101, 113, 117, 117, 110, 1, 42, 20, 109, 97, 103, 110, 105, 32, 9, 245, 16, 115, 32, 101, 111, 115, 1, 36, 28, 32, 114, 97, 116, 105, 111, 110, 101, 17, 96, 33, 36, 1, 51, 36, 105, 32, 110, 101, 115, 99, 105, 117, 110, 116, 1, 155, 1, 254, 16, 112, 111, 114, 114, 111, 1, 51, 36, 115, 113, 117, 97, 109, 32, 101, 115, 116, 44, 1, 14, 13, 81, 5, 183, 4, 117, 109, 1, 18, 0, 97, 9, 19, 4, 32, 115, 1, 149, 12, 109, 101, 116, 44, 9, 135, 76, 99, 116, 101, 116, 117, 114, 44, 32, 97, 100, 105, 112, 105, 115, 99, 105, 32, 118, 101, 108, 50, 173, 0, 24, 110, 111, 110, 32, 110, 117, 109, 9, 94, 84, 105, 117, 115, 32, 109, 111, 100, 105, 32, 116, 101, 109, 112, 111, 114, 97, 32, 105, 110, 99, 105, 100, 33, 52, 20, 117, 116, 32, 108, 97, 98, 33, 116, 4, 101, 116, 9, 106, 0, 101, 5, 219, 20, 97, 109, 32, 97, 108, 105, 5, 62, 33, 164, 8, 114, 97, 116, 29, 212, 12, 46, 32, 85, 116, 41, 94, 52, 97, 100, 32, 109, 105, 110, 105, 109, 97, 32, 118, 101, 110, 105, 33, 221, 72, 113, 117, 105, 115, 32, 110, 111, 115, 116, 114, 117, 109, 32, 101, 120, 101, 114, 99, 105, 33, 202, 104, 111, 110, 101, 109, 32, 117, 108, 108, 97, 109, 32, 99, 111, 114, 112, 111, 114, 105, 115, 32, 115, 117, 115, 99, 105, 112, 105, 13, 130, 8, 105, 111, 115, 1, 64, 12, 110, 105, 115, 105, 1, 150, 5, 126, 44, 105, 100, 32, 101, 120, 32, 101, 97, 32, 99, 111, 109, 5, 192, 0, 99, 41, 131, 33, 172, 8, 63, 32, 81, 1, 107, 4, 97, 117, 33, 101, 96, 118, 101, 108, 32, 101, 117, 109, 32, 105, 117, 114, 101, 32, 114, 101, 112, 114, 101, 104, 101, 110, 100, 101, 114, 105, 65, 63, 12, 105, 32, 105, 110, 1, 69, 16, 118, 111, 108, 117, 112, 65, 185, 1, 47, 24, 105, 116, 32, 101, 115, 115, 101, 1, 222, 64, 109, 32, 110, 105, 104, 105, 108, 32, 109, 111, 108, 101, 115, 116, 105, 97, 101, 46, 103, 0, 0, 44, 1, 45, 16, 32, 105, 108, 108, 117, 37, 143, 45, 36, 0, 109, 5, 110, 65, 33, 20, 97, 116, 32, 113, 117, 111, 17, 92, 44, 115, 32, 110, 117, 108, 108, 97, 32, 112, 97, 114, 105, 9, 165, 24, 65, 116, 32, 118, 101, 114, 111, 69, 34, 44, 101, 116, 32, 97, 99, 99, 117, 115, 97, 109, 117, 115, 1, 13, 104, 105, 117, 115, 116, 111, 32, 111, 100, 105, 111, 32, 100, 105, 103, 110, 105, 115, 115, 105, 109, 111, 115, 32, 100, 117, 99, 105, 1, 34, 80, 113, 117, 105, 32, 98, 108, 97, 110, 100, 105, 116, 105, 105, 115, 32, 112, 114, 97, 101, 115, 101, 101, 87, 17, 111, 56, 116, 117, 109, 32, 100, 101, 108, 101, 110, 105, 116, 105, 32, 97, 116, 65, 89, 28, 99, 111, 114, 114, 117, 112, 116, 105, 1, 150, 0, 115, 13, 174, 5, 109, 8, 113, 117, 97, 65, 5, 52, 108, 101, 115, 116, 105, 97, 115, 32, 101, 120, 99, 101, 112, 116, 0, 0, 0, 1, 0},
 }
 
 func makeMassive(input string, numCopies int) string {
-	outBuff := make([]byte, len(input) * numCopies)
+	outBuff := make([]byte, len(input)*numCopies)
 
-    for i := 0; i < numCopies; i++ {
-        copy(outBuff[len(outBuff):], input)
-    }
+	for i := 0; i < numCopies; i++ {
+		copy(outBuff[len(outBuff):], input)
+	}
 
-    return string(outBuff)
+	return string(outBuff)
 }
 
 func TestSnappyEncode(t *testing.T) {
@@ -39,7 +39,7 @@ func TestSnappyEncode(t *testing.T) {
 }
 
 func TestSnappyEncodeStream(t *testing.T) {
-	for src, _ := range snappyStreamTestCases {
+	for src := range snappyStreamTestCases {
 		dst := EncodeStream(nil, []byte(src))
 
 		// Block size can change the bytes generated, so let's just decode and make sure in matches out
@@ -195,7 +195,7 @@ func BenchmarkSnappyStreamDecodeInto(b *testing.B) {
 	b.ResetTimer()
 
 	var (
-		dst = make([]byte, 1024, 1024)
+		dst = make([]byte, 1024)
 		err error
 	)
 
@@ -236,7 +236,7 @@ func BenchmarkSnappyStreamDecodeIntoMassive(b *testing.B) {
 	b.SetBytes(int64(len(massiveString)))
 
 	var (
-		dst = make([]byte, 1024, 1024)
+		dst = make([]byte, 1024)
 		err error
 	)
 

compress/snappy/xerial_test.go

@@ -6,8 +6,8 @@ import (
 	"io"
 	"testing"
 
-	goxerialsnappy "github.com/segmentio/kafka-go/compress/snappy/go-xerial-snappy"
 	"github.com/klauspost/compress/snappy"
+	goxerialsnappy "github.com/segmentio/kafka-go/compress/snappy/go-xerial-snappy"
 )
 
 // Wrap an io.Reader or io.Writer to disable all copy optimizations like

compression.go

@@ -17,17 +17,11 @@ const (
 
 type CompressionCodec = compress.Codec
 
-// TODO: this file should probably go away once the internals of the package
-// have moved to use the protocol package.
-const (
-	compressionCodecMask = 0x07
-)
-
 var (
 	errUnknownCodec = errors.New("the compression code is invalid or its codec has not been imported")
 )
 
-// resolveCodec looks up a codec by Code()
+// resolveCodec looks up a codec by Code().
 func resolveCodec(code int8) (CompressionCodec, error) {
 	codec := compress.Compression(code).Codec()
 	if codec == nil {

conn.go

@@ -249,7 +249,7 @@ func (c *Conn) Broker() Broker {
 	}
 }
 
-// Controller requests kafka for the current controller and returns its URL
+// Controller requests kafka for the current controller and returns its URL.
 func (c *Conn) Controller() (broker Broker, err error) {
 	err = c.readOperation(
 		func(deadline time.Time, id int32) error {
@@ -276,7 +276,7 @@ func (c *Conn) Controller() (broker Broker, err error) {
 	return broker, err
 }
 
-// Brokers retrieve the broker list from the Kafka metadata
+// Brokers retrieve the broker list from the Kafka metadata.
 func (c *Conn) Brokers() ([]Broker, error) {
 	var brokers []Broker
 	err := c.readOperation(
@@ -1221,12 +1221,6 @@ func (c *Conn) SetRequiredAcks(n int) error {
 	}
 }
 
-func (c *Conn) writeRequestHeader(apiKey apiKey, apiVersion apiVersion, correlationID int32, size int32) {
-	hdr := c.requestHeader(apiKey, apiVersion, correlationID)
-	hdr.Size = (hdr.size() + size) - 4
-	hdr.writeTo(&c.wb)
-}
-
 func (c *Conn) writeRequest(apiKey apiKey, apiVersion apiVersion, correlationID int32, req request) error {
 	hdr := c.requestHeader(apiKey, apiVersion, correlationID)
 	hdr.Size = (hdr.size() + req.size()) - 4