createtopics_test.go

package kafka

import (
	"bufio"
	"bytes"
	"context"
	"errors"
	"net"
	"reflect"
	"strconv"
	"testing"
)

func TestConnCreateTopics(t *testing.T) {
	topic1 := makeTopic()
	topic2 := makeTopic()

	conn, err := DialContext(context.Background(), "tcp", "localhost:9092")
	if err != nil {
		t.Fatal(err)
	}

	defer func() {
		err := conn.Close()
		if err != nil {
			t.Fatalf("failed to close connection: %v", err)
		}
	}()

	controller, _ := conn.Controller()

	controllerConn, err := Dial("tcp", net.JoinHostPort(controller.Host, strconv.Itoa(controller.Port)))
	if err != nil {
		t.Fatal(err)
	}
	defer controllerConn.Close()

	err = controllerConn.CreateTopics(TopicConfig{
		Topic:             topic1,
		NumPartitions:     1,
		ReplicationFactor: 1,
	})
	if err != nil {
		t.Fatalf("unexpected error creating topic: %s", err.Error())
	}

	err = controllerConn.CreateTopics(TopicConfig{
		Topic:             topic1,
		NumPartitions:     1,
		ReplicationFactor: 1,
	})

	// Duplicate topic should not return an error
	if err != nil {
		t.Fatalf("unexpected error creating duplicate topic topic: %v", err)
	}

	err = controllerConn.CreateTopics(
		TopicConfig{
			Topic:             topic1,
			NumPartitions:     1,
			ReplicationFactor: 1,
		},
		TopicConfig{
			Topic:             topic2,
			NumPartitions:     1,
			ReplicationFactor: 1,
		},
		TopicConfig{
			Topic:             topic2,
			NumPartitions:     1,
			ReplicationFactor: 1,
		},
	)

	if err == nil {
		t.Fatal("CreateTopics should have returned an error for invalid requests")
	}

	if !errors.Is(err, InvalidRequest) {
		t.Fatalf("expected invalid request: %v", err)
	}

	deleteTopic(t, topic1)
}

func TestClientCreateTopics(t *testing.T) {
	const (
		topic1 = "client-topic-1"
		topic2 = "client-topic-2"
		topic3 = "client-topic-3"
	)

	client, shutdown := newLocalClient()
	defer shutdown()

	config := []ConfigEntry{{
		ConfigName:  "retention.ms",
		ConfigValue: "3600000",
	}}

	res, err := client.CreateTopics(context.Background(), &CreateTopicsRequest{
		Topics: []TopicConfig{
			{
				Topic:             topic1,
				NumPartitions:     -1,
				ReplicationFactor: -1,
				ReplicaAssignments: []ReplicaAssignment{
					{
						Partition: 0,
						Replicas:  []int{1},
					},
					{
						Partition: 1,
						Replicas:  []int{1},
					},
					{
						Partition: 2,
						Replicas:  []int{1},
					},
				},
				ConfigEntries: config,
			},
			{
				Topic:             topic2,
				NumPartitions:     2,
				ReplicationFactor: 1,
				ConfigEntries:     config,
			},
			{
				Topic:             topic3,
				NumPartitions:     1,
				ReplicationFactor: 1,
				ConfigEntries:     config,
			},
		},
	})
	if err != nil {
		t.Fatal(err)
	}

	defer deleteTopic(t, topic1, topic2, topic3)

	expectTopics := map[string]struct{}{
		topic1: {},
		topic2: {},
		topic3: {},
	}

	for topic, error := range res.Errors {
		delete(expectTopics, topic)

		if error != nil {
			t.Errorf("%s => %s", topic, error)
		}
	}

	for topic := range expectTopics {
		t.Errorf("topic missing in response: %s", topic)
	}
}

func TestCreateTopicsResponse(t *testing.T) {
	supportedVersions := []apiVersion{v0, v1, v2}
	for _, v := range supportedVersions {
		item := createTopicsResponse{
			v: v,
			TopicErrors: []createTopicsResponseTopicError{
				{
					v:         v,
					Topic:     "topic",
					ErrorCode: 2,
				},
			},
		}

		b := bytes.NewBuffer(nil)
		w := &writeBuffer{w: b}
		item.writeTo(w)

		found := createTopicsResponse{v: v}
		remain, err := (&found).readFrom(bufio.NewReader(b), b.Len())
		if err != nil {
			t.Error(err)
			t.FailNow()
		}
		if remain != 0 {
			t.Errorf("expected 0 remain, got %v", remain)
			t.FailNow()
		}
		if !reflect.DeepEqual(item, found) {
			t.Error("expected item and found to be the same")
			t.FailNow()
		}
	}
}