Skip to content

Commit af18f83

Browse files
committed
Merge pull request #320 from segmentio/fix/kahuna
Move push registration to start method
2 parents 31f0f08 + 0cef9ae commit af18f83

File tree

2 files changed

+15
-8
lines changed

2 files changed

+15
-8
lines changed

Analytics.xcodeproj/project.pbxproj

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,8 @@
222222
32F6381C1A8134A600C65643 /* SEGKahunaIntegration.m in Sources */ = {isa = PBXBuildFile; fileRef = 32F6381A1A8134A600C65643 /* SEGKahunaIntegration.m */; };
223223
32F6381D1A8134A600C65643 /* SEGKahunaIntegration.m in Sources */ = {isa = PBXBuildFile; fileRef = 32F6381A1A8134A600C65643 /* SEGKahunaIntegration.m */; };
224224
6182B863DB2D44D1B463AE3B /* libPods-iOS Tests.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 24AE4A015CBF4E95B18D10A7 /* libPods-iOS Tests.a */; };
225+
6E5EF3D31B1005FB001A4BA4 /* CrittercismConfig.h in Headers */ = {isa = PBXBuildFile; fileRef = 6E5EF3D21B1005FB001A4BA4 /* CrittercismConfig.h */; settings = {ATTRIBUTES = (Public, ); }; };
226+
6E5EF3D51B10063E001A4BA4 /* OptimizelyExperimentData.h in Headers */ = {isa = PBXBuildFile; fileRef = 6E5EF3D41B10063E001A4BA4 /* OptimizelyExperimentData.h */; settings = {ATTRIBUTES = (Public, ); }; };
225227
6EB809541AFC135E00959050 /* Amplitude+SSLPinning.h in Headers */ = {isa = PBXBuildFile; fileRef = 6EB809531AFC135E00959050 /* Amplitude+SSLPinning.h */; settings = {ATTRIBUTES = (Public, ); }; };
226228
6EB809561AFC136D00959050 /* AMPURLConnection.h in Headers */ = {isa = PBXBuildFile; fileRef = 6EB809551AFC136D00959050 /* AMPURLConnection.h */; settings = {ATTRIBUTES = (Public, ); }; };
227229
D31C8F7E18A2D83700DA22A6 /* MPNotification.h in Headers */ = {isa = PBXBuildFile; fileRef = D31C8F7D18A2D83700DA22A6 /* MPNotification.h */; settings = {ATTRIBUTES = (Public, ); }; };
@@ -511,6 +513,8 @@
511513
32F9E6B31907300300ED295B /* libPods-AnalyticsTests.a */ = {isa = PBXFileReference; lastKnownFileType = archive.ar; name = "libPods-AnalyticsTests.a"; path = "Pods/build/Debug-iphoneos/libPods-AnalyticsTests.a"; sourceTree = "<group>"; };
512514
32F9E6B61907320700ED295B /* libPods-AnalyticsTests.a */ = {isa = PBXFileReference; lastKnownFileType = archive.ar; name = "libPods-AnalyticsTests.a"; path = "Pods/build/Debug-iphoneos/libPods-AnalyticsTests.a"; sourceTree = "<group>"; };
513515
32F9E6B91907323900ED295B /* libPods-Analytics.a */ = {isa = PBXFileReference; lastKnownFileType = archive.ar; name = "libPods-Analytics.a"; path = "Pods/build/Debug-iphoneos/libPods-Analytics.a"; sourceTree = "<group>"; };
516+
6E5EF3D21B1005FB001A4BA4 /* CrittercismConfig.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = CrittercismConfig.h; path = Pods/CrittercismSDK/CrittercismSDK/CrittercismConfig.h; sourceTree = "<group>"; };
517+
6E5EF3D41B10063E001A4BA4 /* OptimizelyExperimentData.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = OptimizelyExperimentData.h; path = "Pods/Optimizely-iOS-SDK/Optimizely.framework/Headers/OptimizelyExperimentData.h"; sourceTree = "<group>"; };
514518
6EB809531AFC135E00959050 /* Amplitude+SSLPinning.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = "Amplitude+SSLPinning.h"; path = "Pods/Amplitude-iOS/Amplitude/Amplitude+SSLPinning.h"; sourceTree = "<group>"; };
515519
6EB809551AFC136D00959050 /* AMPURLConnection.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = AMPURLConnection.h; path = "Pods/Amplitude-iOS/Amplitude/AMPURLConnection.h"; sourceTree = "<group>"; };
516520
70B38155D048462482A91850 /* libPods.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = libPods.a; sourceTree = BUILT_PRODUCTS_DIR; };
@@ -736,6 +740,8 @@
736740
D3D35174186242B4005586E7 /* Headers */ = {
737741
isa = PBXGroup;
738742
children = (
743+
6E5EF3D41B10063E001A4BA4 /* OptimizelyExperimentData.h */,
744+
6E5EF3D21B1005FB001A4BA4 /* CrittercismConfig.h */,
739745
6EB809551AFC136D00959050 /* AMPURLConnection.h */,
740746
6EB809531AFC135E00959050 /* Amplitude+SSLPinning.h */,
741747
32AFA6171A9E98CF00C2AF3E /* Localytics.h */,
@@ -1230,6 +1236,7 @@
12301236
3252EA581999D5CF0056C32A /* TAGDataLayer.h in Headers */,
12311237
3252EA591999D5CF0056C32A /* TAGLogger.h in Headers */,
12321238
3252EA5A1999D5CF0056C32A /* TAGManager.h in Headers */,
1239+
6E5EF3D31B1005FB001A4BA4 /* CrittercismConfig.h in Headers */,
12331240
D331BCF2185BFF49007CB22F /* CRFilter.h in Headers */,
12341241
D331BCF3185BFF4A007CB22F /* CrittercismDelegate.h in Headers */,
12351242
3252EA431999D5780056C32A /* GAIDictionaryBuilder.h in Headers */,
@@ -1369,6 +1376,7 @@
13691376
D331BD321860F5F0007CB22F /* TSHelpers.h in Headers */,
13701377
3252EA7A1999D6390056C32A /* QuantcastDataManager.h in Headers */,
13711378
3252EA7B1999D6390056C32A /* QuantcastDatabase.h in Headers */,
1379+
6E5EF3D51B10063E001A4BA4 /* OptimizelyExperimentData.h in Headers */,
13721380
3252EA7C1999D6390056C32A /* QuantcastEvent.h in Headers */,
13731381
3252EA7D1999D6390056C32A /* QuantcastEventLogger.h in Headers */,
13741382
3252EA7E1999D6390056C32A /* QuantcastMeasurement.h in Headers */,

Analytics/Integrations/Kahuna/SEGKahunaIntegration.m

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,6 @@ @implementation SEGKahunaIntegration
4545

4646
+ (void)load {
4747
[SEGAnalytics registerIntegration:self withIdentifier:@"Kahuna"];
48-
49-
// When this class loads we will register for the 'UIApplicationDidFinishLaunchingNotification' notification.
50-
// To receive the notification we will use the SEGKahunaPushMonitor singleton instance.
51-
[[NSNotificationCenter defaultCenter] addObserver:[SEGKahunaPushMonitor sharedInstance]
52-
selector:@selector(didFinishLaunching:)
53-
name:UIApplicationDidFinishLaunchingNotification
54-
object:nil];
55-
5648
}
5749

5850
- (id)init {
@@ -90,6 +82,13 @@ - (void)start {
9082
}
9183
}
9284

85+
// When this class loads we will register for the 'UIApplicationDidFinishLaunchingNotification' notification.
86+
// To receive the notification we will use the SEGKahunaPushMonitor singleton instance.
87+
[[NSNotificationCenter defaultCenter] addObserver:[SEGKahunaPushMonitor sharedInstance]
88+
selector:@selector(didFinishLaunching:)
89+
name:UIApplicationDidFinishLaunchingNotification
90+
object:nil];
91+
9392
[super start];
9493
}
9594

0 commit comments

Comments
 (0)