Fix ll.ListReplaceList off-by-one error in SLua

Author: HaroldCindy

VM/src/lll.cpp

@@ -577,8 +577,9 @@ static int ll_listreplacelist(lua_State *L)
     luaL_checktype(L, 1, LUA_TTABLE);
     luaL_checktype(L, 2, LUA_TTABLE);
     int orig_len = lua_objlen(L, 1);
+    bool compat_mode = lua_toboolean(L, lua_upvalueindex(1));
     // Let llDeleteSubList handle the tricky part.
-    lua_pushboolean(L, true);
+    lua_pushboolean(L, compat_mode);
     lua_pushcclosurek(L, ll_deletesublist, "DeleteSubList", 1, nullptr);
     lua_pushvalue(L, 1);
     lua_pushvalue(L, 3);
@@ -593,8 +594,6 @@ static int ll_listreplacelist(lua_State *L)
     auto *src_h = hvalue(luaA_toobject(L, 2));
     int src_len = luaH_getn(src_h);
 
-    bool compat_mode = lua_toboolean(L, lua_upvalueindex(1));
-
     int target = _checkobjectindex(L, orig_len, 3, compat_mode);
 
     LuaTable *cloned_h = nullptr;

tests/conformance/llcompat.lua

@@ -12,4 +12,17 @@ assert(llcompat.List2Float(foo, 1) == 2)
 assert(llcompat.List2Float(foo, -1) == 3)
 assert(llcompat.List2Integer(foo, 0) == 1)
 
+-- ll.ListReplaceList uses 1-based indices
+local t = {"a", "b", "c", "d"}
+assert(lljson.encode(ll.ListReplaceList(t, {"x"}, 2, 2)) == '["a","x","c","d"]')
+assert(lljson.encode(ll.ListReplaceList(t, {"x", "y"}, 2, 3)) == '["a","x","y","d"]')
+assert(lljson.encode(ll.ListReplaceList(t, {"x"}, 1, 1)) == '["x","b","c","d"]')
+assert(lljson.encode(ll.ListReplaceList(t, {"x"}, -1, -1)) == '["a","b","c","x"]')
+assert(lljson.encode(ll.ListReplaceList(t, {"x"}, 1, -1)) == '["x"]')
+
+-- llcompat.ListReplaceList uses 0-based indices
+assert(lljson.encode(llcompat.ListReplaceList(t, {"x"}, 1, 1)) == '["a","x","c","d"]')
+assert(lljson.encode(llcompat.ListReplaceList(t, {"x"}, 0, 0)) == '["x","b","c","d"]')
+assert(lljson.encode(llcompat.ListReplaceList(t, {"x"}, -1, -1)) == '["a","b","c","x"]')
+
 return 'OK'