Review

Author: HaraldPfirmann

ActiveDirectory/Common/Move-ADObject.ps1

@@ -23,7 +23,7 @@
         
     .Parameter TargetOUPath
         [sr-en] Specifies the new location for the object
-        [sr-de] Pfad der neuen OU für das  Objekt
+        [sr-de] Pfad der neuen OU für das Objekt
 
     .Parameter ObjectName
         [sr-en] DistinguishedName or GUID of the Active Directory object

ActiveDirectory/Computers/Get-ADComputerProperties.ps1

@@ -1,4 +1,4 @@
-#Requires -Version 4.0
+#Requires -Version 5.0
 #Requires -Modules ActiveDirectory
 
 <#
@@ -47,7 +47,7 @@
     
     .Parameter AuthType
         Specifies the authentication method to use
-        [sr-de] Gibt die zu verwendende Authentifizierungsmethode an#>
+        [sr-de] Gibt die zu verwendende Authentifizierungsmethode an
 #>
 
 param(    

ActiveDirectory/Computers/Get-ADComputersWithDefinedStatus.ps1

@@ -1,4 +1,4 @@
-#Requires -Version 4.0
+#Requires -Version 5.0
 #Requires -Modules ActiveDirectory
 
 <#
@@ -47,7 +47,7 @@
     
     .Parameter AuthType
         Specifies the authentication method to use
-        [sr-de] Gibt die zu verwendende Authentifizierungsmethode an#>
+        [sr-de] Gibt die zu verwendende Authentifizierungsmethode an
 #>
 
 param(

ActiveDirectory/Computers/Remove-ADComputer.ps1

@@ -1,4 +1,4 @@
-#Requires -Version 4.0
+#Requires -Version 5.0
 #Requires -Modules ActiveDirectory
 
 <#
@@ -101,7 +101,7 @@ try{
     if($null -ne $DomainAccount){
         $cmdArgs.Add("Credential", $DomainAccount)
     }
-    $Cmp= Get-ADComputer  @cmdArgs   
+    $Cmp = Get-ADComputer @cmdArgs   
 
     $Script:res
     if($null -ne $Cmp){

ActiveDirectory/Computers/Remove-ADComputersFromGroup.ps1

@@ -21,7 +21,6 @@
     .LINK
         https://github.com/scriptrunner/ActionPacks/tree/master/ActiveDirectory/Computers
 
-
     .Parameter OUPath
         [sr-en] Specifies the AD path
         [sr-de] Active Directory Pfad

ActiveDirectory/Computers/Set-ADComputerProperties.ps1

@@ -1,4 +1,4 @@
-#Requires -Version 4.0
+#Requires -Version 5.0
 #Requires -Modules ActiveDirectory
 
 <#
@@ -84,7 +84,7 @@
     
     .Parameter AuthType
         Specifies the authentication method to use
-        [sr-de] Gibt die zu verwendende Authentifizierungsmethode an#>
+        [sr-de] Gibt die zu verwendende Authentifizierungsmethode an
 #>
 
 param(
@@ -239,7 +239,7 @@ try{
         if($SRXEnv) {
             $SRXEnv.ResultMessage = "Computer $($Computername) not found"
         }
-        Throw "Computer $($Computername) not found"
+        throw "Computer $($Computername) not found"
     }   
 }
 catch{

ActiveDirectory/Computers/Set-ADComputerStatus.ps1

@@ -1,4 +1,4 @@
-#Requires -Version 4.0
+#Requires -Version 5.0
 #Requires -Modules ActiveDirectory
 
 <#
@@ -47,7 +47,7 @@
     
     .Parameter AuthType
         Specifies the authentication method to use
-        [sr-de] Gibt die zu verwendende Authentifizierungsmethode an#>
+        [sr-de] Gibt die zu verwendende Authentifizierungsmethode an
 #>
 
 param(

ActiveDirectory/Groups/Get-ADEmptyGroups.ps1

@@ -1,4 +1,4 @@
-#Requires -Version 4.0
+#Requires -Version 5.0
 #Requires -Modules ActiveDirectory
 
 <#
@@ -96,7 +96,7 @@ try{
     if($null -ne $Script:Res){ 
         $resultMessage = @()
         foreach($itm in $Script:Res){
-            $resultMessage = $resultMessage + ($itm.DistinguishedName + ';' +$itm.SamAccountName)
+            $resultMessage += ($itm.DistinguishedName + ';' +$itm.SamAccountName)
         }
         if($SRXEnv) {
             $SRXEnv.ResultMessage = $resultMessage 

ActiveDirectory/Groups/Get-ADGroupMembers.ps1

@@ -1,4 +1,4 @@
-#Requires -Version 4.0
+#Requires -Version 5.0
 #Requires -Modules ActiveDirectory
 
 <#
@@ -51,7 +51,7 @@
     
     .Parameter AuthType
         Specifies the authentication method to use
-        [sr-de] Gibt die zu verwendende Authentifizierungsmethode an#>
+        [sr-de] Gibt die zu verwendende Authentifizierungsmethode an
 #>
 
 param(
@@ -158,7 +158,7 @@ try{
         if($SRXEnv) {
             $SRXEnv.ResultMessage = "Group $($GroupName) not found"
         }    
-        Throw "Group $($GroupName) not found"
+        throw "Group $($GroupName) not found"
     }   
 }
 catch{

ActiveDirectory/Groups/Get-ADGroupProperties.ps1

@@ -1,4 +1,4 @@
-#Requires -Version 4.0
+#Requires -Version 5.0
 #Requires -Modules ActiveDirectory
 
 <#
@@ -134,7 +134,7 @@ try{
         if($SRXEnv) {
             $SRXEnv.ResultMessage = "Group $($GroupName) not found"
         }    
-        Throw "Group $($GroupName) not found"
+        throw "Group $($GroupName) not found"
     }   
 }
 catch{