Skip to content

fix: align query context handling with database/sql practices #14

@murfffi

Description

@murfffi

There are at least two places where the context handing in the QueryContext path seems suspicious.
Both fetchfn and closefn are tied to the original QueryContext which seems inconsistent with the wrapper code in database/sql (sql.go). Especially, for closefn, this likely means that an query operation can't be closed if the parent context is cancelled.

Review how other more popular drivers handle it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions