Merge pull request #164 from patw0929/feature/remove-override-createjsmodules

koenpunt · web-flow · commit b3fe6c098013 · 2017-08-19T18:29:18.000+02:00
Removed override notation for deprecated method (createJSModules) of React Native 0.47.0
diff --git a/android/src/main/java/com/sbugert/rnadmob/RNAdMobPackage.java b/android/src/main/java/com/sbugert/rnadmob/RNAdMobPackage.java
@@ -21,7 +21,7 @@ public List<NativeModule> createNativeModules(ReactApplicationContext reactConte
         );
     }
 
-    @Override
+    // Deprecated from RN 0.47.0
     public List<Class<? extends JavaScriptModule>> createJSModules() {
         return Collections.emptyList();
     }

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ public List<NativeModule> createNativeModules(ReactApplicationContext reactConte`
`21`	`21`	`);`
`22`	`22`	`}`
`23`	`23`
`24`		`- @Override`
	`24`	`+ // Deprecated from RN 0.47.0`
`25`	`25`	`public List<Class<? extends JavaScriptModule>> createJSModules() {`
`26`	`26`	`return Collections.emptyList();`
`27`	`27`	`}`