collection: Major rework in preparation for 1.0.0 release

[marcelmamula]

Scope

This collection requires bump up to 1.0.0 release, but it will require some major rework to ensure that:

• Code quality is improved.
• Hardcoded content is removed.
• Missing validations, conditions and asserts are added.
• Obsolete roles and modules are removed.
• Resolve linting errors and wrong variable names

Roles

Role	Status	Plan
os_ansible_user	WIP #43	Remove role as it is not SAP specific.
os_etchosts	WIP #43	Remove role as it is not SAP specific. Alternative
os_knownhosts	WIP #43	Remove role as it is not SAP specific. Alternative
sap_control	TODO	Major rework is required - More info below
sap_fapolicy	WIP #44	More info below
sap_firewall	TODO	Remove role as SAP specific setup is done in sap_install collection or Alternative
sap_hana_backint	TODO	Major rework is required - More info below
sap_hana_sr_takeover	TODO	Add validations and improve code quality along with comments and documentation
sap_profile_update	TODO	Add validations and improve code quality along with comments and documentation
sap_rfc	TODO	Major rework is required - More info below
sap_rhsm	WIP #44	More info below

sap_control

• Remove all sap_control commands and replace them with call to community.sap_libs.sap_control_exec.
• Role should act as wrapper with predefined functions only.
• Add functionality from current sap_operations/plugins/modules as new functions in role.
• Add validations and improve code quality along with comments and documentation.

sap_fapolicy and sap_rhsm

• Ensure that it runs only on Red Hat.
• Add validations and improve code quality along with comments and documentation.
• sap_rhsm can be decommissioned because https://github.com/linux-system-roles/rhc exists.

sap_hana_backint

• Remove all hardcoded pythons
• Remove all unsecure downloads of unverified files that could leak to security issues!
• Add validations and improve code quality along with comments and documentation.

sap_rfc

• Remove all hardcoded pythons
• Completely redo hardcoded VENV setup, packages, SAP package and touching LD...
• Add validations and improve code quality along with comments and documentation.

Modules

Remove all modules and repoint to sap_libs.sap_system_facts where current sap_operations.sap_facts is used.