Playbook fails despite successful SAP request execution using sap_pyrfc module

[wendelsilva]

Summary

I'm using the community.sap_libs.sap_pyrfc module to create requisitions in SAP. All RFC and connection parameters are correctly configured, and the requisition is successfully created in the SAP system. However, the playbook execution still returns a failed status, even though SAP processes the request successfully.

This behavior causes issues in our automation pipeline since the task is marked as failed, even when the desired result is achieved in SAP.

module_stdout: ''
  module_stderr: >
    Traceback (most recent call last):
      File "/root/.ansible/tmp/ansible-tmp-1744724504.5124443-67-11446826847753/AnsiballZ_sap_pyrfc.py", line 107, in <module>
        _ansiballz_main()
      File "/root/.ansible/tmp/ansible-tmp-1744724504.5124443-67-11446826847753/AnsiballZ_sap_pyrfc.py", line 99, in _ansiballz_main
        invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
      File "/root/.ansible/tmp/ansible-tmp-1744724504.5124443-67-11446826847753/AnsiballZ_sap_pyrfc.py", line 47, in invoke_module
        runpy.run_module(mod_name='ansible_collections.community.sap_libs.plugins.modules.sap_pyrfc', init_globals=dict(_module_fqn='ansible_collections.community.sap_libs.plugins.modules.sap_pyrfc', _modlib_path=modlib_path),
      File "/usr/lib64/python3.9/runpy.py", line 225, in run_module
        return _run_module_code(code, init_globals, run_name, mod_spec)
      File "/usr/lib64/python3.9/runpy.py", line 97, in _run_module_code
        _run_code(code, mod_globals, init_globals,
      File "/usr/lib64/python3.9/runpy.py", line 87, in _run_code
        exec(code, run_globals)
      File "ansible_collections/community/sap_libs/plugins/modules/sap_pyrfc.py", line 187, in <module>
      File "ansible_collections/community/sap_libs/plugins/modules/sap_pyrfc.py", line 183, in main
      File "ansible/module_utils/basic.py", line 1553, in fail_json
      File "ansible/module_utils/basic.py", line 1522, in _return_formatted
      File "ansible/module_utils/common/parameters.py", line 927, in remove_values
      File "ansible/module_utils/common/parameters.py", line 470, in _remove_values_conditions
    TypeError: Value of unknown type: <class 'decimal.InvalidOperation'>,
    [<class 'decimal.ConversionSyntax'>]

Issue Type

Bug Report

Component Name

community.sap_libs.sap_pyrfc

Ansible Version

$ ansible --version 
2.18

community.sap_libs Version

$ ansible-galaxy collection list community.sap_libs

community.sap_libs:1.4.2

Configuration

$ ansible-config dump --only-changed

OS / Environment

No response

Steps to Reproduce

Expected Results

Expected the number of the requisition created in SAP

Actual Results

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[sean-freeman]

@wendelsilva First of all, without any sample we cannot reproduce and it would be impossible to debug a TypeError for a return payload without the reproduction.

Secondly, there is not much we can do here:

• How to replace pyrfc requirement ?? #46
• Call for Maintainers & Support SAP-archive/PyRFC#372

[wendelsilva]

This is my playbook

- name: test the pyrfc module
  community.sap_libs.sap_pyrfc:
    function: BAPI_REQUISITION_CREATE
    parameters:
      REQUISITION_ITEMS:
        - PLANT: "0001"
          MATERIAL: "000000000000000003"
          QUANTITY: "1.0"
          C_AMT_BAPI: "320.0"
          PRICE_UNIT: "1.0"
          CURRENCY: "BRL"
          CURRENCY_ISO: "BRL"
          "DOC_TYPE": "NB"
          "PUR_GROUP": "130"
          "DELIV_DATE": "20250410"
          "PREQ_NAME": "Pacco"
    connection:
      ashost: "{{ ashost }}"
      sysnr: "{{ sysnr }}"
      sysid: "{{ sysid }}"
      client: "{{ client }}"
      user: "{{ user }}"
      passwd: "{{ passwd }}"
      lang: PT
  register: SAP_RC
  ignore_errors: true

[kksat]

@sean-freeman my understanding that the issue here is that ansible does not support decimal type, but pyrfc does support decimal and some values are returned as decimal. These values should be converted by the module before returning to ansible.

See for instance https://github.com/redhat-sap/rh_operations/blob/f9596b8af0a0a97e632af6e82cc5f8f1b07a7b7a/plugins/module_utils/abap.py#L948

how I solved it for sap.sap_operations