Add pattern matching in function header

Author: IvanIvanoff

lib/sanbase/alerts/trigger/settings/screener_trigger_settings.ex

@@ -91,12 +91,11 @@ defmodule Sanbase.Alert.Trigger.ScreenerTriggerSettings do
     end
   end
 
-  defp fill_current_state(trigger) do
-    %{settings: settings} = trigger
+  defp fill_current_state(%Sanbase.Alert.Trigger{} = trigger) do
+    %{settings: %ScreenerTriggerSettings{} = settings} = trigger
 
     with {:ok, slugs} <- get_data(settings) do
       settings = %{settings | state: %{slugs_in_screener: slugs}}
-
       trigger = %{trigger | settings: settings}
       {:ok, trigger}
     end

lib/sanbase/alerts/trigger/settings/trending_words_trigger_settings.ex

@@ -100,7 +100,9 @@ defmodule Sanbase.Alert.Trigger.TrendingWordsTriggerSettings do
 
     defp build_result(
            top_words,
-           %{operation: %{send_at_predefined_time: true, trigger_time: trigger_time}} = settings
+           %TrendingWordsTriggerSettings{
+             operation: %{send_at_predefined_time: true, trigger_time: trigger_time}
+           } = settings
          ) do
       trigger_time = Sanbase.DateTimeUtils.time_from_iso8601!(trigger_time)
       now = Time.utc_now()
@@ -121,7 +123,10 @@ defmodule Sanbase.Alert.Trigger.TrendingWordsTriggerSettings do
 
     defp build_result(
            top_words,
-           %{operation: %{trending_word: true}, filtered_target: %{list: words}} = settings
+           %TrendingWordsTriggerSettings{
+             operation: %{trending_word: true},
+             filtered_target: %{list: words}
+           } = settings
          ) do
       top_words = top_words |> Enum.map(&String.downcase(&1.word))
 
@@ -144,7 +149,10 @@ defmodule Sanbase.Alert.Trigger.TrendingWordsTriggerSettings do
 
     defp build_result(
            top_words,
-           %{operation: %{trending_project: true}, filtered_target: %{list: slugs}} = settings
+           %TrendingWordsTriggerSettings{
+             operation: %{trending_project: true},
+             filtered_target: %{list: slugs}
+           } = settings
          ) do
       projects = Project.List.by_slugs(slugs)
 
@@ -183,7 +191,9 @@ defmodule Sanbase.Alert.Trigger.TrendingWordsTriggerSettings do
     end
 
     defp template_kv(
-           %{operation: %{send_at_predefined_time: true, trigger_time: trigger_time}} = settings,
+           %TrendingWordsTriggerSettings{
+             operation: %{send_at_predefined_time: true, trigger_time: trigger_time}
+           } = settings,
            top_words
          ) do
       max_len = get_max_len(top_words)
@@ -221,7 +231,10 @@ defmodule Sanbase.Alert.Trigger.TrendingWordsTriggerSettings do
       |> maybe_extend_with_explanation(settings)
     end
 
-    defp template_kv(%{operation: %{trending_word: true}} = settings, [word]) do
+    defp template_kv(
+           %TrendingWordsTriggerSettings{operation: %{trending_word: true}} = settings,
+           [word]
+         ) do
       kv = %{
         type: TrendingWordsTriggerSettings.type(),
         operation: settings.operation,
@@ -239,7 +252,10 @@ defmodule Sanbase.Alert.Trigger.TrendingWordsTriggerSettings do
       |> maybe_extend_with_explanation(settings)
     end
 
-    defp template_kv(%{operation: %{trending_word: true}} = settings, [_, _ | _] = words) do
+    defp template_kv(
+           %TrendingWordsTriggerSettings{operation: %{trending_word: true}} = settings,
+           [_, _ | _] = words
+         ) do
       {last, previous} = List.pop_at(words, -1)
       words_str = (Enum.map(previous, &"**#{&1}**") |> Enum.join(",")) <> " and **#{last}**"
 
@@ -260,7 +276,10 @@ defmodule Sanbase.Alert.Trigger.TrendingWordsTriggerSettings do
       |> maybe_extend_with_explanation(settings)
     end
 
-    defp template_kv(%{operation: %{trending_project: true}} = settings, project) do
+    defp template_kv(
+           %TrendingWordsTriggerSettings{operation: %{trending_project: true}} = settings,
+           project
+         ) do
       kv = %{
         type: TrendingWordsTriggerSettings.type(),
         operation: settings.operation,
@@ -304,7 +323,7 @@ defmodule Sanbase.Alert.Trigger.TrendingWordsTriggerSettings do
       {template, kv}
     end
 
-    defp maybe_extend_with_explanation({template, kv}, settings) do
+    defp maybe_extend_with_explanation({template, kv}, %TrendingWordsTriggerSettings{} = settings) do
       default_explanation =
         case settings.include_default_explanation do
           true -> @default_explanation

lib/sanbase/alerts/trigger/settings/wallet/wallet_assets_held_trigger_settings.ex

@@ -58,11 +58,11 @@ defmodule Sanbase.Alert.Trigger.WalletAssetsHeldTriggerSettings do
   @spec type() :: String.t()
   def type(), do: @trigger_type
 
-  def post_create_process(trigger), do: fill_current_state(trigger)
-  def post_update_process(trigger), do: fill_current_state(trigger)
+  def post_create_process(%Sanbase.Alert.Trigger{} = trigger), do: fill_current_state(trigger)
+  def post_update_process(%Sanbase.Alert.Trigger{} = trigger), do: fill_current_state(trigger)
 
-  defp fill_current_state(trigger) do
-    %{settings: settings} = trigger
+  defp fill_current_state(%Sanbase.Alert.Trigger{} = trigger) do
+    %{settings: %WalletAssetsHeldTriggerSettings{} = settings} = trigger
 
     temp_settings =
       Map.put(settings, :filtered_target, Sanbase.Alert.Trigger.get_filtered_target(trigger))
@@ -80,7 +80,7 @@ defmodule Sanbase.Alert.Trigger.WalletAssetsHeldTriggerSettings do
   @doc ~s"""
   Return a list of the `settings.metric` values for the necessary time range
   """
-  def get_data(%__MODULE__{
+  def get_data(%WalletAssetsHeldTriggerSettings{
         filtered_target: %{list: target_list},
         selector: selector
       }) do
@@ -109,7 +109,7 @@ defmodule Sanbase.Alert.Trigger.WalletAssetsHeldTriggerSettings do
     {:ok, data}
   end
 
-  defp assets_held(selector) do
+  defp assets_held(%{} = selector) do
     cache_key =
       {__MODULE__, :assets_held, selector, round_datetime(DateTime.utc_now())}
       |> Sanbase.Cache.hash()
@@ -167,7 +167,7 @@ defmodule Sanbase.Alert.Trigger.WalletAssetsHeldTriggerSettings do
       ])
     end
 
-    defp template_kv(values, settings) do
+    defp template_kv(values, %WalletAssetsHeldTriggerSettings{} = settings) do
       %{added_slugs: added_slugs, removed_slugs: removed_slugs} = values
 
       kv = %{

lib/sanbase/external_services/etherscan/scraper.ex

@@ -2,9 +2,7 @@ defmodule Sanbase.ExternalServices.Etherscan.Scraper do
   # credo:disable-for-this-file
   use Tesla
 
-  alias Decimal, as: D
   alias Sanbase.ExternalServices.RateLimiting
-  alias Sanbase.ExternalServices.ProjectInfo
   alias Sanbase.ExternalServices.ErrorCatcher
 
   require Logger
@@ -131,8 +129,8 @@ defmodule Sanbase.ExternalServices.Etherscan.Scraper do
       match ->
         Floki.text(match)
         |> parse_total_supply()
-        |> D.round()
-        |> D.to_integer()
+        |> Decimal.round()
+        |> Decimal.to_integer()
     end
   end
 
@@ -171,6 +169,6 @@ defmodule Sanbase.ExternalServices.Etherscan.Scraper do
     |> String.split()
     |> Enum.find(fn x -> String.starts_with?(x, "Supply") end)
     |> (fn supply -> String.trim(supply, "Supply:") end).()
-    |> D.new()
+    |> Decimal.new()
   end
 end

lib/sanbase/external_services/project_info.ex

@@ -70,7 +70,7 @@ defmodule Sanbase.ExternalServices.ProjectInfo do
     missing_values? or !Project.has_contract_address?(project)
   end
 
-  def from_project(project) do
+  def from_project(%Project{} = project) do
     project_info =
       struct(__MODULE__, Map.to_list(project))
       |> struct(Map.to_list(find_or_create_initial_ico(project)))
@@ -140,7 +140,7 @@ defmodule Sanbase.ExternalServices.ProjectInfo do
   end
 
   defp maybe_add_contract_address(
-         project,
+         %Project{} = project,
          %{main_contract_address: contract_address} = project_info_map
        )
        when is_binary(contract_address) do
@@ -161,9 +161,9 @@ defmodule Sanbase.ExternalServices.ProjectInfo do
     Repo.preload(project, [:contract_addresses], force: true)
   end
 
-  defp maybe_add_contract_address(project, _project_info_map), do: project
+  defp maybe_add_contract_address(%Project{} = project, _project_info_map), do: project
 
-  defp insert_tag({:ok, project}, project_info) do
+  defp insert_tag({:ok, %Project{} = project}, %ProjectInfo{} = project_info) do
     do_insert_tag(project, project_info)
     {:ok, project}
   end
@@ -188,7 +188,7 @@ defmodule Sanbase.ExternalServices.ProjectInfo do
 
   defp do_insert_tag(_, _), do: :ok
 
-  defp find_or_create_initial_ico(project) do
+  defp find_or_create_initial_ico(%Project{} = project) do
     case Project.initial_ico(project) do
       nil -> %Ico{project_id: project.id}
       ico -> ico

lib/sanbase_web/graphql/middlewares/access_control/access_control.ex

@@ -138,11 +138,11 @@ defmodule SanbaseWeb.Graphql.Middlewares.AccessControl do
 
   # The auth method is not `basic` and the slug is not one of the freely available slugs
   # all of the required checks are done
-  defp check_has_access(resolution, opts) do
+  defp check_has_access(%Resolution{} = resolution, opts) do
     full_check_has_access(resolution, opts)
   end
 
-  defp full_check_has_access(resolution, opts) do
+  defp full_check_has_access(%Resolution{} = resolution, opts) do
     resolution
     |> apply_if_not_resolved(&check_experimental_metric_access/1)
     |> apply_if_not_resolved(&check_plan_has_access/1)
@@ -161,7 +161,7 @@ defmodule SanbaseWeb.Graphql.Middlewares.AccessControl do
     resolution
   end
 
-  defp apply_if_not_resolved(resolution, fun) do
+  defp apply_if_not_resolved(%Resolution{} = resolution, fun) do
     fun.(resolution)
   end
 
@@ -183,7 +183,7 @@ defmodule SanbaseWeb.Graphql.Middlewares.AccessControl do
 
   defp check_experimental_metric_access(%Resolution{} = resolution), do: resolution
 
-  defp do_check_experimental_metric(current_user, metric, resolution) do
+  defp do_check_experimental_metric(current_user, metric, %Resolution{} = resolution) do
     if user_can_access_metric?(current_user, metric.status) do
       resolution
     else
@@ -223,7 +223,7 @@ defmodule SanbaseWeb.Graphql.Middlewares.AccessControl do
   #
   # The shared access token is checked first and if it gives access to the
   # request, the user plan access is bypassed
-  defp check_plan_has_access(resolution) do
+  defp check_plan_has_access(%Resolution{} = resolution) do
     case check_shared_access_token_has_access?(resolution) do
       true -> resolution
       false -> check_user_plan_has_access(resolution)
@@ -299,7 +299,7 @@ defmodule SanbaseWeb.Graphql.Middlewares.AccessControl do
 
   # If the query is marked as having free realtime and historical data
   # do not restrict anything
-  defp maybe_apply_restrictions(resolution, %{
+  defp maybe_apply_restrictions(%Resolution{} = resolution, %{
          allow_realtime_data: true,
          allow_historical_data: true
        }) do
@@ -322,11 +322,11 @@ defmodule SanbaseWeb.Graphql.Middlewares.AccessControl do
     end
   end
 
-  defp maybe_apply_restrictions(resolution, _) do
+  defp maybe_apply_restrictions(%Resolution{} = resolution, _) do
     resolution
   end
 
-  defp restricted_query(resolution, middleware_args, query_or_argument) do
+  defp restricted_query(%Resolution{} = resolution, middleware_args, query_or_argument) do
     args =
       case restricted_query_shared_access_token(
              resolution,
@@ -383,7 +383,7 @@ defmodule SanbaseWeb.Graphql.Middlewares.AccessControl do
     }
   end
 
-  defp restricted_query_shared_access_token(_, _, _), do: nil
+  defp restricted_query_shared_access_token(%Resolution{} = _, _, _), do: nil
 
   defp restricted_query_user_plan(
          %Resolution{arguments: %{from: from, to: to}, context: context},
@@ -440,7 +440,7 @@ defmodule SanbaseWeb.Graphql.Middlewares.AccessControl do
     end
   end
 
-  defp not_restricted_query(resolution, _middleware_args) do
+  defp not_restricted_query(%Resolution{} = resolution, _middleware_args) do
     resolution
   end
 

lib/sanbase_web/graphql/middlewares/transform_resolution.ex

@@ -16,28 +16,28 @@ defmodule SanbaseWeb.Graphql.Middlewares.TransformResolution do
     |> do_call(resolution)
   end
 
-  defp do_call(:get_metric, %{context: context} = resolution) do
+  defp do_call(:get_metric, %Resolution{context: context} = resolution) do
     %{arguments: %{metric: metric}} = resolution
     selectors = get_selectors(resolution)
     elem = {:get_metric, metric, selectors}
 
     %{resolution | context: Map.update(context, :__get_query_name_arg__, [elem], &[elem | &1])}
   end
 
-  defp do_call(:get_signal, %{context: context} = resolution) do
+  defp do_call(:get_signal, %Resolution{context: context} = resolution) do
     %{arguments: %{signal: signal}} = resolution
     selectors = get_selectors(resolution)
     elem = {:get_signal, signal, selectors}
 
     %{resolution | context: Map.update(context, :__get_query_name_arg__, [elem], &[elem | &1])}
   end
 
-  defp do_call(_query_field, resolution) do
+  defp do_call(_query_field, %Resolution{} = resolution) do
     resolution
   end
 
   @fields_with_selector ["timeseriesData", "timeseriesDataPerSlug", "aggregatedTimeseriesData"]
-  defp get_selectors(resolution) do
+  defp get_selectors(%Resolution{} = resolution) do
     resolution.definition.selections
     |> Enum.map(fn %{name: name} = field ->
       case Inflex.camelize(name, :lower) do