Merge branch 'develop' into y26-106-ug200-sample-sheet-generator

Author: yoldas

Gemfile.lock

@@ -247,7 +247,7 @@ GEM
     ffi (1.17.3-arm64-darwin)
     ffi (1.17.3-x86_64-darwin)
     ffi (1.17.3-x86_64-linux-gnu)
-    flipper (1.4.0)
+    flipper (1.4.1)
       concurrent-ruby (< 2)
     flipper-active_record (1.4.0)
       activerecord (>= 4.2, < 9)

app/controllers/sample_manifest_upload_with_tag_sequences_controller.rb

@@ -40,11 +40,16 @@ def rows_with_warnings
     end
   end
 
-  def apply_warning_flash(rows)
-    flash[:warning] = {
-      'Sample manifest uploaded with warnings!':
-        rows.flat_map { |row| row.warnings.full_messages }.uniq
-    }
+  def apply_warning_flash(rows) # rubocop:disable Metrics/AbcSize
+    # There are more than 10 messages, truncate the list and add a note about it.
+    # This is to prevent the flash from becoming too large and causing issues with cookies.
+    row_messages = rows.flat_map { |row| row.warnings.full_messages }.uniq
+    if row_messages.size > 10
+      # IfUnlessModifier doesn't improve readability
+      row_messages = row_messages.first(10) + ["and #{row_messages.size - 10} more..."]
+    end
+
+    flash[:warning] = { 'Sample manifest uploaded with warnings!': row_messages }
 
     redirect_target = (@uploader.study.present? ? sample_manifests_study_path(@uploader.study) : sample_manifests_path)
     redirect_to redirect_target

spec/controllers/sample_manifest_upload_with_tag_sequences_controller_spec.rb

@@ -68,6 +68,47 @@
       end
     end
 
+    context 'when the upload succeeds with more than 10 warnings' do
+      let(:warning_rows) do
+        (1..12).map do |i|
+          double(warnings: double(full_messages: ["Row #{i} warning"]))
+        end
+      end
+
+      before do
+        allow(controller).to receive(:upload_manifest) do
+          controller.instance_variable_set(:@uploader, uploader)
+          true
+        end
+        allow(controller).to receive(:rows_with_warnings).and_return(warning_rows)
+        post :create, params: { upload: upload_file }
+      end
+
+      it 'sets warning flash message' do
+        expect(flash[:warning]).to eq(
+          {
+            'Sample manifest uploaded with warnings!': [
+              'Row 1 warning',
+              'Row 2 warning',
+              'Row 3 warning',
+              'Row 4 warning',
+              'Row 5 warning',
+              'Row 6 warning',
+              'Row 7 warning',
+              'Row 8 warning',
+              'Row 9 warning',
+              'Row 10 warning',
+              'and 2 more...'
+            ]
+          }
+        )
+      end
+
+      it 'redirects correctly' do
+        expect(response).to redirect_to(sample_manifests_path)
+      end
+    end
+
     context 'when the upload fails due to invalid data' do
       before do
         allow(uploader).to receive(:run!).and_raise(AccessionService::AccessionValidationFailed, 'Invalid data')