Problem when refreshing git repo

[GillesMocellin]

Modifications on the letsencrypt Git repo is often not a simple fast-forward.
in install.sls, the git.latest fails.
We need something like a force_fetch option.
I tried, it worked, but with a strange warning.

My modification :

diff --git a/letsencrypt/install.sls b/letsencrypt/install.sls
index 31b279b..6876a50 100644
--- a/letsencrypt/install.sls
+++ b/letsencrypt/install.sls
@@ -8,3 +8,4 @@ letsencrypt-client-git:
     - name: https://github.com/letsencrypt/letsencrypt
     - target: {{ letsencrypt.cli_install_dir }}
     - force_reset: True
+    - force_fetch: True

The Warning :

    git_|-letsencrypt-client-git_|-https://github.com/letsencrypt/letsencrypt_|-latest:
        ----------
        __run_num__:
            0
        changes:
            ----------
        comment:
        duration:                                                                                                                                                                         1691.61
        name:
            https://github.com/letsencrypt/letsencrypt
        result:
            True
        start_time:
            10:50:29.373780                                                                                                                                                           warnings:
            - 'force_fetch' is an invalid keyword argument for 'git.latest'. If you were trying to pass additional data to be used in a template context, please populate 'con
text' with 'key: value' pairs. Your approach will work until Salt Carbon is out. Please update your state files.

[boltronics]

Here is an example of the error:

----------
          ID: letsencrypt-client-git
    Function: git.latest
        Name: https://github.com/letsencrypt/letsencrypt
      Result: False
     Comment: Fetch failed. Set 'force_fetch' to True to force the fetch if the failure was due to not being able to fast-forward. Output of the fetch command follows:
              
              From https://github.com/letsencrypt/letsencrypt
                 6bdb87d..324caf2  acme-v2    -> origin/acme-v2
               ! [rejected]        actually-file-update-apache -> origin/actually-file-update-apache  (non-fast-forward)
                 ef72970..b25ea22  auto-path  -> origin/auto-path
                 6c52cc4..16ed141  master     -> origin/master
                 26f82a2..121d729  os-auto-update-system -> origin/os-auto-update-system
     Started: 10:59:47.014617
    Duration: 4314.285 ms
     Changes:   

Is the force_fetch issue still a problem in Salt 2017.7.0? I couldn't find any bug reports about this, and it doesn't throw the error you have described for me (at least during normal execution without changes). Will update this and open a bug report if I see otherwise.

In any case, not having force_fetch set to True here sounds like a bug in this formula. If that argument throws a warning, then that's a separate bug in Salt.