Skip to content

upgrade xtermjs -- blocked on bug on Safari 15.6 #6406

@williamstein

Description

@williamstein

This commit 7fec078 upgraded us to the latest Xterm.js. It works fine on all browsers installed on my computer. However, it does NOT work on seemingly most slightly older browsers. By broken, I mean that it doesn't work at all -- it looks like this (i.e., the fit addon is wrong):

image

As an example, it does not work on Safari 15.6, which is the newest browser you can use on the very-much-still-supported previous version of macOS (Monterey), and it doesn't work with the newest Safari on Big Sur either. Users of Monterey can use the latest Chrome or Firefox just fine (!), but the newest Safari for their OS breaks. This is easy to reproduce on browserstack.com, but I have no other way to reproduce this, since I don't know how to install an older browser on macOS Ventura.

I also recall that before the https://www.npmjs.com/package/xterm-addon-fit was updated, xtermjs 5.1 was broken on all my latest test systems. Somehow xterm-addon-fit was changed to make it work with xtermjs 5.1, and that fix must have used functionality that is not properly supported in Safari 15.6.

I'm not sure what to do about this annoying situation, except just stay with a downgraded xtermjs for 6 months and check back. The other option would be to look at exactly how xterm-addon-fit works, what was changed, and try to fix it.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions