Remove behaviors (yiisoft#130)

* Remove behaviors completely

* Apply fixes from StyleCI

* AbstractMessage is removed

Co-authored-by: StyleCI Bot <[email protected]>

Author: viktorprogger

docs/guide/README.md

@@ -6,7 +6,6 @@ An extension for running tasks asynchronously via queues.
 
 * [Usage basics](usage.md)
 * [Migrating from `yii2-queue`](migrating-from-yii2-queue.md)
-* [Message behaviors](behaviors.md)
 * [Errors and retryable jobs](retryable.md)
 * [Workers](worker.md)
 * [Adapter list](adapter-list.md)

docs/guide/behaviors.md

@@ -17,10 +17,9 @@ and more structured than the old one allowing better maintenance.
 There was a concept in [yiisoft/yii2-queue] called `Job`: you had to push it to the queue, and it was executed after
 being consumed. In the new package it is divided into two different concepts: a message and a handler.
 
-- A `Message` is a class implementing `MessageInterface`. It contains 3 types of data:
+- A `Message` is a class implementing `MessageInterface`. It contains 2 types of data:
     - Name. Worker uses it to find the right handler for a message.
     - Data. Any serializable data which should be used by the message handler.
-    - Behaviors. Message behaviors used by adapters. For example, priority setting, message delaying, etc. [See more](behaviors.md).
 
     All the message data is fully serializable (that means message `data` must be serializable too). It allows you to
     freely choose where and how to send and process jobs. Both can be implemented in a single application, or

docs/guide/migrating-from-yii2-queue.md

@@ -45,8 +45,7 @@ $queue->push($message);
 To push a job into the queue that should run after 5 minutes:
 
 ```php
-$message->attachBehavior(new DelayBehavior(5 * 60));
-$queue->push($message);
+// TODO
 ```
 
 **Important:** Not every adapter (such as synchronous adapter) supports delayed execution.

docs/guide/usage.md

@@ -6,7 +6,6 @@
 
 use InvalidArgumentException;
 use Yiisoft\Yii\Queue\Enum\JobStatus;
-use Yiisoft\Yii\Queue\Exception\BehaviorNotSupportedException;
 use Yiisoft\Yii\Queue\Message\MessageInterface;
 
 interface AdapterInterface
@@ -31,8 +30,6 @@ public function status(string $id): JobStatus;
      * Pushing a message to the queue. Adapter sets message ID if available.
      *
      * @param MessageInterface $message
-     *
-     * @throws BehaviorNotSupportedException Adapter may throw exception when it does not support all the attached behaviors.
      */
     public function push(MessageInterface $message): void;
 

src/Adapter/AdapterInterface.php

@@ -6,33 +6,21 @@
 
 use InvalidArgumentException;
 use Yiisoft\Yii\Queue\Enum\JobStatus;
-use Yiisoft\Yii\Queue\Message\Behaviors\ExecutableBehaviorInterface;
 use Yiisoft\Yii\Queue\Message\MessageInterface;
 use Yiisoft\Yii\Queue\QueueFactory;
 use Yiisoft\Yii\Queue\QueueInterface;
 use Yiisoft\Yii\Queue\Worker\WorkerInterface;
 
 final class SynchronousAdapter implements AdapterInterface
 {
-    private const BEHAVIORS_AVAILABLE = [];
-
     private array $messages = [];
-    private WorkerInterface $worker;
-    private QueueInterface $queue;
     private int $current = 0;
-    private ?BehaviorChecker $behaviorChecker;
-    private string $channel;
 
     public function __construct(
-        WorkerInterface $worker,
-        QueueInterface $queue,
-        string $channel = QueueFactory::DEFAULT_CHANNEL_NAME,
-        ?BehaviorChecker $behaviorChecker = null
+        private WorkerInterface $worker,
+        private QueueInterface $queue,
+        private string $channel = QueueFactory::DEFAULT_CHANNEL_NAME,
     ) {
-        $this->worker = $worker;
-        $this->queue = $queue;
-        $this->channel = $channel;
-        $this->behaviorChecker = $behaviorChecker;
     }
 
     public function __destruct()
@@ -72,17 +60,6 @@ public function status(string $id): JobStatus
 
     public function push(MessageInterface $message): void
     {
-        $behaviors = $message->getBehaviors();
-        if ($this->behaviorChecker !== null) {
-            $this->behaviorChecker->check(self::class, $behaviors, self::BEHAVIORS_AVAILABLE);
-        }
-
-        foreach ($behaviors as $behavior) {
-            if ($behavior instanceof ExecutableBehaviorInterface) {
-                $behavior->execute();
-            }
-        }
-
         $key = count($this->messages) + $this->current;
         $this->messages[] = $message;