Extract some methods in separate classes

Author: ruudk

src/DirectiveProcessor.php

@@ -0,0 +1,51 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ruudk\GraphQLCodeGenerator;
+
+use GraphQL\Language\AST\DirectiveNode;
+use GraphQL\Language\AST\NodeList;
+use GraphQL\Language\AST\StringValueNode;
+
+final class DirectiveProcessor
+{
+    /**
+     * Check if a field has @include or @skip directive
+     *
+     * @param NodeList<DirectiveNode> $directives
+     */
+    public function hasIncludeOrSkipDirective(NodeList $directives) : bool
+    {
+        foreach ($directives as $directive) {
+            if (in_array($directive->name->value, ['include', 'skip'], true)) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
+    /**
+     * Extract the @indexBy directive field path
+     *
+     * @param NodeList<DirectiveNode> $directives
+     * @return list<string>
+     */
+    public function getIndexByDirective(NodeList $directives) : array
+    {
+        foreach ($directives as $directive) {
+            if ($directive->name->value !== 'indexBy') {
+                continue;
+            }
+
+            if ( ! $directive->arguments[0]->value instanceof StringValueNode) {
+                continue;
+            }
+
+            return explode('.', $directive->arguments[0]->value->value);
+        }
+
+        return [];
+    }
+}

src/GraphQLCodeGenerator.php

@@ -6,7 +6,6 @@
 
 use Exception;
 use GraphQL\Error\InvariantViolation;
-use GraphQL\Language\AST\DirectiveNode;
 use GraphQL\Language\AST\DocumentNode;
 use GraphQL\Language\AST\FieldNode;
 use GraphQL\Language\AST\FragmentSpreadNode;
@@ -16,7 +15,6 @@
 use GraphQL\Language\AST\NodeList;
 use GraphQL\Language\AST\OperationDefinitionNode;
 use GraphQL\Language\AST\SelectionSetNode;
-use GraphQL\Language\AST\StringValueNode;
 use GraphQL\Language\Parser;
 use GraphQL\Language\Printer;
 use GraphQL\Type\Definition\EnumType;
@@ -143,6 +141,8 @@ final class GraphQLCodeGenerator
     private readonly DataClassGenerator $dataClassGenerator;
     private readonly InputTypeGenerator $inputTypeGenerator;
     private TypeMapper $typeMapper;
+    private DirectiveProcessor $directiveProcessor;
+    private VariableParser $variableParser;
 
     /**
      * @var array<string, SymfonyType>
@@ -323,6 +323,10 @@ public function generate() : array
             $this->objectTypes,
         );
 
+        // Initialize helper classes
+        $this->directiveProcessor = new DirectiveProcessor();
+        $this->variableParser = new VariableParser($this->typeMapper);
+
         foreach ($this->schema->getTypeMap() as $typeName => $type) {
             if (str_starts_with($typeName, '__')) {
                 continue;
@@ -451,7 +455,7 @@ private function processOperation(DocumentNode $document, string $relativeFilePa
         $queryDir = $this->config->outputDir . '/' . $operationType;
         $operationDir = $queryDir . '/' . $operationName;
 
-        $variables = $this->parseVariables($operation);
+        $variables = $this->variableParser->parseVariables($operation);
 
         $relativePath = str_replace($this->config->outputDir . '/', '', $queryDir . '/' . $queryClassName . $operationType . '.php');
         $this->files[$relativePath] = $this->operationClassGenerator->generate(
@@ -509,33 +513,6 @@ private function processOperation(DocumentNode $document, string $relativeFilePa
         );
     }
 
-    /**
-     * @return array<string, SymfonyType>
-     */
-    private function parseVariables(OperationDefinitionNode $operation) : array
-    {
-        $required = [];
-        $optional = [];
-
-        foreach ($operation->variableDefinitions as $varDef) {
-            $name = $varDef->variable->name->value;
-            $type = $this->typeMapper->mapGraphQLASTTypeToPHPType($varDef->type);
-
-            if ($type instanceof SymfonyType\NullableType) {
-                $optional[$name] = $type;
-
-                continue;
-            }
-
-            $required[$name] = $type;
-        }
-
-        return [
-            ...$required,
-            ...$optional,
-        ];
-    }
-
     /**
      * @param list<string> $indexBy
      *
@@ -668,7 +645,7 @@ private function parseSelectionSet(
                     $indexBy = [];
 
                     if ($this->config->indexByDirective) {
-                        $indexBy = $this->getIndexByDirective($selection->directives);
+                        $indexBy = $this->directiveProcessor->getIndexByDirective($selection->directives);
 
                         if ($indexBy !== []) {
                             $indexByType = $this->typeMapper->mapGraphQLTypeToPHPType(RecursiveTypeFinder::find($nakedFieldType, $indexBy));
@@ -734,7 +711,7 @@ private function parseSelectionSet(
                         $this->inlineFragmentRequiredFields,
                     );
 
-                    if ($this->hasIncludeOrSkipDirective($selection->directives)) {
+                    if ($this->directiveProcessor->hasIncludeOrSkipDirective($selection->directives)) {
                         $subType = SymfonyType::nullable($subType);
                         $subPayloadShape = SymfonyType::nullable($subPayloadShape);
                     }
@@ -931,41 +908,6 @@ private function getPossibleTypes(Type $type) : array
         return [];
     }
 
-    /**
-     * @param NodeList<DirectiveNode> $directives
-     */
-    private function hasIncludeOrSkipDirective(NodeList $directives) : bool
-    {
-        foreach ($directives as $directive) {
-            if (in_array($directive->name->value, ['include', 'skip'], true)) {
-                return true;
-            }
-        }
-
-        return false;
-    }
-
-    /**
-     * @param NodeList<DirectiveNode> $directives
-     * @return list<string>
-     */
-    private function getIndexByDirective(NodeList $directives) : array
-    {
-        foreach ($directives as $directive) {
-            if ($directive->name->value !== 'indexBy') {
-                continue;
-            }
-
-            if ( ! $directive->arguments[0]->value instanceof StringValueNode) {
-                continue;
-            }
-
-            return explode('.', $directive->arguments[0]->value->value);
-        }
-
-        return [];
-    }
-
     private function singularize(string $fieldName) : string
     {
         $options = $this->inflector->singularize($fieldName);

src/VariableParser.php

@@ -0,0 +1,44 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ruudk\GraphQLCodeGenerator;
+
+use GraphQL\Language\AST\OperationDefinitionNode;
+use Symfony\Component\TypeInfo\Type as SymfonyType;
+
+final class VariableParser
+{
+    public function __construct(
+        private readonly TypeMapper $typeMapper,
+    ) {}
+
+    /**
+     * Parse GraphQL operation variables into PHP types
+     *
+     * @return array<string, SymfonyType>
+     */
+    public function parseVariables(OperationDefinitionNode $operation) : array
+    {
+        $required = [];
+        $optional = [];
+
+        foreach ($operation->variableDefinitions as $varDef) {
+            $name = $varDef->variable->name->value;
+            $type = $this->typeMapper->mapGraphQLASTTypeToPHPType($varDef->type);
+
+            if ($type instanceof SymfonyType\NullableType) {
+                $optional[$name] = $type;
+
+                continue;
+            }
+
+            $required[$name] = $type;
+        }
+
+        return [
+            ...$required,
+            ...$optional,
+        ];
+    }
+}