Skip to content

Commit fd04aa1

Browse files
committed
Clarify that if any team member has implementation concerns, those must be resolved before merging
1 parent 064eb13 commit fd04aa1

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,9 @@ If there are no new concerns uncovered, then the implementation just needs to be
190190
checked over by at least one team member. They provide code review and feedback
191191
on the implementation, then the feedback is addressed and pull request updated.
192192
Once the pull request is in a good place and CI is passing, a team member may
193-
approve the pull request and merge it into Gloo.
193+
approve the pull request and merge it into Gloo. If any team member raises
194+
concerns with the implementation, they must be resolved before the pull request
195+
is merged.
194196

195197
#### Implementation Checklist
196198

0 commit comments

Comments
 (0)