regression: doctest no longer supports derive?

[Mark-Simulacrum]

• https://crater-reports.s3.amazonaws.com/beta-1.83-3/beta-2024-10-19/reg/structdoc-0.1.4/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.83-3/beta-2024-10-19/reg/uwc-1.0.8/log.txt

[Urgau]

• https://crater-reports.s3.amazonaws.com/beta-1.83-3/beta-2024-10-19/reg/structdoc-0.1.4/log.txt

This is expected, the (kind-of new) warn-by-default non_local_definitions lint is rightfully triggered here, the derive should put it's things under an unnamed const. However the crate also use #![deny(warnings)] so it unfortunately breaks, nothing we can do about that.

The lint is already in the language section of relnotes.

• https://crater-reports.s3.amazonaws.com/beta-1.83-3/beta-2024-10-19/reg/uwc-1.0.8/log.txt

Different issue, looks like an issue with the arguments passed to the doctest executable. Reminds me of #131095.

[Mark-Simulacrum]

Is this serde's derive? Has that already been fixed on newer versions of serde?

[saethlin]

Is this serde's derive? Has that already been fixed on newer versions of serde?

Yes and yes. The crate that's failing here is locked to serde 1.0.99 which was released in 2019, and it expands to this:

const _IMPL_DESERIALIZE_FOR_Point: () = {
    #[allow(unknown_lints)]
    #[allow(rust_2018_idioms)]
    extern crate serde as _serde;
    #[automatically_derived]
    impl<'de> _serde::Deserialize<'de> for Point {

Starting in serde 1.0.113 (released in 2020) the Derive macro expands to an unnamed const:

const _: () = {
    #[allow(rust_2018_idioms, clippy::useless_attribute)]
    extern crate serde as _serde;
    #[automatically_derived]
    impl<'de> _serde::Deserialize<'de> for Point {

Since the fix has been out for 4 years and has been a cargo update away the whole time, I don't think there's any action needed here.

[saethlin]

If someone wants an MCVE:

#[derive(serde::Deserialize)]
struct Point {}

[package]
name = "scratch"
version = "0.1.0"
edition = "2021"

[dependencies]
serde = { version = "=1.0.200", features = ["derive"] }

[apiraino]

Visiting this issue again. By reading the previous comment I think we can close this as "not as issue / accepted change".

(thanks for the triaging)